Received: by 2002:a05:6500:2018:b0:1fb:9675:f89d with SMTP id t24csp164470lqh; Thu, 30 May 2024 18:38:51 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVyIo6YfwhfrwArR/IDV4SI6unfB5RxikcySE6j4NgJO3eLKWE3DX/+sy8M1f5EDNr7J42N+Q/Dp30hWT+q4zpF7pBEc36QLX4LOYmq4g== X-Google-Smtp-Source: AGHT+IFgf5pkFfPJoAfuWBZaOQUt5x4NVfD9Vj3M/S6H4eDDKdLU6mD3J/4Ql3S85w8Y98t5K8VS X-Received: by 2002:a17:906:558c:b0:a5a:88c7:a89 with SMTP id a640c23a62f3a-a6820902b3cmr37650366b.35.1717119531656; Thu, 30 May 2024 18:38:51 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1717119531; cv=pass; d=google.com; s=arc-20160816; b=Y7UbKnT1TCCBcvvC6iM07IQNFjqNqPZyDEMKl3eGzr0MzqpXFtqdX1Vqe/OAeayd6u 8bxMGAup55x7K1SS0Sa+JpxKLXRkFTmF17/xSY5H5MZSgp4XRQkMMAPubYj2qfbYPYzk kQtRkZhjl9FpfUBtpKP53ADCCFwCrFpvzFLkZNj3JjYxhgD+2r4wWTlpM4C1Xs5Xb7iy CdCLDnjwwp1s5RBIGM2uGKvNGSW3Dzyd+rVLJ7rmMnoaAtYCRAUy6Fb3G5DzJMFDs2rk PX2yMg8unZw1VuDkbdrI1My0w6YhP9f1EcodTQv5vSBoz2oZz8LK/Be1GtS9MIC9dh5S Fkvg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :message-id:date:subject:cc:to:from:dkim-signature; bh=e4BSfaQ9/y/CGIhLXYeKCYUx1Qkub/afYw3tntVg6Ek=; fh=cGRrRHfMJzgfDpBcpAP9imVgaa0LYdnnOHP6nh4bcsI=; b=x0HAiYC8avGWdTwjYoUEohcvYwtRmCJ1pUpCQFpAVItSZCZ/rmteBLAiV+4lIYzyuM ChRbcg68A0vnABMUYQU/jwFr2wf8NSPnk6KlsO901TEG+/smJ+arwb9MJ8spuSQhw3ZW QsTpz0fhgcxDx8gcJvmcHJVfBxluy24wDs/7aBfXiLvTCgDy+gFnJJr24tnnIlwvJKZy qZLUOwpUaIqd6LSJd89SebXfkQ0vnTr02woXFT+xX5MLBgZVpiyn5WkLPTDWpzSubqAw SBB9YEXewIhl//wtgOWwxKPi+EmeowxkTXD+PDJKFpCAIzU4iOO2qLT3+4qFvPQxrJVi yo6Q==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@microchip.com header.s=mchp header.b=jlT9UCFF; arc=pass (i=1 spf=pass spfdomain=microchip.com dkim=pass dkdomain=microchip.com dmarc=pass fromdomain=microchip.com); spf=pass (google.com: domain of linux-kernel+bounces-196160-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-196160-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=microchip.com Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id a640c23a62f3a-a67e6f02b9fsi36301166b.97.2024.05.30.18.38.51 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 May 2024 18:38:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-196160-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@microchip.com header.s=mchp header.b=jlT9UCFF; arc=pass (i=1 spf=pass spfdomain=microchip.com dkim=pass dkdomain=microchip.com dmarc=pass fromdomain=microchip.com); spf=pass (google.com: domain of linux-kernel+bounces-196160-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-196160-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=microchip.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 618F71F20403 for ; Fri, 31 May 2024 01:38:51 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 8667B1AACB; Fri, 31 May 2024 01:35:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b="jlT9UCFF" Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.154.123]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E803217997; Fri, 31 May 2024 01:35:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=68.232.154.123 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717119333; cv=none; b=Yf6KDTKXniulUJXiJ9iDAi52jCo32orpG0Hl0ovwsvxPa1Crk/DDUPoGaFeZS2UZ4oWtcZoHUBJ/fEad//wV0V371ycJU0j6D822nx0fEbHyVL6jv8FfROu/Q9Jz8RI/Nu9UFiDXcDO1Mz/+qAf3g1TmqwvfjTTUKCy1tfHJx3I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717119333; c=relaxed/simple; bh=zLFIT7XW4up0CVQnRvr8v7E+UFd7Ne27jN3zvsFPxlU=; h=From:To:CC:Subject:Date:Message-ID:MIME-Version:Content-Type; b=FMy5qcZ0JUqa3wNaiL+eJr0uYTEQWCHX97eDX/6Fnkg3UwkpD4J54FpZH3J5ly3EkItUscUVDARgLVJ2rX3oLKO7hy2pMTbl2nbl33ETVQNFOnJCNresisHqoYxoUoxu53EFusLQXIoq9apwkmNv+OhazuZDBmhB+8kpoQCqwxQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=microchip.com; spf=pass smtp.mailfrom=microchip.com; dkim=pass (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b=jlT9UCFF; arc=none smtp.client-ip=68.232.154.123 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=microchip.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=microchip.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1717119332; x=1748655332; h=from:to:cc:subject:date:message-id:mime-version; bh=zLFIT7XW4up0CVQnRvr8v7E+UFd7Ne27jN3zvsFPxlU=; b=jlT9UCFFzQzEOJP4gTciLZzXL4TkL9zO2OCpuHPKH25gIhnFdgXc1fni tEjxQvCKarR8b/f06cVNa5thPz4iTv692sZMX+aCqi/uP4ITUsDwlFI6m 2PjZxQf8DczU35jJI3yHesMb6gz+Cagf/FcLvRn7jtySnQQQSPhivHNi2 2tx7IZ60IllEBdoPRW64Ff5K9f8zgwSJZYD0C8NdFaQUDD653I/NgPkNw yspGW1hXVrj//Oz03Wl6if6zyBme0rhNC+UapKNDuWsbM/55B5eBdNHrE FUSLm5KtMC5p/sS2ZjqgQ3FkEr0mnPPod3ZxomvklSEPFD7KXq4vuV7Nm Q==; X-CSE-ConnectionGUID: uaX4rQuDRYaqKusCUzsbmg== X-CSE-MsgGUID: VbXv9pbSRWe4ULR1kz/fsQ== X-IronPort-AV: E=Sophos;i="6.08,202,1712646000"; d="scan'208";a="27407181" X-Amp-Result: SKIPPED(no attachment in message) Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa2.microchip.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 30 May 2024 18:35:29 -0700 Received: from chn-vm-ex04.mchp-main.com (10.10.85.152) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 30 May 2024 18:35:09 -0700 Received: from hat-linux.microchip.com (10.10.85.11) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server id 15.1.2507.35 via Frontend Transport; Thu, 30 May 2024 18:35:08 -0700 From: To: Woojung Huh , Andrew Lunn , Vivien Didelot , Florian Fainelli , Vladimir Oltean CC: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , , , , Tristram Ha Subject: [PATCH v1 net] net: dsa: microchip: fix RGMII error in KSZ DSA driver Date: Thu, 30 May 2024 18:38:31 -0700 Message-ID: <1717119511-3401-1-git-send-email-Tristram.Ha@microchip.com> X-Mailer: git-send-email 1.9.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain From: Tristram Ha The driver should return RMII interface when XMII is running in RMII mode. Fixes: 0ab7f6bf1675 ("net: dsa: microchip: ksz9477: use common xmii function") Signed-off-by: Tristram Ha Acked-by: Arun Ramadoss Acked-by: Jerry Ray Reviewed-by: Andrew Lunn --- v1 - Add review from Andrew Lunn drivers/net/dsa/microchip/ksz_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/dsa/microchip/ksz_common.c b/drivers/net/dsa/microchip/ksz_common.c index 1e0085cd9a9a..2818e24e2a51 100644 --- a/drivers/net/dsa/microchip/ksz_common.c +++ b/drivers/net/dsa/microchip/ksz_common.c @@ -3142,7 +3142,7 @@ phy_interface_t ksz_get_xmii(struct ksz_device *dev, int port, bool gbit) else interface = PHY_INTERFACE_MODE_MII; } else if (val == bitval[P_RMII_SEL]) { - interface = PHY_INTERFACE_MODE_RGMII; + interface = PHY_INTERFACE_MODE_RMII; } else { interface = PHY_INTERFACE_MODE_RGMII; if (data8 & P_RGMII_ID_EG_ENABLE) -- 2.34.1