Received: by 2002:a05:6500:2018:b0:1fb:9675:f89d with SMTP id t24csp166783lqh; Thu, 30 May 2024 18:46:34 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVu5r7CnZxUjAjmr+8zkZ9abYH6sDgeJy93m2WAy6StXOykQu3OTqcuUSyb5NUDAomX77G5bcRYIOknP39NAxiXFC68kq0JVWu/OPi1hg== X-Google-Smtp-Source: AGHT+IHyl6YBGvxQxA4LJLRfL2lX+CIFjHX/d3FBD/kpeEzVhMYvrDwX9+/C+60sfbykmBiScfJE X-Received: by 2002:a17:90a:f98d:b0:2bd:dce4:8f90 with SMTP id 98e67ed59e1d1-2c1dc560445mr449672a91.6.1717119994469; Thu, 30 May 2024 18:46:34 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1717119994; cv=pass; d=google.com; s=arc-20160816; b=vd48HSueFQCnYJULuifNf69JiG/0oBHzFCr474UTPHmlX6uvV0u7cXQ3Guuqu51wdj jFEAL9ZK6ssP2ITlgakyVqZ7fXj6fGm1XPTV/vKOUhNQa1orYoGkGeVkd6MKAh3oV8FP 8a+uLs0ee/O2jPU5mNNssMpl+tJEwbJuUgxu6EIAnE5xCBKNmt141ESRqcTZr7sJE3+E I6hr9Gm0qpnhTxMQyk5NkIq1CFPMmBFCWmiuP9EgCP5X0+2TS/jE4nlKKnxxE+FdZIYb Iy37hEKL9CCWbR1QpW8W/vtxYt0q6do6+4z7vLh6+VnpCIB48kZbirt/X6bYr3MFCgUy WStA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:subject :references:in-reply-to:cc:to:from:dkim-signature; bh=VxgHarzDtgbT8/ObYTgg1m1M6VzyS5V0Ao63Wtq4STU=; fh=EyJJ0jV2MJN1f3zNktSdoxaRhKwn23D9YZUW0vMNLTw=; b=TAHtX6m2qac+feEIcrmIh7lQ2h0ae13dHYgDWk09Dc/cQ+HA4Ni7UjVFlGv4tFkOzn vmzp7RVa4GuTR1QrEg+dZYpqou5JoTGu3WDyKzr92vgQ6j5gcS2MboWPSIEwlXB1iuh/ SwWBp4AZyHYfNloQ+wHt/gX1/7iJCFsETlWz+AB3Rh/ieox/VvGJd0JHghPTtF86ZZ5S hSvIJJSB8MFWYNmpHzPy02Aq/wyj3k+2LxPMPBS/hnfkQ6P1l8NnGY61K8BY4nH6xiIb OlYmLk39Rlh/54hhFmNG7eSOZBIYhD7qP/yGwWs1IZEmUu7RoYhcqRoXWFpdZnWK1jTt ovmw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel-dk.20230601.gappssmtp.com header.s=20230601 header.b=rRTTSiI7; arc=pass (i=1 spf=pass spfdomain=kernel.dk dkim=pass dkdomain=kernel-dk.20230601.gappssmtp.com); spf=pass (google.com: domain of linux-kernel+bounces-196168-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-196168-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id 98e67ed59e1d1-2c1a776d641si830320a91.23.2024.05.30.18.46.34 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 May 2024 18:46:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-196168-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20230601.gappssmtp.com header.s=20230601 header.b=rRTTSiI7; arc=pass (i=1 spf=pass spfdomain=kernel.dk dkim=pass dkdomain=kernel-dk.20230601.gappssmtp.com); spf=pass (google.com: domain of linux-kernel+bounces-196168-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-196168-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 01985286ACA for ; Fri, 31 May 2024 01:45:56 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 19E7617545; Fri, 31 May 2024 01:45:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b="rRTTSiI7" Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E9B702F52 for ; Fri, 31 May 2024 01:45:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717119946; cv=none; b=E5bPha3IWaqTaEknvrbNzJHDQ9jSM9zohmVpchXLpdhgZqZ/WiVowIKu6+6Dv5xtdf4kOfqfjIBKgwidDzc9lWac2Hby0otuyeaeda136rC5YB2/YDbeKmSUMOTyhEA9itv+cLMWFx8OT9iAjJ3teWmQp3UtxPN0ym29iNvLUmQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717119946; c=relaxed/simple; bh=TjIl2/33bs6RwTfiYeZL8n4d3JkXGlZVTl/oNecoK0w=; h=From:To:Cc:In-Reply-To:References:Subject:Message-Id:Date: MIME-Version:Content-Type; b=IyCZYNbHgVHHof+fnLWo8/M+HyaqZYYfJDHsQym/wDRBnTZobdyhDR1fjWv4PrGRh00V7m1qYHD8Dm/45gBlaaMfPszMiEM0zct7Hpnjnl9pVEDa06unNsBl7HUoY4FFY3N+hsAl+cFaKCpjlRO7pUZrPWN810FnLPT/MMdTWeQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b=rRTTSiI7; arc=none smtp.client-ip=209.85.210.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-7022c872aa1so32707b3a.3 for ; Thu, 30 May 2024 18:45:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1717119943; x=1717724743; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=VxgHarzDtgbT8/ObYTgg1m1M6VzyS5V0Ao63Wtq4STU=; b=rRTTSiI7u53wQKiX0lG8yYtwmhCJwwVWjjJl0/fgPIcT6PjhFvCRX2vR52q4DaxI2O xdRmc27c0OLptW2rm7/Fkz33Wi1giXuzmHjDWGIsx9W/xYVBmvKKS2LHK3ftgLlrfSDc rR8FcQnrO1MHtG69vxlg3eVIF3Ikq3a3otscx7CcrdjruVBPdcXSLo34DYpnGt241g7p obcxBjxZaBnmW2WIg4FYA0LAFBtX5Fs3p3bj/m/J7M1wPkIJvZ+Y+u/+DG6qBFBr8Z6b 6353esA4txlPVlkS/CmVzQg645+GHjqZ1i8hWTLZjSnuo8wCQNkm7ACT5O5dJxQW/5ed 9htQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717119943; x=1717724743; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VxgHarzDtgbT8/ObYTgg1m1M6VzyS5V0Ao63Wtq4STU=; b=fo4BUYKkkUXpHQ7hjPvjot60iw5wxKMgmwd10FYceIO4V2otuCzN4ipexRnzMIEXUJ H49nyLlhpcR9Wdet3VTYao0zjOKTguHRjAL0MOgOEfD9q1yR8bp2AVQOzjz6QQtwlYHG vxnZO8Uxmagiu7WsShDMnGSgRTo5yQbwFphsKqAMPZAUz+AXpk0ftplWg+kZaIqGsUTU nqfC4nmply6laoHndMIjVkU6B4WwaTK0qaK8xFqahaVdbLMp2Q0k5q8u5sRPYWNCvcQE eidp9RrYUNwMEEZB1ijS4VwEl0Ukbf/H5CvPW/pmDG4f962EbxJloHRUNu77wX7s0WkH oZOg== X-Forwarded-Encrypted: i=1; AJvYcCVVH9qQJ/7z9UkLvzBqyVzzKa/fv5vj0uH1NQejLoCiNyzJXILQX5+9OD50HWb+QExSK6bJ0zscjTjo9ZAbAsXIefv5sJjeL6DLKlSK X-Gm-Message-State: AOJu0YxxxDoa8qyXfPsf8dkziJtdPXTaXJi789Y7Nxq+6EVETtniZqz6 IF+ygEoT9Agf7qHEpKdTEwj7OV3iaeETShT2w/SN8Iyub5LyrC+51HFuci88oFU= X-Received: by 2002:a62:e116:0:b0:6ec:ee44:17bb with SMTP id d2e1a72fcca58-70247899e76mr542825b3a.2.1717119943064; Thu, 30 May 2024 18:45:43 -0700 (PDT) Received: from [127.0.0.1] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-702423cb359sm376354b3a.5.2024.05.30.18.45.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 May 2024 18:45:42 -0700 (PDT) From: Jens Axboe To: Tejun Heo , Josef Bacik , Waiman Long Cc: cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Dan Schatzberg , Ming Lei , Justin Forbes In-Reply-To: <20240530134547.970075-1-longman@redhat.com> References: <20240530134547.970075-1-longman@redhat.com> Subject: Re: [PATCH] blk-throttle: Fix incorrect display of io.max Message-Id: <171711994168.606218.16094424745811206145.b4-ty@kernel.dk> Date: Thu, 30 May 2024 19:45:41 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.12.5-dev-2aabd On Thu, 30 May 2024 09:45:47 -0400, Waiman Long wrote: > Commit bf20ab538c81 ("blk-throttle: remove CONFIG_BLK_DEV_THROTTLING_LOW") > attempts to revert the code change introduced by commit cd5ab1b0fcb4 > ("blk-throttle: add .low interface"). However, it leaves behind the > bps_conf[] and iops_conf[] fields in the throtl_grp structure which > aren't set anywhere in the new blk-throttle.c code but are still being > used by tg_prfill_limit() to display the limits in io.max. Now io.max > always displays the following values if a block queue is used: > > [...] Applied, thanks! [1/1] blk-throttle: Fix incorrect display of io.max commit: 0a751df4566c86e5a24f2a03290dad3d0f215692 Best regards, -- Jens Axboe