Received-SPF: pass (google.com: domain of linux-kernel+bounces-196196-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Precedence: bulk
MIME-Version: 1.0
Date: Fri, 31 May 2024 04:45:28 +0200
From: Dragan Simic <dsimic@manjaro.org>
To: Diederik de Haas <didi.debian@cknow.org>
Cc: Alexey Charkov <alchark@gmail.com>, linux-rockchip@lists.infradead.org,
 heiko@sntech.de, linux-arm-kernel@lists.infradead.org,
 devicetree@vger.kernel.org, robh+dt@kernel.org, krzk+dt@kernel.org,
 conor+dt@kernel.org, linux-kernel@vger.kernel.org, quentin.schulz@cherry.de,
 wens@kernel.org, daniel.lezcano@linaro.org,
 krzysztof.kozlowski+dt@linaro.org, viresh.kumar@linaro.org
Subject: Re: [RFC PATCH] arm64: dts: rockchip: Make preparations for
 per-RK3588-variant OPPs
In-Reply-To: <511137f077495007f467d5927f42f85d@manjaro.org>
References: <673dcf47596e7bc8ba065034e339bb1bbf9cdcb0.1716948159.git.dsimic@manjaro.org>
 <CABjd4YxD41DEkBCZfkznLboEY9ZVOfTCLcj4S_kkcsVswbANyQ@mail.gmail.com>
 <9996796.SDjBYy7pSV@bagend> <511137f077495007f467d5927f42f85d@manjaro.org>
Message-ID: <06452ce330f0a712e4d765475c6cbc8b@manjaro.org>
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit

On 2024-05-29 13:33, Dragan Simic wrote:
> On 2024-05-29 13:09, Diederik de Haas wrote:
>> On Wednesday, 29 May 2024 11:57:45 CEST Alexey Charkov wrote:

[...]

>>> >  arch/arm64/boot/dts/rockchip/rk3588.dtsi      |  414 +--
>>> >  arch/arm64/boot/dts/rockchip/rk3588j.dtsi     |    6 +-
>>> >  arch/arm64/boot/dts/rockchip/rk3588s.dtsi     | 2671 +----------------
>>> 
>>> Rename detection didn't do a particularly great job here - wonder if
>>> we can do anything about it to minimize the patch size and ensure 
>>> that
>>> the change history is preserved for git blame...
>> 
>> +1
>> The diff does look awfully big for a rename operation, which was 
>> supposed to
>> (also only) "modify ... a bit".
> 
> I also don't like the size of the patch.  I just tried playing with
> specifying different values for the --find-renames and --find-copies
> options, but with no good results.  I'll have a look into the Git
> source later, to see what's actually going on with those options.

Yay, --break-rewrites makes the diff extremely compact. :) [1]

[1] 
https://git-scm.com/docs/git-diff#Documentation/git-diff.txt--Bltngtltmgt