Received-SPF: pass (google.com: domain of linux-kernel+bounces-196214-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <7af4fee2-1b37-4eb8-9d03-8b1a402ec00b@intel.com>
Date: Fri, 31 May 2024 11:16:03 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 00/20] iommu: Refactoring domain allocation interface
To: Baolu Lu <baolu.lu@linux.intel.com>, Joerg Roedel <joro@8bytes.org>, "Will
 Deacon" <will@kernel.org>, Robin Murphy <robin.murphy@arm.com>, "Jason
 Gunthorpe" <jgg@ziepe.ca>, Kevin Tian <kevin.tian@intel.com>
CC: David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>, "Kalle
 Valo" <kvalo@kernel.org>, Bjorn Andersson <andersson@kernel.org>, "Mathieu
 Poirier" <mathieu.poirier@linaro.org>, Alex Williamson
	<alex.williamson@redhat.com>, <mst@redhat.com>, Jason Wang
	<jasowang@redhat.com>, Thierry Reding <thierry.reding@gmail.com>, "Jonathan
 Hunter" <jonathanh@nvidia.com>, Mikko Perttunen <mperttunen@nvidia.com>,
	<iommu@lists.linux.dev>, <dri-devel@lists.freedesktop.org>,
	<linux-kernel@vger.kernel.org>
References: <20240529053250.91284-1-baolu.lu@linux.intel.com>
 <efd902f6-eafc-4a26-8057-bdd9d7d6e535@intel.com>
 <a1f2c08a-e92f-4080-b55e-8d6dbd94db78@linux.intel.com>
Content-Language: en-US
From: Yi Liu <yi.l.liu@intel.com>
In-Reply-To: <a1f2c08a-e92f-4080-b55e-8d6dbd94db78@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?akdKeHpRZVRBOTBzVG90bzBTWEdsV2FHUWJicnVqQTBlekp4WWppbmlncDRE?=
 =?utf-8?B?SU83QlhuUldSNUtmdkVWTnlDVVh2d2VqUDJkYmp0a3ZwU29KMCtJRk10K0JB?=
 =?utf-8?B?YWdPcERsejR2UzN0T3NBcVd2Q0lscGJ6cUZ6STkrMDZQdm1ZdEJaQzVPamVD?=
 =?utf-8?B?bUMyUkpGcnRheUdRZkFUeWRQT3dkZlZWczNlSXNJdTNqS3NBNFkyckNNNkxo?=
 =?utf-8?B?Y0U2dXRHZGp6dUJlY1JsbG9rZFM3U0x5aGd6MjM5Y01yZldZcTZmdmZGMHFs?=
 =?utf-8?B?aHhWZ2N1SWV1cFNGSGQ1aUFtQVZrY1N3dlZxNGZ1bGtpdDVaVHllWVBGRnNm?=
 =?utf-8?B?Zi9uQWx2anBhMkNIY1d6VTc5VVJPbjRnQ3g1cHJzY2dWNVc3OEhuRDl0Vi84?=
 =?utf-8?B?dGJKSDZFakUxK0p2RDlNTllxZktvYVFScFNwbUJxeXpWU1RRK3JlbWxtL21G?=
 =?utf-8?B?akNEaXhXekZBQlV2UCtXQnk2QnZLa2dMaGI5NGcyVEMva3Q2ZXZ0aWJhNVNL?=
 =?utf-8?B?RTdYSU9kM3JQYURpM1pvQWtaNm40Tlk3WHRSRWJac05oV3Fxc3c1cU9NVW5p?=
 =?utf-8?B?QjMvQ3FCN3hNbU13bGxCNTQwWk0wOWhFV0tpUlloWk1FQ3grS2gra2tjWEJG?=
 =?utf-8?B?Q2hCL0NVR2xQem45YndGRFRtenhVWEU3eXE0QTFlTU1WbkdMaGlxWHpYL2Rp?=
 =?utf-8?B?dUtScE5leEIwUmtydEIyT0ZwdGhkNFBrZXJaSTFEQXlhU1lFV0lKZ1BjdGhW?=
 =?utf-8?B?YStvMkxTM1A3WU1vSExyWEczVDNIUk03TVhtdEd3dm5ScS9sQUZaNk5kcjBH?=
 =?utf-8?B?OXVoSHk5Z2N4VWxaY05QeStRbENSaWU4MVJ1ZkxoQVJjb0k5eXhHSktLK2lG?=
 =?utf-8?B?eXNwelV1dDNHNG1ETXpyQ2JLd0JuZ1J3T1RBM1Zod2luT0JITFVRbTh6QXZP?=
 =?utf-8?B?VlBtTkx3TWNGajhIN2tEeWN1Y1RYQnhVMmhUMGRBeEVpV1g3cXpoQ3psSzIr?=
 =?utf-8?B?ZExkWXQ0bExvQ0swVXhnamVDTHZBSFEyVmwwbUxlT0hpUmU3UGpwbFBzamlC?=
 =?utf-8?B?cnJjWENQVXY5cTZHSTh1WE5OS0xwVTREQjJCTUZSUGN2MVIrVzJ6ejZGakpo?=
 =?utf-8?B?NUJzSmd5QUdWQXlWZjdDams4STE0V2pkeFJDc0FIYVFtaVBsQWZjL1JXYWpY?=
 =?utf-8?B?Y21ETXdXTzRONG9sbDkvYzFYU2NYdFROampsK2tVNVdBa0VjVkoxaWY3SWxI?=
 =?utf-8?B?STBPekJRY3VnREpRTXlUcGVUeks0NXdJVlFXVUJ1K1V2U05maG9vc0dvaS9G?=
 =?utf-8?B?bHF1L2FGSTJMUkJSaDRzWGk0aTV2R0N6RDNZNkRLYTFCWWl4Tk1mUmVSalVF?=
 =?utf-8?B?WEJiSjBIeWJpUXNhQjZ0UFdPUm4rYVljOEo3dDUrQzd0WHMrSEp4dFRFT3I0?=
 =?utf-8?B?aGtTZjlTSmVKQ3ZCOW1sc3lFRmZ6WXEwOFNXMlhxcVJldE90R0dNSW9NbTFv?=
 =?utf-8?B?U2FLODZ3MG42VFdtdmQ4bUVFbmJFbEtQNnBEc0dWTE80K21iY1BKaGliVHlZ?=
 =?utf-8?B?Z2l0V0xZOEh2dUJnSkJUbjdyZFpxcjRlSnptSVcyUjd5RExDc0N4bXQ4R2wr?=
 =?utf-8?B?UC9kdUExN3NPajBuNmpiQnZlcG80ZHlOYVZaUmJsTmtyazV2RnEvaHVOUUJK?=
 =?utf-8?B?WTI1bmRwSU1xaXQwaEloVDJuVmthVEJ4dG5uaHJYZjczelJSYXZrV1hkNHJk?=
 =?utf-8?B?SDFYZkNIejk4WVpPSm95VkduTjdLYVRCa29tMkp2bkR3MXJTZEtxSkVaR3Zk?=
 =?utf-8?B?WmZVRkdiTWlhRmw2OUJIR0NlVi9ZbEdwd0JQOUxQSUYydXcrOVNxa2hsZHZw?=
 =?utf-8?B?NE5iODNMSnFqT0ZINVh0dW5QRng5SVRRVGw3d2hXVWg1R2I2d2h0WmlYbFk2?=
 =?utf-8?B?OHZEaTlsd1BDa1VyQWhxb0d0ZEw2REtQdVBIYkNyNXNRUHlndGw4K1NhUDBs?=
 =?utf-8?B?UUNCeUNkZHFvYStscG1IaGtFS0Y2QndrTjA5VENLazlCdDVPTWtkRmliZlZM?=
 =?utf-8?B?d3lvNDBEVVRZVDZXTXNtelNkL0ZRdWc2MlNQY0VENVVrSitzdFJSTEFlTk85?=
 =?utf-8?Q?lADGNcMBAUZUIZ2vNYC2tn+Q7?=
X-MS-Exchange-CrossTenant-Network-Message-Id: de6afb29-1830-4270-1539-08dc811f76b4
X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7529.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 May 2024 03:12:11.8215
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: K1l+ldtEHiUkIs1bU4nEXCYpQJRk5p9arsgljm/Fd3J5H02CnDHu4mUUbPmpmgneB7vdbAHXhRGtmKVPfOxDUA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4585
X-OriginatorOrg: intel.com

On 2024/5/29 20:02, Baolu Lu wrote:
> On 2024/5/29 17:03, Yi Liu wrote:
>> On 2024/5/29 13:32, Lu Baolu wrote:
>>> The IOMMU subsystem has undergone some changes, including the removal
>>> of iommu_ops from the bus structure. Consequently, the existing domain
>>> allocation interface, which relies on a bus type argument, is no longer
>>> relevant:
>>>
>>>      struct iommu_domain *iommu_domain_alloc(struct bus_type *bus)
>>>
>>> This series is designed to refactor the use of this interface. It
>>> proposes two new interfaces to replace iommu_domain_alloc():
>>>
>>> - iommu_user_domain_alloc(): This interface is intended for allocating
>>>    iommu domains managed by userspace for device passthrough scenarios,
>>>    such as those used by iommufd, vfio, and vdpa. It clearly indicates
>>>    that the domain is for user-managed device DMA.
>>
>> user paging domain? It looks to me user domain includes the nested domains
>> as well.
> 
> Yes, nested domain is a user domain. The iommu driver should implement
> iommu_ops->domain_alloc_user for nested domain allocation.

will it be more clear to name iommu_user_domain_alloc() be
iommu_user_paging_domain_alloc() as it is mainly for paging domain
allocation?

>>
>>>    If an IOMMU driver does not implement iommu_ops->domain_alloc_user,
>>>    this interface will rollback to the generic paging domain allocation.
>>>
>>> - iommu_paging_domain_alloc(): This interface is for allocating iommu
>>>    domains managed by kernel drivers for kernel DMA purposes. It takes a
>>>    device pointer as a parameter, which better reflects the current
>>>    design of the IOMMU subsystem.
>>>
>>> The majority of device drivers currently using iommu_domain_alloc() do
>>> so to allocate a domain for a specific device and then attach that
>>> domain to the device. These cases can be straightforwardly migrated to
>>> the new interfaces.
>>>
>>> However, there are some drivers with more complex use cases that do
>>> not fit neatly into this new scheme. For example:
>>>
>>> $ git grep "= iommu_domain_alloc"
>>> arch/arm/mm/dma-mapping.c:      mapping->domain = iommu_domain_alloc(bus);
>>> drivers/gpu/drm/rockchip/rockchip_drm_drv.c:    private->domain = 
>>> iommu_domain_alloc(private->iommu_dev->bus);
>>> drivers/gpu/drm/tegra/drm.c:            tegra->domain = 
>>> iommu_domain_alloc(&platform_bus_type);
>>> drivers/infiniband/hw/usnic/usnic_uiom.c:       pd->domain = domain = 
>>> iommu_domain_alloc(dev->bus);
>>>
>>> This series leave those cases unchanged and keep iommu_domain_alloc()
>>> for their usage. But new drivers should not use it anymore.
>>
>> does it mean there is still domains allocated via iommu_domain_alloc()
>> on VT-d platform?
> 
> I think the drivers mentioned above do not run on x86 platforms, or do
> they?

cool. BTW. I know out-of-tree drivers are not counted in upstream review.
Just out of curious, is there a formal way to let such drivers know it is
no longer allowed to use iommu_domain_alloc() on VT-d?

-- 
Regards,
Yi Liu