Received-SPF: pass (google.com: domain of linux-kernel+bounces-196235-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <8601e84c-f920-4948-bb8a-e0951c6c13c5@amd.com>
Date: Fri, 31 May 2024 09:36:46 +0530
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3 3/3] KVM: SEV-ES: Fix LBRV code
To: Tom Lendacky <thomas.lendacky@amd.com>
Cc: seanjc@google.com, pbonzini@redhat.com, nikunj.dadhania@amd.com,
 tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
 dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com,
 michael.roth@amd.com, pankaj.gupta@amd.com, kvm@vger.kernel.org,
 linux-kernel@vger.kernel.org, santosh.shukla@amd.com, ravi.bangoria@amd.com
References: <20240523121828.808-1-ravi.bangoria@amd.com>
 <20240523121828.808-4-ravi.bangoria@amd.com>
 <562819b0-2c8a-1344-6090-01f8cdca107e@amd.com>
Content-Language: en-US
From: Ravi Bangoria <ravi.bangoria@amd.com>
In-Reply-To: <562819b0-2c8a-1344-6090-01f8cdca107e@amd.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?dmxpYmw2ZmtNVGEwZmcrRGJKZnM3OFVkV3RPZHJ4KzYwb0k5Y2M0MGpZQ01i?=
 =?utf-8?B?U1V2dUx3eTNXTDlyUVpuRlNubFlrZmJuVUcrMFNzNlc1OUZtdVNPU1I5TWwv?=
 =?utf-8?B?dWJoN2J5SlpTanB1bU9sVmZtL3J6dEp5V0x2UFhiSkFyRHd4azNDS0hRbVdh?=
 =?utf-8?B?ZURsNElvQzZaSUhLY0ZxeDl5QUFCUmVodzNEamh5YzZyMWhnTFlTVWRpRWRN?=
 =?utf-8?B?OGhvTCtHQng1N3V1d2NWTDZ0eVkyV1JzYm5nQUMvSlFxdlJRMmYvUXpkMWs0?=
 =?utf-8?B?aWc0cTdQTCtmbXdBOTRkRE02L1FwWCtGdWlGWTg5YkRqcWw1SXd6MnorVFRm?=
 =?utf-8?B?djI3aksyWEpTdEpVemkzR1E0Z1FIUFVjWXl3anVHS3p6N21KWWVZdE1qSFZS?=
 =?utf-8?B?d1BDNjlmaDh0NG42V1RtSjhNZjYrK2UwZ3IyTlZQNnJjMmNGbDlEUWlzQ1Vl?=
 =?utf-8?B?VXp4YnExeDBpVkh6Syt1SHJpNCtDTlg5UGgxMnhOVHNXallkUG9FQlNaYzRR?=
 =?utf-8?B?L3Rid3JUMERmNnUzRkYvbWtQcDdqWGtjTFdid2hNMFRKV3lwTnN5dkFaU2hs?=
 =?utf-8?B?Zy83bzhnVzhtcE1RSURKZ0lNLzJZSUlEVWpHbDZkRWZPQkE2T2J4dUFsQi9a?=
 =?utf-8?B?eUE5ZGQ4WTl6b2l2bjB6Q3FjUW00M2hpdlpFSTBNR1ZWYWJTWXhsQnNmWElX?=
 =?utf-8?B?bzRZWUpDWGZya2JTaU1jb2xScjRvb2J3VXZZdmQ2WUYyelVRQlZoWU5VRkUw?=
 =?utf-8?B?MU9mNklqM2FoY3VpSnV6dHFhL0RQQzY1WVVOZk4vS2tNR0xBcjcrQW1Fb2hq?=
 =?utf-8?B?algvcEhUMjRBUUQ3NFZGclFoQTFqN2Nib1ozOERtV0IwaFJoSWFSOVNFVFVG?=
 =?utf-8?B?ekdVeDhYbXg1L2JTeU1ZYzQxTnpYMlNGWTQ0TGRjRWdqcDQ0NGp5MDlMeFZ0?=
 =?utf-8?B?blB0MzlKUDlhakluSXZ5c1J4RUJyQk50QUtmSW1GekpjdXFvelRDVXlDTGE4?=
 =?utf-8?B?L2dTY1lkZXBkY0JvT0JCbmw0WVAzVFExMitEdnY0aXlVbysyWVltK3Zpa3pU?=
 =?utf-8?B?MUpwbE1UVm1qM0lSeDI5V3loOURjb2ExanhYYzd5Ym14TGVjNzI3dXB0N295?=
 =?utf-8?B?eFNjZDVhVTdydXhydFBvRFh3T1BCNllSQWRqRlNtVHF2TjdmZWowLytMVGVG?=
 =?utf-8?B?M1VBU25NYXh1QmlQK09qSGpPUldzcTJsazNUdUJFdEZCNVZKcEZYVWYvYUNm?=
 =?utf-8?B?SjNYUndmaHF3dlBINmJFMmgxcGlmTjRXTG1GejdWbkxPWGFVdmxuVEhzM3lJ?=
 =?utf-8?B?R25pZTlCU0VFLzlnV0dzTVFGNmoyeUtVcWNWSHhLZnUzT2xGTWhlbzhKSjRB?=
 =?utf-8?B?eDlvTXgwcE50RUZGeHNFMXp4ZThBUERGclcxZm9QclRPVy9FdHRFbUxIOC94?=
 =?utf-8?B?QmxzK2xiZWxTQ3dVUmRIMnQrVW52U1NJZ3UyeGFQbHRLaU9VaUVNanEvM3Zq?=
 =?utf-8?B?Sno0UVh4TWZTVFZMbG5jejRNc2w0ZFhOSDlRakVJT0ZYa2hNUVZ1ZFhFZzZq?=
 =?utf-8?B?VG9DcmZYanR3OTZlYkR3UEJIT0VCVDVQdnZDek9neDFPUmFMY1U5S2IrUkg4?=
 =?utf-8?B?RElFdEtwOExHQ2RBMncyWHFacG55VFA5Tm9UYWdZWlVMakVOeFFNWEhnUmFG?=
 =?utf-8?B?ODVzVy9QcUpvUkdJQlZXTFN1SDJ0UGdCSk1QSEg3ZVllOG5QbSttR1I2NitG?=
 =?utf-8?B?cmgwOVRkNGpzaHpMS0hRZENKaE1CQyszbzNNcFc0eVhmTVFWcGlBc0k1RGdm?=
 =?utf-8?B?enlITSsxNG9nRksxd0QzQkhjTVhpYUROQTJUTll1TUlEcWk1ZG8wZDQybTFp?=
 =?utf-8?B?dFdQUk81Ulp0b2lPdDFBd0xpRklac3F3UjJUcWxGYk5WakVyMmZGVUYyNmgv?=
 =?utf-8?B?dlZGeWhnMG9XNWIzMlFDRmRTS3N1bkphcjRnWkZtOGVhL0I4WmluTDdPSjNm?=
 =?utf-8?B?QzlJQlFhV1EwdThBenZVZFJoVWpVYjBGZmtWZXh6SmhrRURxZVBKUndMQXNJ?=
 =?utf-8?B?NzVWQVpEdEk5SHlhcUJ0U1VBL1U2aXdIeHd4ZCt0VVpibERjQmQ4TXE4L1Zs?=
 =?utf-8?Q?sY3iJ4xw5GOMjDu8CmAO6rcaP?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 392d2ed7-c515-43af-0d1b-08dc81271c7f
X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB6588.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 May 2024 04:06:56.5679
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: WGDilw5QvHa4j9w3JCIn0WKDQAmolSa+Sdh+aQeCboUnzT3xnnj1EWn8R+J9y8znfxjiNV+4TSoxaY3tofZbZQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB6030

On 5/30/2024 7:33 PM, Tom Lendacky wrote:
> On 5/23/24 07:18, Ravi Bangoria wrote:
>> As documented in APM[1], LBR Virtualization must be enabled for SEV-ES
>> guests. Although KVM currently enforces LBRV for SEV-ES guests, there
>> are multiple issues with it:
>>
>> o MSR_IA32_DEBUGCTLMSR is still intercepted. Since MSR_IA32_DEBUGCTLMSR
>>    interception is used to dynamically toggle LBRV for performance reasons,
>>    this can be fatal for SEV-ES guests. For ex SEV-ES guest on Zen3:
>>
>>    [guest ~]# wrmsr 0x1d9 0x4
>>    KVM: entry failed, hardware error 0xffffffff
>>    EAX=00000004 EBX=00000000 ECX=000001d9 EDX=00000000
>>
>>    Fix this by never intercepting MSR_IA32_DEBUGCTLMSR for SEV-ES guests.
>>    No additional save/restore logic is required since MSR_IA32_DEBUGCTLMSR
>>    is of swap type A.
>>
>> o KVM will disable LBRV if userspace sets MSR_IA32_DEBUGCTLMSR before the
>>    VMSA is encrypted. Fix this by moving LBRV enablement code post VMSA
>>    encryption.
>>
>> [1]: AMD64 Architecture Programmer's Manual Pub. 40332, Rev. 4.07 - June
>>       2023, Vol 2, 15.35.2 Enabling SEV-ES.
>>       https://bugzilla.kernel.org/attachment.cgi?id=304653
>>
>> Co-developed-by: Nikunj A Dadhania <nikunj@amd.com>
>> Signed-off-by: Nikunj A Dadhania <nikunj@amd.com>
>> Signed-off-by: Ravi Bangoria <ravi.bangoria@amd.com>
> 
> Should this have a Fixes: tag, too?

Yeah, will add
Fixes: 376c6d285017 ("KVM: SVM: Provide support for SEV-ES vCPU creation/loading")

Thanks,
Ravi