Received-SPF: pass (google.com: domain of linux-kernel+bounces-196236-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <a5895c1f-4f89-4da7-8977-e1d681a72442@ti.com>
Date: Fri, 31 May 2024 09:54:41 +0530
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH net-next v8 2/2] net: ti: icssg_prueth: add TAPRIO offload
 support
To: Jacob Keller <jacob.e.keller@intel.com>,
        MD Danish Anwar
	<danishanwar@ti.com>,
        Jan Kiszka <jan.kiszka@siemens.com>,
        Dan Carpenter
	<dan.carpenter@linaro.org>,
        Andrew Lunn <andrew@lunn.ch>, Simon Horman
	<horms@kernel.org>,
        Diogo Ivo <diogo.ivo@siemens.com>,
        Wolfram Sang
	<wsa+renesas@sang-engineering.com>,
        Randy Dunlap <rdunlap@infradead.org>,
        Niklas Schnelle <schnelle@linux.ibm.com>,
        Vladimir Oltean
	<vladimir.oltean@nxp.com>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        Richard
 Cochran <richardcochran@gmail.com>,
        Roger Quadros <rogerq@kernel.org>, Paolo
 Abeni <pabeni@redhat.com>,
        Jakub Kicinski <kuba@kernel.org>, Eric Dumazet
	<edumazet@google.com>,
        "David S. Miller" <davem@davemloft.net>
CC: <linux-arm-kernel@lists.infradead.org>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <srk@ti.com>,
        Roger Quadros <rogerq@ti.com>
References: <20240529110551.620907-1-danishanwar@ti.com>
 <20240529110551.620907-3-danishanwar@ti.com>
 <7143f846-623d-465f-a717-8c550407d012@intel.com>
Content-Language: en-US
From: "Anwar, Md Danish" <a0501179@ti.com>
In-Reply-To: <7143f846-623d-465f-a717-8c550407d012@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

Hi Jacob,

On 5/30/2024 11:45 PM, Jacob Keller wrote:
> 
> 
> On 5/29/2024 4:05 AM, MD Danish Anwar wrote:
>> From: Roger Quadros <rogerq@ti.com>
>>
>> The ICSSG dual-emac / switch firmware supports Enhanced Scheduled Traffic
>> (EST – defined in P802.1Qbv/D2.2 that later got included in IEEE
>> 802.1Q-2018) configuration. EST allows express queue traffic to be
>> scheduled (placed) on the wire at specific repeatable time intervals. In
>> Linux kernel, EST configuration is done through tc command and the taprio
>> scheduler in the net core implements a software only scheduler
>> (SCH_TAPRIO). If the NIC is capable of EST configuration,user indicate
>> "flag 2" in the command which is then parsed by taprio scheduler in net
>> core and indicate that the command is to be offloaded to h/w. taprio then
>> offloads the command to the driver by calling ndo_setup_tc() ndo ops. This
>> patch implements ndo_setup_tc() to offload EST configuration to ICSSG.
>>
>> Signed-off-by: Roger Quadros <rogerq@ti.com>
>> Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>
>> Reviewed-by: Simon Horman <horms@kernel.org>
>> Signed-off-by: MD Danish Anwar <danishanwar@ti.com>
>> ---
> 
> I tried to apply this series to review it. Unfortunately It no longer
> applies cleanly since it has textual conflicts with 972383aecf43 ("net:
> ti: icssg-switch: Add switchdev based driver for ethernet switch
> support"), which was part of:
> 
> https://lore.kernel.org/netdev/20240528113734.379422-1-danishanwar@ti.com/
> 
> The conflict seemed easy enough to resolve, but I'm not sure if the
> prueth_qos structure would be placed optimally. I tried to build the
> driver to check what the placement should be and was unable to get
> things to compile.

When I had posted this series (v8) the ICSSG switch series was not
merged yet and I had rebased this series on net-next/main. When you
tested it, the ICSSG Series was merged and as it resulted in conflict.

I will rebase it on the latest net-next and make sure that their is no
conflict and post next revision.

Thanks for your feedback.

-- 
Thanks and Regards,
Md Danish Anwar