Received-SPF: pass (google.com: domain of linux-kernel+bounces-196304-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Fri, 31 May 2024 13:52:40 +0800
From: kernel test robot <oliver.sang@intel.com>
To: Hugh Dickins <hughd@google.com>
CC: <oe-lkp@lists.linux.dev>, <lkp@intel.com>, <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>, Jan Kara <jack@suse.cz>, Tim Chen
	<tim.c.chen@intel.com>, Dave Chinner <dchinner@redhat.com>, "Darrick J. Wong"
	<djwong@kernel.org>, Axel Rasmussen <axelrasmussen@google.com>, "Carlos
 Maiolino" <cem@kernel.org>, Christian Brauner <brauner@kernel.org>, "Chuck
 Lever" <chuck.lever@oracle.com>, Johannes Weiner <hannes@cmpxchg.org>,
	"Matthew Wilcox" <willy@infradead.org>, <linux-mm@kvack.org>,
	<oliver.sang@intel.com>
Subject: [linus:master] [shmem,percpu_counter]  beb9868628:
 BUG:KCSAN:data-race_in__percpu_counter_limited_add/__percpu_counter_limited_add
Message-ID: <202405311100.d46f2cc1-lkp@intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?U5P9lv1mSaqZzvDKEF69D3j+/Lp1C/H8fw+AmJHg7HF9PqoJ/s44i3Zt+OU0?=
 =?us-ascii?Q?e2AmTEL0IvE4JLNNlsSbACvOPxCFiMJ8qxqp7Sr5h/8zOukCeRHjjvkqbJ4m?=
 =?us-ascii?Q?60e5ZH/mGAvHSuf09qwS/cB8sx8LKMnBS/+NWlzDuJAJckSVjxqINablvbfL?=
 =?us-ascii?Q?7ciq38eh1GTRwJU+QM8SDU69QBrOyyHVQaad1RuMHvGqCszoOdW7usdC/zgw?=
 =?us-ascii?Q?kguxsDBkCR/x3isLG2KIahruNf9fPMRWH2XFmlS49+V5Zrxis/7H4HH2Aai1?=
 =?us-ascii?Q?ga0Dgxj9x00KrNyvFFp1N6f5xWqDzztCwizSio5kOhWpQNElQ87yry1Uau9L?=
 =?us-ascii?Q?C0QsCTBK8zneLbHwfG1AfB9z8swVjYJrUEf+AqSO6L4KXeGMzN0GoFQB/qcX?=
 =?us-ascii?Q?DP0WNzEdp++6mBvXIJnr4Jx1xOpxTxQ8lrpADaabCpJN1s60EgK0sU/9WPHw?=
 =?us-ascii?Q?gQA/SIbW6ED03RvKw1VZz//+WrVTr1Gj/uuPNTcseq0U08Ld3PXp70O8bAL3?=
 =?us-ascii?Q?warkSAaCqwFmC/wMv9sMUS/mbfT+cJu4q82tnuuSTFg5s2hbxVLZLGNKDzMD?=
 =?us-ascii?Q?Ue36CWhD+W0JWb4VG6VBRer93knRgHqtEjxfykOrye8PtWC1V+F9GPswrd3m?=
 =?us-ascii?Q?uDhuiQeuPQBqQ31scwEc771+ln39KA8vlAdj8irVb1Vw+z/DWWmPgnB2hFaF?=
 =?us-ascii?Q?JGDjKI6YxOpLmpT0/p1mnaIaySZSDQCiRl60tDC0PQO3a2wcW5veSR6FTtUP?=
 =?us-ascii?Q?PsWreeGWkq1QcuRUerKcRXkTyyNmEUkmPLUf1hkFGZfQZfd89ttWH2sQB+QG?=
 =?us-ascii?Q?bUgK6gY3WYoz4sGT6yAZrJIr1eHv8d9yjsln6TY1mIVsNUcwZ7YpRdyZYvIC?=
 =?us-ascii?Q?XBnPLVqQyaHg59ny5vJD4f6O3EzlhC8heDpCiMjezCO1Cd7ZSkE6LtdlXuD5?=
 =?us-ascii?Q?GQIdHQkEJ14H+xsoMMkd64bf+EAWAkLG+P2fI+2HJbhK/Hr+SJ8EDhH2Ayy9?=
 =?us-ascii?Q?YbnLwi9HQ4sK3jNiq/LlhlrD9Ecn86Ct4AkQ0635oXGaU4/B3HN6ERS+OF+Z?=
 =?us-ascii?Q?SQ7JrLIkANtygKvHtr7dOBkta1y4rZJ6SB7ltNoGyoHkLNw/zdbEkrXFs0R7?=
 =?us-ascii?Q?eb7tvLAf0vmm5SfoPUomoCVpK4k2p/9p34o7i+9TY3LPeO/HRRxRtnDnTYfJ?=
 =?us-ascii?Q?Sv+408hVEeVoyo6QY5v0icPHKMWOeONDsnojE9Bwi7V6DFvIrwNKZ9QNXHrj?=
 =?us-ascii?Q?Mhz16zFv5p+HPKsoulKzEf6XuzcjJjHtCVulNg5JaL+iYiQYP/NC2wQXmpvt?=
 =?us-ascii?Q?81VSNhohkVH7IsRrvIw0U6KnR79l5XZcH80eUJDB954yKwDWtZKjI0NOUvHw?=
 =?us-ascii?Q?ufqzwnE03KNu3QMKSdxK2Rfq/T3dXPvRkCGZaRh2fBzrmxMsCn/kNiogH6zS?=
 =?us-ascii?Q?olBOV3tbiMcFOOmKOksbN/bcP6vjae15DBcY+8/kiVw9l+DMpCNWXiMbtexx?=
 =?us-ascii?Q?u73JCWTb0bX3fJcAUYY9x5jXv54a366O2ee2nj1MEF6WN02Lk8o5NPbVYvWG?=
 =?us-ascii?Q?rpQk5Ke3UuYCBf8SEjxzLXjaHAU1RFtnA6aNOkbCOB36DYvzPnRCm6GJv7Je?=
 =?us-ascii?Q?yw=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: cd9c5122-ad04-46a8-73bb-08dc8135e8d2
X-MS-Exchange-CrossTenant-AuthSource: LV3PR11MB8603.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 May 2024 05:52:52.2160
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: sKe84iUhqsmoUXMDFJwqPv6LTWtlN1Y6a5moSY4HsJ+UVpTSxKQx+SlUQA8RIPCZi8CEQbihaxpz7Uy91N2Nnw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR11MB6338
X-OriginatorOrg: intel.com


Hello,

kernel test robot noticed "BUG:KCSAN:data-race_in__percpu_counter_limited_add/__percpu_counter_limited_add" on:

commit: beb9868628445306958fd7b2da1cd369a4a381cc ("shmem,percpu_counter: add _limited_add(fbc, limit, amount)")
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git master

[test failed on linus/master      2bfcfd584ff5ccc8bb7acde19b42570414bf880b]
[test failed on linux-next/master 6dc544b66971c7f9909ff038b62149105272d26a]

in testcase: trinity
version: 
with following parameters:

	runtime: 300s
	group: group-01
	nr_groups: 5


compiler: gcc-12
test machine: qemu-system-x86_64 -enable-kvm -cpu SandyBridge -smp 2 -m 16G

(please refer to attached dmesg/kmsg for entire log/backtrace)


in our tests,
  dmesg.BUG:KCSAN:data-race_in__percpu_counter_limited_add/__percpu_counter_limited_add
does not always happen, 88 times out of 150 runs as below.


3022fd7af9604d44 beb9868628445306958fd7b2da1
---------------- ---------------------------
       fail:runs  %reproduction    fail:runs
           |             |             |
           :60         147%          88:150   dmesg.BUG:KCSAN:data-race_in__percpu_counter_limited_add/__percpu_counter_limited_add


If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <oliver.sang@intel.com>
| Closes: https://lore.kernel.org/oe-lkp/202405311100.d46f2cc1-lkp@intel.com


[  301.127451][ T4651] ==================================================================
[  301.128485][ T4651] BUG: KCSAN: data-race in __percpu_counter_limited_add / __percpu_counter_limited_add
[  301.129715][ T4651]
[  301.130014][ T4651] write to 0xffff88810ffc3450 of 8 bytes by task 4674 on cpu 0:
[ 301.130981][ T4651] __percpu_counter_limited_add (lib/percpu_counter.c:325) 
[ 301.131692][ T4651] shmem_inode_acct_blocks (mm/shmem.c:220) 
[ 301.132319][ T4651] shmem_get_folio_gfp+0x3a9/0x750 
[ 301.133054][ T4651] shmem_write_begin (mm/shmem.c:2135 mm/shmem.c:2692) 
[ 301.133690][ T4651] generic_perform_write (mm/filemap.c:3962) 
[ 301.134347][ T4651] shmem_file_write_iter (mm/shmem.c:2868) 
[ 301.134956][ T4651] do_iter_readv_writev (include/linux/fs.h:1956 fs/read_write.c:735) 
[ 301.135628][ T4651] do_iter_write (fs/read_write.c:860) 
[ 301.136178][ T4651] vfs_writev (fs/read_write.c:933) 
[ 301.136716][ T4651] __x64_sys_pwritev2 (fs/read_write.c:1030 fs/read_write.c:1089 fs/read_write.c:1080 fs/read_write.c:1080) 
[ 301.139719][ T4651] do_syscall_64 (arch/x86/entry/common.c:50 arch/x86/entry/common.c:80) 
[ 301.140316][ T4651] entry_SYSCALL_64_after_hwframe (arch/x86/entry/entry_64.S:120) 
[  301.141129][ T4651]
[  301.141465][ T4651] read to 0xffff88810ffc3450 of 8 bytes by task 4651 on cpu 1:
[ 301.142436][ T4651] __percpu_counter_limited_add (lib/percpu_counter.c:302 (discriminator 1)) 
[ 301.143222][ T4651] shmem_inode_acct_blocks (mm/shmem.c:220) 
[ 301.143931][ T4651] shmem_get_folio_gfp+0x3a9/0x750 
[ 301.144696][ T4651] shmem_write_begin (mm/shmem.c:2135 mm/shmem.c:2692) 
[ 301.145370][ T4651] generic_perform_write (mm/filemap.c:3962) 
[ 301.146112][ T4651] shmem_file_write_iter (mm/shmem.c:2868) 
[ 301.146697][ T4651] do_iter_readv_writev (include/linux/fs.h:1956 fs/read_write.c:735) 
[ 301.147330][ T4651] do_iter_write (fs/read_write.c:860) 
[ 301.147918][ T4651] vfs_writev (fs/read_write.c:933) 
[ 301.148480][ T4651] __x64_sys_pwritev2 (fs/read_write.c:1030 fs/read_write.c:1089 fs/read_write.c:1080 fs/read_write.c:1080) 
[ 301.149047][ T4651] do_syscall_64 (arch/x86/entry/common.c:50 arch/x86/entry/common.c:80) 
[ 301.149629][ T4651] entry_SYSCALL_64_after_hwframe (arch/x86/entry/entry_64.S:120) 
[  301.150358][ T4651]
[  301.150643][ T4651] value changed: 0x0000000000059e35 -> 0x0000000000059e56
[  301.151483][ T4651]
[  301.151778][ T4651] Reported by Kernel Concurrency Sanitizer on:
[  301.152559][ T4651] CPU: 1 PID: 4651 Comm: trinity-c7 Not tainted 6.6.0-rc4-00235-gbeb986862844 #1
[  301.153676][ T4651] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.16.2-debian-1.16.2-1 04/01/2014
[  301.154962][ T4651] ==================================================================

..

[  341.345671][ T4958] ==================================================================
[  341.346844][ T4958] BUG: KCSAN: data-race in __percpu_counter_limited_add / __percpu_counter_limited_add
[  341.348131][ T4958]
[  341.348468][ T4958] write to 0xffff88810ffc3450 of 8 bytes by task 4967 on cpu 0:
[ 341.349472][ T4958] __percpu_counter_limited_add (lib/percpu_counter.c:325) 
[ 341.350219][ T4958] shmem_inode_acct_blocks (mm/shmem.c:220) 
[ 341.350902][ T4958] shmem_get_folio_gfp+0x3a9/0x750 
[ 341.351630][ T4958] shmem_write_begin (mm/shmem.c:2135 mm/shmem.c:2692) 
[ 341.352270][ T4958] generic_perform_write (mm/filemap.c:3962) 
[ 341.352893][ T4958] shmem_file_write_iter (mm/shmem.c:2868) 
[ 341.353521][ T4958] do_iter_readv_writev (include/linux/fs.h:1956 fs/read_write.c:735) 
[ 341.354170][ T4958] do_iter_write (fs/read_write.c:860) 
[ 341.354738][ T4958] vfs_writev (fs/read_write.c:933) 
[ 341.355289][ T4958] __x64_sys_pwritev2 (fs/read_write.c:1030 fs/read_write.c:1089 fs/read_write.c:1080 fs/read_write.c:1080) 
[ 341.355926][ T4958] do_syscall_64 (arch/x86/entry/common.c:50 arch/x86/entry/common.c:80) 
[ 341.356511][ T4958] entry_SYSCALL_64_after_hwframe (arch/x86/entry/entry_64.S:120) 
[  341.357277][ T4958]
[  341.357592][ T4958] read to 0xffff88810ffc3450 of 8 bytes by task 4958 on cpu 1:
[ 341.358556][ T4958] __percpu_counter_limited_add (lib/percpu_counter.c:302 (discriminator 1)) 
[ 341.359312][ T4958] shmem_inode_acct_blocks (mm/shmem.c:220) 
[ 341.360021][ T4958] shmem_get_folio_gfp+0x3a9/0x750 
[ 341.360772][ T4958] shmem_write_begin (mm/shmem.c:2135 mm/shmem.c:2692) 
[ 341.361417][ T4958] generic_perform_write (mm/filemap.c:3962) 
[ 341.362106][ T4958] shmem_file_write_iter (mm/shmem.c:2868) 
[ 341.362751][ T4958] do_iter_readv_writev (include/linux/fs.h:1956 fs/read_write.c:735) 
[ 341.363443][ T4958] do_iter_write (fs/read_write.c:860) 
[ 341.364025][ T4958] vfs_writev (fs/read_write.c:933) 
[ 341.364585][ T4958] __x64_sys_pwritev2 (fs/read_write.c:1030 fs/read_write.c:1089 fs/read_write.c:1080 fs/read_write.c:1080) 
[ 341.365226][ T4958] do_syscall_64 (arch/x86/entry/common.c:50 arch/x86/entry/common.c:80) 
[ 341.365824][ T4958] entry_SYSCALL_64_after_hwframe (arch/x86/entry/entry_64.S:120) 
[  341.366587][ T4958]
[  341.366921][ T4958] value changed: 0x000000000008c0e8 -> 0x000000000008c109
[  341.367883][ T4958]
[  341.368191][ T4958] Reported by Kernel Concurrency Sanitizer on:
[  341.369014][ T4958] CPU: 1 PID: 4958 Comm: trinity-c5 Not tainted 6.6.0-rc4-00235-gbeb986862844 #1
[  341.370255][ T4958] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.16.2-debian-1.16.2-1 04/01/2014
[  341.371512][ T4958] ==================================================================


The kernel config and materials to reproduce are available at:
https://download.01.org/0day-ci/archive/20240531/202405311100.d46f2cc1-lkp@intel.com


-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki