Received-SPF: pass (google.com: domain of linux-kernel+bounces-196333-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <77c91b46-cf2f-4e11-9fdb-c867c87530f4@amd.com>
Date: Fri, 31 May 2024 11:41:14 +0530
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] iommu/amd: Fix panic accessing amd_iommu_enable_faulting
To: Dimitri Sivanich <sivanich@hpe.com>, Yi Zhang <yi.zhang@redhat.com>,
 "Tian, Kevin" <kevin.tian@intel.com>, Baolu Lu <baolu.lu@linux.intel.com>,
 Joerg Roedel <joro@8bytes.org>,
 Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>,
 Will Deacon <will@kernel.org>, Robin Murphy <robin.murphy@arm.com>,
 David Wang <00107082@163.com>,
 Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>, iommu@lists.linux.dev
Cc: linux-kernel@vger.kernel.org, Steve Wahl <steve.wahl@hpe.com>,
 Russ Anderson <russ.anderson@hpe.com>
References: <ZljHE/R4KLzGU6vx@hpe.com>
Content-Language: en-US
From: Vasant Hegde <vasant.hegde@amd.com>
In-Reply-To: <ZljHE/R4KLzGU6vx@hpe.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?eU55MVFCenYrbU9GelVwaUFRUWNjVHZ2eFRiTWp0aVpMYnorM1NyVzRGeFRF?=
 =?utf-8?B?QXlHTFhBRkY2RUhxcnQrbVNiSzlub1VvYnFlYVVXZHI0dTZiVW5Sa2cxOFBa?=
 =?utf-8?B?aG5EWUtxVFBabWE4OEMzbWpMclN6eDBqQmhOdmU5MjNCSmppTXVNK1N2dWwv?=
 =?utf-8?B?TEI5YnlBQU14VUwwc2VyK2FvZkNlNG9PRTdSTWlXZ2FXa1NPU3ZxdDUyb0xD?=
 =?utf-8?B?Sm8raGE5Q3VYTU1Oa3VuSWN4RkY0Qkx3eXI2R0loL0h4Szh4Y0VDZDEyMHFD?=
 =?utf-8?B?Zkx0VXVQSTIyRVRCMDRMSGRjNVJBa3U4OUFLV1I5cjFva29XNWVHRlhDZ3Nm?=
 =?utf-8?B?enlvYVFDTzk3RGlaeWpNK1RXZUhuYWR6RHcxczFnVEtYSzdVbnVuSFNDSFlh?=
 =?utf-8?B?RnBHaE5vLzBCaTVtd0liYkEvVDZUaUlRcXVMK2RTMVRIWjBVZjBJUXM3SUY0?=
 =?utf-8?B?RC9rVFdab1FxVEtEMGdyTC92dG41UGVZc1Fta083dkQxSU41K3FDRzdTK2FD?=
 =?utf-8?B?OVE0Lzkva2Q1a044cEhBUTVoU3ZPZlFtdTUrSnhjM3haY09VVEtHcGZRaEt5?=
 =?utf-8?B?UThsK1krOHl1UGxwV3Q3bXV5S2NvWDgwMDVXL3gvVnB5WG9OZmowOGN2R1pm?=
 =?utf-8?B?K1BEWFNYakFMRkRaWWNXeFZaM09YUm1ZdjZoM3FQaUM2dzgyeG5rMStOU1F2?=
 =?utf-8?B?UEpPZ0NPRzJjTnc4QWtoWlovWlBXWE40SmplU29Obk9sczI1QndZU0JBSmNy?=
 =?utf-8?B?ZCtLZjUveHJoSmZLS1NGZUN1ckdsd3R0NU84b3FROC9Ea09UdjhPbkRsVngv?=
 =?utf-8?B?aG9IN1FrbVpkV0lIRTZvM3RQSG94L2x3S0pNMUl6R3dmdDFOOHZLOEhFczIw?=
 =?utf-8?B?MnFyRHlTZDRRaVV4ZmhNNyszekZyTW9Kc3FRYmpYbDltdEtldWlJaVVVK2pa?=
 =?utf-8?B?Sm11Tmxlam41UTJnYlhGR2lpYitmb1ZPL0V0T2NwTFlSekVZaEdwUitiZ3lY?=
 =?utf-8?B?UXU0TjU4YmlPdklnM245TnFMOXlNWlc1ZmFONHRSQVpjQlJiRitpT2VsKzdB?=
 =?utf-8?B?eE80dHEyVVd6RDRDNW03cSt3MWJhZkhiODIzMFFmRHBGcjR3a2E1Qkc5czZm?=
 =?utf-8?B?ZnAyaFJBbWhoUDFKUktBRmxSRUE2OXpYY3lWdEwvcWErUG5yellCUnZiWjBn?=
 =?utf-8?B?VzdKbVpHN1JVcEZISmFXdWErT2JJYm9XSXZMc21RS2Uvc1Y3ais5ZFZwTmlk?=
 =?utf-8?B?SVhyU0t5YjZCM3BZaGJTNWF6RVlLSTdKb1lkSTMyYTdPMVJEU2loTmFrWll2?=
 =?utf-8?B?YkR0a0hYdVFaaE9iUVZzUzJxNUFXd1ZqN0IvbCtiRlRzUG04amtmS0hGTjZI?=
 =?utf-8?B?cDhhME5BRFdmZzh3YWg2c2tFVEhsaWFhZzFxdVNJWWRPTGs3SThLNXRJdzZp?=
 =?utf-8?B?Wk91b2dnUmhJTmNlVDZlQ0xUaW1hbFZpTXp2WFRJTTBYcFZiUmJ0RzljbytQ?=
 =?utf-8?B?VDB2MEkvS2hHaHBQQXZjSTkwNFJXOSszaDRSRi9kVXArcGplN3drNTBnQk9U?=
 =?utf-8?B?S2VWTDBYK0h5NTFXeWRxNUVsY0RuQmlDa245UlhqMTlwallLWkFBZ200Nm1q?=
 =?utf-8?B?QlpLTHoydGF5Zko3Mmlpc3FvTjJNN3lGVUlSVVBDYXJmUmg3TzFwUFp4am85?=
 =?utf-8?B?VENQRDlraXlpN2hDSjRwcUJXQXFwOTdMckU4M0p3YXVGVWFIdk1mVTNyWmth?=
 =?utf-8?B?V2pzM2N6SG1sSzcxRkJ4a2tUR3B2VG5kUFNqTndTOVBhNmhuVExkUFFwZlJs?=
 =?utf-8?B?ZGtodE9kdXNkZDBtWGMyZmU3VFRKdDJwSGJhbkxKZE1MVityVUhGK0NkWTR4?=
 =?utf-8?B?aC9Xa21sY1FqcDc0UGxmajFtT0ozUzVYcHRZa0p0aGlSVHd0V1MzOUlKTTRp?=
 =?utf-8?B?MTd5UWZ3dTNFY285TUk4K1NLOHA5VDZLT2pFdTh6TFZ6WHB3L3U0WHRBZUk0?=
 =?utf-8?B?QkhOa3AxT0NZcUh2bjl4QWRMZzlKbzQvYnc5OXY0ZzFBWUxKdFUvaVlJR2F2?=
 =?utf-8?B?V0FxYXoxMURza2oxYkhDTUpibm9oK0pGTWxDbU1qbTNYUk9OcUpPOVlCWGNC?=
 =?utf-8?Q?3fooVzYg/81k4ZwWoW5QZV/YD?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e9659f93-1205-45f1-fe83-08dc8138803e
X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB6048.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 May 2024 06:11:25.2756
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 9h1dDXmPHgrb4/PjffXPSgwa3qV2X22CKMg2vQ3emXdyw7KXtz8fuYWukvtjB5O7FrgwTc+A5RIf86xJhU/VVA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7196


On 5/31/2024 12:06 AM, Dimitri Sivanich wrote:
> This fixes a bug introduced by commit d74169ceb0d2 ("iommu/vt-d: Allocate
> DMAR fault interrupts locally").  The panic happens when
> amd_iommu_enable_faulting is called from CPUHP_AP_ONLINE_DYN context.
> 
> Fixes: d74169ceb0d2 ("iommu/vt-d: Allocate DMAR fault interrupts locally")
> Signed-off-by: Dimitri Sivanich <sivanich@hpe.com>
> Tested-by: Yi Zhang <yi.zhang@redhat.com>

Reviewed-by: Vasant Hegde <vasant.hegde@amd.com>

-Vasant

> ---
>  drivers/iommu/amd/init.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iommu/amd/init.c b/drivers/iommu/amd/init.c
> index a18e74878f68..b02b959d12af 100644
> --- a/drivers/iommu/amd/init.c
> +++ b/drivers/iommu/amd/init.c
> @@ -3353,7 +3353,7 @@ int amd_iommu_reenable(int mode)
>  	return 0;
>  }
>  
> -int __init amd_iommu_enable_faulting(unsigned int cpu)
> +int amd_iommu_enable_faulting(unsigned int cpu)
>  {
>  	/* We enable MSI later when PCI is initialized */
>  	return 0;