Received-SPF: pass (google.com: domain of linux-kernel+bounces-196339-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Fri, 31 May 2024 08:18:02 +0200
From: Frank Wunderlich <frank-w@public-files.de>
To: =?UTF-8?B?QXLEsW7DpyDDnE5BTA==?= <arinc.unal@arinc9.com>,
 Frank Wunderlich <linux@fw-web.de>, Rob Herring <robh@kernel.org>,
 Krzysztof Kozlowski <krzk+dt@kernel.org>, Conor Dooley <conor+dt@kernel.org>,
 Matthias Brugger <matthias.bgg@gmail.com>,
 AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
CC: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
 linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org,
 Daniel Golle <daniel@makrotopia.org>
Subject: Re: [PATCH] arm64: dts: mt7622: fix switch probe on bananapi-r64
User-Agent: K-9 Mail for Android
In-Reply-To: <aaaeb4b2-e57e-4d7b-b598-a664cc05b0cf@arinc9.com>
References: <20240516204847.171029-1-linux@fw-web.de> <a29dd7d1-40a8-4c88-99aa-651a3305b640@arinc9.com> <5AEE5668-0C8E-4EE4-A398-66CB99DF5650@public-files.de> <aaaeb4b2-e57e-4d7b-b598-a664cc05b0cf@arinc9.com>
Message-ID: <81944186-AFAA-4C8F-8E55-1AF4CBD97573@public-files.de>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:yhh0q80s+ZY=;uoRfJI1nTo+W2V/J0/+kfPEodHJ
 0HnAeu1kDoJAeEkF9EN/6l34Fv0cNuVmKpaGwy3gqAURQ3UrvRHG9lZZgXlSNJ5gtyjLYpZ2U
 fKaet3IMGK1IzFpm0VMUynNTs49+cTorXPtVWmCcjVFsDnJsrvKQ558DriXid/nWBhKmP39WT
 C2Nxq7ucDj3gZ+eCgkeUQlOSAuYtUsFn09aDoL656kLziS7X6Dx/uaN7CvER7/JArgPh7e4GH
 xi5Jhv4/M9xdHgGtOqbaZHYvJwUBxsNUT4NnTDCZM6eJ4R1Amh+m9grcSUR6ewVhuQt6DdSBT
 tIeR5X/ynHYN1FKqex2QUOceJem7EkZ2yb2s24s0b8NMIqM4mftEkmsfTtlNpameRONtHiI/Z
 2y7r3LJktFgbB0LhY7H7al3zjoabme9WvEY9dcLfMT20fmZGv2QygGHHRPZx6yXwGHaoikqZ1
 AoAN0x3CwrR+iyQjGONSc9a+5iJnSYnyHYZq8LxiZcNyfATahtMURQLfVCB+pdILwwBjQGE0b
 JkCq7KFq/crrq4GmD+tZHZx4IOZ35+UhPlj+GYxaTFiJUaDCmeFNOw+4tqbSHOO2ioV6SLKto
 xlKJrPVkSDDu4R+esHAFkAndBPuzJT1h0l0CWq9JtL0y+i9rvCcYy7XSfsPKUdN7yB5IIv4SD
 mf1Ae+7BGabWet0qby5NFprrUWgLT2VIaVJ26COp/tG607cfKjul0fN5epgYKcLUQrqAUpxEq
 Sn2eWBq0LUduyjg8mKDAMr+70NSXkc2ouo9ckdfU7tqIYKh8FbWh+5Iv5CvvuC6I9sAaK0gMq
 eGEElmNbrDDe1m/EfYLukqSkSq9y+sfHcJwPwIgrdtmVA=

Am 31=2E Mai 2024 08:12:06 MESZ schrieb "Ar=C4=B1n=C3=A7 =C3=9CNAL" <arinc=
=2Eunal@arinc9=2Ecom>:
>On 17/05/2024 09=2E27, Frank Wunderlich wrote:
>> Am 17=2E Mai 2024 04:17:47 MESZ schrieb "Ar=C4=B1n=C3=A7 =C3=9CNAL" <ar=
inc=2Eunal@arinc9=2Ecom>:
>>> On 16/05/2024 23:48, Frank Wunderlich wrote:
>>>> From: Frank Wunderlich <frank-w@public-files=2Ede>
>>>>=20
>>>> After commit 868ff5f4944a
>>>> ("net: dsa: mt7530-mdio: read PHY address of switch from device tree"=
)
>>>> the mt7531 switch on Bananapi-R64 was not detected=2E
>>>>=20
>>>> mt7530-mdio mdio-bus:00: reset timeout
>>>> mt7530-mdio mdio-bus:00: probe with driver mt7530-mdio failed with er=
ror -110
>>>>=20
>>>> Fix this by adding phy address in devicetree=2E
>>>>=20
>>>> Signed-off-by: Frank Wunderlich <frank-w@public-files=2Ede>
>>>=20
>>> I don't like the mention of the Linux kernel driver on the patch log=
=2E What
>>> you're fixing is the incorrect description of the switch's PHY address=
 on
>>> the DTS file=2E Whether or not any driver from any project is actually
>>> reading it from the DTS file is irrelevant to this patch=2E That said,=
 I
>>> already have a patch series I've been meaning to send the next version=
 of
>>> that already addresses this=2E Please wait for that=2E
>>>=20
>>> Ar=C4=B1n=C3=A7
>>=20
>> Hi arinc,
>>=20
>>  From my PoV it is a regression in next/6=2E10 because the driver chang=
e was merged (without "broadcast" fallback) and the dts patch [1] is not=2E
>
>What is a broadcast fallback? 0x1f is just another PHY address=2E

Afaik 0x0 is some kind of broadcast address if real phy address is not kno=
wn=2E The driver change seems not allow this 0x0 adress and forces devicetr=
ee to have the real address=2E

Thats what i mean with broadcast fallback=2E Maybe the naming is wrong=2E

>Ar=C4=B1n=C3=A7

@thorsten i have not tested again,but i have not seen any further fix for =
it=2E
regards Frank