Received-SPF: pass (google.com: domain of linux-kernel+bounces-196345-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <9f7737a7-3e1d-4d6a-abf9-88d855fd0c9c@siemens.com>
Date: Fri, 31 May 2024 08:22:49 +0200
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 0/3] Enable PTP timestamping/PPS for AM65x SR1.0 devices
To: Diogo Ivo <diogo.ivo@siemens.com>, MD Danish Anwar <danishanwar@ti.com>,
 Roger Quadros <rogerq@kernel.org>, "David S. Miller" <davem@davemloft.net>,
 Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>,
 Paolo Abeni <pabeni@redhat.com>, Richard Cochran <richardcochran@gmail.com>,
 Nishanth Menon <nm@ti.com>, Vignesh Raghavendra <vigneshr@ti.com>,
 Tero Kristo <kristo@kernel.org>, Rob Herring <robh@kernel.org>,
 Krzysztof Kozlowski <krzk+dt@kernel.org>, Conor Dooley
 <conor+dt@kernel.org>, Suman Anna <s-anna@ti.com>
Cc: linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org,
 linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
References: <20240529-iep-v1-0-7273c07592d3@siemens.com>
From: Jan Kiszka <jan.kiszka@siemens.com>
Content-Language: en-US
In-Reply-To: <20240529-iep-v1-0-7273c07592d3@siemens.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?eEN4bUR1YzFHcFEyazJGZ0k3c2VpMGo1N29ucjhvVm1uc3orcXJkNUoxSjMz?=
 =?utf-8?B?TVVrSng2VEV5RlBaL3VSRzd0cDF5cUFwMVhweEdJUUJTQ3B4VkNuVnQwajJv?=
 =?utf-8?B?NERrWnRBOE5DTkdqRUoxa3dKU3QrTUlnNzhXMzkyOWFPNkxIMVRkVk1kaE1n?=
 =?utf-8?B?TXBJa1JuT2RsQmtTcitRN1Z5YjdHeFNGMWt0aHJ4RWxRbDhDcHlDVEtadUNT?=
 =?utf-8?B?VWhjeEMrRndydGphSEdybEdJVlVFNC90dmlackJucFpqdCs2cWprUDJmNlR2?=
 =?utf-8?B?N2NCaXZ4elBuYWh2TFhJd2xuVTUyZjgyRUd5Z1JQNjlwd3ZXT1Y2YUJudmJL?=
 =?utf-8?B?VFBOOEh0NHFpK3UwbEpNeDlvU052NGhmZ1U1a3lXeDBicy9MZERBV3VPaDFX?=
 =?utf-8?B?YTZhMUhDTVdBOG1KQjNBNVVpMVgrWE9xOGZrdzdQL3hmQXM0cVN2ZFplTWNp?=
 =?utf-8?B?c21Ka1Z2ZjZELzBPRUtqbHAwbUxzRTluTWErV0lsU0pXZWljYWJpVjVXTGIx?=
 =?utf-8?B?RTZHY2Z2U3ovYUtRYXVzbXZVK293QjVJU3NONWhiTUdhd0hDSGptYW1TZmVh?=
 =?utf-8?B?bitHNmk4YnJrUWdZTGlrMC9CTWNKVFlvTXRIQlhya0YzVkFhYUUzanRuaXUy?=
 =?utf-8?B?SERRWUFTNnFqZHRHTTEwM3oyY0NPbnVyYTFBMGttNWNFdHJIbW5JaW5iZ1Qx?=
 =?utf-8?B?M25nTHFMMVgvQnVDSUE4ODcxMzdVNUw3NnNENjFSSnYzanhwVDRGN0ErVjdi?=
 =?utf-8?B?NFJMNGxyWnVMSTEwcHQ0MWtGcGI4RnRSUWRVb3dVbnZnWmw2bnBhd29wNGIr?=
 =?utf-8?B?SVhmamZlMnd5dnl6TG9QdG9GNGtRSFllZnRMYk9OQStpMnNFMTk3U3NXTzM1?=
 =?utf-8?B?dUxDTVFJZzRsdDdRRnpPWUx0SlVoRklVY1dBL3FuNnNSaERCOW1jZ3BUTkYx?=
 =?utf-8?B?UzJ0ZmduZ0V6ekJWWmM1ZTY4TGJrUnlmWXhLeG5lWSt6aUZQWHY1OC9MaWNx?=
 =?utf-8?B?a1JXa3pPcy9uNzg1YU56d2xhSG04MFRHbWkxazVRQ1NhblI4aEJkNmhwaUFO?=
 =?utf-8?B?NWRLb1lvaW9ITGNwU3FJdmF3MUpCM0lkNXU3WW14c3NrazlMek1KOEhUY2g3?=
 =?utf-8?B?TTZVdDBNcmpGVFZqeVY5QjlaWWV4OVp0RUg0bzZHSW9kWWJ5SjY5MmlBNEN5?=
 =?utf-8?B?RVBWL3NNanlJdUtsaW1uQUYva1puaERMZnplQ1hNSXBXc2NKNWx1SGpaWHc4?=
 =?utf-8?B?YUFKS1dqeVdSZTNOTVZ3S3FKeS9YNWdLSmFiV3RaZVd6c2RYbE9HQ0EwMHNr?=
 =?utf-8?B?NDJMZHl0NGI2VHJLWnhRMndORVYxRm8raXFuZ1hxc01QUmtYaGVyekV1RU1x?=
 =?utf-8?B?TElpeGlEMithRTl6RldQb2NkcEZHM0hJTENsRHZFNnNBRUR2cDNncnl2dnhH?=
 =?utf-8?B?RWZaT1N3REZ5RDlSMXNXQ2NBdytwaUUyaEhrWGtGaTAxMEZaeTc3NFIyeFVi?=
 =?utf-8?B?QlR3ZGovcW1GSEVPSDJuejhmMGwyRkR0UTNWUE9vdVhQeEpER0tQWHh3SWtW?=
 =?utf-8?B?VXEydGVLVW5HZkNqMk1UV1FiTnRKQmhqYU1lc3NLUTRGVFV1bjFRdmZsa3lG?=
 =?utf-8?B?SmtMWDBheXFJSzcvMVBXRUpzSDVhdzl2NXpua1EzWmpGRDJ5SXhrbTZOb1Ro?=
 =?utf-8?B?QXY5aFRWTC9iTGYyVXlBZU81b1pDbFRpVm9ObUM2NTk2UXpzTVliK0YxMVJH?=
 =?utf-8?B?TFFMZjgxbnY3U3ZtUGp3cVIxL3NJUW5XcjBBZkVraGxUWG9xcjUrVTJZMU5O?=
 =?utf-8?B?bDR4eWZ2ZTJtQTJSSE5Sc05nZkU4WkxSaW1ic2lQbis2djFYNEczTUV3V3Jt?=
 =?utf-8?B?R3YxeXpadkgxSTV1bDZqdEM3VmdCYlhFdHg5cThFMU1mcFVBSjZhV01OOVl6?=
 =?utf-8?B?RFhySURGOThhZVpYQVdSdjNYUXN2M1o5blBQWjZBZGZlZDl1U2E1SFYxL0hy?=
 =?utf-8?B?QkhIcWlwRDI3c1ZTclYwQTcwMS9ySjJQRlNzRElKbGEzRWFYazJ2bzJGdm9K?=
 =?utf-8?B?dktncVFxalB2bFdxNkZxcC93Z1lMeEYvU0Vzeis2aDdpK3UvY005cWFITEU3?=
 =?utf-8?Q?OntCjIDYtCn7YZl0EbzfsALcR?=
X-OriginatorOrg: siemens.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8340e9da-44da-41e2-45aa-08dc813a19fb
X-MS-Exchange-CrossTenant-AuthSource: AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 May 2024 06:22:52.4918
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: AN7vL9uVDXTFSl2eYaOnVg2QJbglhNd6qtV+/jZef5OR/j+0tg4xZkVH2bCwZ8sBrowNqYU2iN4pA0o9n+oJZQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR10MB7854

On 29.05.24 18:05, Diogo Ivo wrote:
> This patch series enables support for PTP in AM65x SR1.0 devices.
> 
> This feature relies heavily on the Industrial Ethernet Peripheral
> (IEP) hardware module, which implements a hardware counter through
> which time is kept. This hardware block is the basis for exposing
> a PTP hardware clock to userspace and for issuing timestamps for
> incoming/outgoing packets, allowing for time synchronization.
> 
> The IEP also has compare registers that fire an interrupt when the
> counter reaches the value stored in a compare register. This feature
> allows us to support PPS events in the kernel.
> 
> The changes are separated into three patches:
>  - PATCH 01/03: Register SR1.0 devices with the IEP infrastructure to
> 		expose a PHC clock to userspace, allowing time to be
> 		adjusted using standard PTP tools. The code for issuing/
> 		collecting packet timestamps is already present in the
> 		current state of the driver, so only this needs to be
> 		done.
>  - PATCH 02/03: Add support for IEP compare event/interrupt handling
> 		to enable PPS events.
>  - PATCH 03/03: Add the interrupts to the IOT2050 device tree.
> 
> Currently every compare event generates two interrupts, the first
> corresponding to the actual event and the second being a spurious
> but otherwise harmless interrupt. The root cause of this has been
> identified and has been solved in the platform's SDK. A forward port
> of the SDK's patches also fixes the problem in upstream but is not
> included here since it's upstreaming is out of the scope of this
> series. If someone from TI would be willing to chime in and help
> get the interrupt changes upstream that would be great!
> 

IIRC, we are talking about this downstream patch:

https://git.ti.com/cgit/ti-linux-kernel/ti-linux-kernel/commit/?h=ti-linux-5.10.y&id=bbe0ff82f922d368cb7e00c5905f6d4a51635c47

Jan

> Signed-off-by: Diogo Ivo <diogo.ivo@siemens.com>
> ---
> Diogo Ivo (3):
>       net: ti: icssg-prueth: Enable PTP timestamping support for SR1.0 devices
>       net: ti: icss-iep: Enable compare events
>       arm64: dts: ti: iot2050: Add IEP interrupts for SR1.0 devices
> 
>  .../boot/dts/ti/k3-am65-iot2050-common-pg1.dtsi    | 12 ++++
>  drivers/net/ethernet/ti/icssg/icss_iep.c           | 71 ++++++++++++++++++++++
>  drivers/net/ethernet/ti/icssg/icssg_prueth_sr1.c   | 49 ++++++++++++++-
>  3 files changed, 131 insertions(+), 1 deletion(-)
> ---
> base-commit: 2f0e3f6a6824dfda2759225326d9c69203c06bc8
> change-id: 20240529-iep-8bb4a3cb9068
> 
> Best regards,

-- 
Siemens AG, Technology
Linux Expert Center