Received-SPF: pass (google.com: domain of linux-kernel+bounces-196351-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Fri, 31 May 2024 08:39:47 +0200
From: Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com>
To: Reinette Chatre <reinette.chatre@intel.com>
CC: <fenghua.yu@intel.com>, <shuah@kernel.org>,
	<linux-kselftest@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<ilpo.jarvinen@linux.intel.com>, <tony.luck@intel.com>
Subject: Re: [PATCH v2 2/2] selftests/resctrl: Adjust SNC support messages
Message-ID: <foz3qzdremrnxzfwltucbyugkiieyoxg4vhml3csu2yodnfld4@bxvyu44msaxc>
References: <cover.1715769576.git.maciej.wieczor-retman@intel.com>
 <16764746e8f9f42cbd45d61210764a9b67085cbf.1715769576.git.maciej.wieczor-retman@intel.com>
 <d8396d97-5000-4ffb-aaba-e71de5d6d909@intel.com>
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <d8396d97-5000-4ffb-aaba-e71de5d6d909@intel.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?Q0a4WsRMiwqB3PVAbglWoRaa7fOTgBhbYYHMcRixocV9l/qYrUV8EX6TzL?=
 =?iso-8859-1?Q?MVbq8JpKox593VkWA/oysV+AaE2VbD7tWow7taejHPuOF6uhiI1XctkNHE?=
 =?iso-8859-1?Q?JNLeLIezi5TJ9QV452mI4C1VPHurT1desmWexQKsXK5wMHjw5z2sbBy64/?=
 =?iso-8859-1?Q?F4ug2gAoMc9SduXtica8s/Cm32Ho0EkBWy3U1x2mTalTzuLkHhDtLfBorS?=
 =?iso-8859-1?Q?9g/Hzw3Nw9x+9t4OaKxbXNFOEJ4Xbb/YSp5j+b+Bz6q+IN/pwl4ZU7qGJD?=
 =?iso-8859-1?Q?A80hCA1mx6P22kEywmGuPiOqFgYwRLy2fv2wMwFcNGDptrD0hUAvVucRdd?=
 =?iso-8859-1?Q?wiVyzABqi4N8im6IKN+Awg9S5lhCFhn/XX9dKHU6aDZClI5JXZI9MLOLZA?=
 =?iso-8859-1?Q?cjfIS/rp1uQuMGhz2QDYUXfi1XUPPd+Q0J3tvCzy72iD4x2o93umyJQ0jC?=
 =?iso-8859-1?Q?aQoAX4LWzn9BvecyVhPOi2V+pt4RRAw8kM9Lk43QnM25DGEjxHyD0EcX5S?=
 =?iso-8859-1?Q?sSTj4mNee5jmh79LjZ40AXI0kssgQRV4zjVtikUQxNK1dJPdntG4im4NgI?=
 =?iso-8859-1?Q?Fb03fszMNK/b4R56AMVZkh5DpPgiaVse1tE2pRTgNJYdS0JNtGVQZrSg+/?=
 =?iso-8859-1?Q?5A2AGm8xLfbGbRj4CR1ROEcoPYo7OKpzSMTareydRJK08ve0ZjWnYGU9Kk?=
 =?iso-8859-1?Q?6n7iL8LMRgHSiNlSXTBJn1murLL7dALwh9kJkzbsgV+jm32ivVc5VTd/IW?=
 =?iso-8859-1?Q?+SstrXbgIQn4fWVrpgJF1c8OZE5VnTwuo6N51j9gz14dj56mYoxwzCjDY6?=
 =?iso-8859-1?Q?pkt4XqDoSsydUlYVwwqhQLt4029BlCeYePnrWIPkOIHhu3QwrpCYh7XJi9?=
 =?iso-8859-1?Q?TET6NPDav5cZpPSSI/xDcqFqWzf9Pjt0gn6LpZLZlJxqZbMasp5u8udXEK?=
 =?iso-8859-1?Q?c3JKCSCck57n1ZUC6AvzjIYYqGQXKEuiEs5KfnpObnpB88IOrktNgs/YEc?=
 =?iso-8859-1?Q?PSXbKkaK1Xlh/DpbiJ+eRCTtl1SFWLpF5Vpn1KcmHc1Kpn5UAnLC3un1Zw?=
 =?iso-8859-1?Q?DF9PszHQvkxlWu0/6R1N9C7I4pUe61AzaeUlZWFVOfxr6PiILzXqBGnhXb?=
 =?iso-8859-1?Q?MSwZsZyh37yhDXMSI44SwQKoHHDkeJvJEZBHb8XQ46NGzeA3qcQDBeRB64?=
 =?iso-8859-1?Q?bUuHYw4x5VVU09+fARpQmolDxy1e8oMzDtfp4tzhOI2jQUbpk6ZBceQQ6V?=
 =?iso-8859-1?Q?KVEFnbUpSgZALZgN+CDx/2FdUhKedIZy4p7KL/d5Yx4CyR8sWnda2EWgp+?=
 =?iso-8859-1?Q?QGLYPb82KrXWEmrJXixqvFb65bSHFYGJwLLhgz8LXVSkvvXnJJYlwVCaLP?=
 =?iso-8859-1?Q?2hvJHdt/2+wT+PpWqjORjkvF9rnuZoJvV2ODu4Hvy2qOCOIoV5G9wcia3A?=
 =?iso-8859-1?Q?T+LhsNY7CNoHiqNljdGRRS90Gc8/6nCeHJzx3EIp7fJKX9swXsyO1n6Bk1?=
 =?iso-8859-1?Q?AcWTSvvgW7+t4bgYljG8sOmvP0bGLLRFSk4HJ9O4AvIqPJYgns9CJYlBnq?=
 =?iso-8859-1?Q?l9i5V4oiLepCeLTAATGhr71d8HD4mpnNoq5Al9ZKfXbMVoYQTlfbLET/5h?=
 =?iso-8859-1?Q?qpwXK38xx43uwK8xH7IUx97kLcGramTn2MLBQIVPrmyLw1X10YW9xGr8J9?=
 =?iso-8859-1?Q?7zE5SnNr4Qlv4RlXND0=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: f9b83dbe-5581-4990-e37c-08dc813c80a3
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6231.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 May 2024 06:40:03.7165
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1XqMerG50Kl04PoCFwQOrpxOJFU7L0gaCDsnGSWj+KNHb3akafZxZe+ig22XZJMznOkpb7HGFJqIGoNHTbrC4frAwI0PP64GfqK+g2IZhPY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR11MB6254
X-OriginatorOrg: intel.com

Hello!

On 2024-05-30 at 16:07:34 -0700, Reinette Chatre wrote:
>Hi Maciej,
>
>On 5/15/24 4:18 AM, Maciej Wieczor-Retman wrote:
>> Resctrl selftest prints a message on test failure that Sub-Numa
>> Clustering (SNC) could be enabled and points the user to check theirs BIOS
>> settings. No actual check is performed before printing that message so
>> it is not very accurate in pinpointing a problem.
>> 
>> Figuring out if SNC is enabled is only one part of the problem, the
>> other being whether the kernel supports it. As there is no easy
>> interface that simply states SNC support in the kernel one can find that
>> information by comparing L3 cache sizes from different sources. Cache
>> size reported by /sys/devices/system/node/node0/cpu0/cache/index3/size
>> will always show the full cache size even if it's split by enabled SNC.
>> On the other hand /sys/fs/resctrl/size has information about L3 size,
>> that with kernel support is adjusted for enabled SNC.
>> 
>> Add a function to find a cache size from /sys/fs/resctrl/size since
>> finding that information from the other source is already implemented.
>> 
>> Add a function that compares the two cache sizes and use it to make the
>> SNC support message more meaningful.
>
>Please note that the new version of SNC kernel support ([1]) that this
>series is based on no longer adjusts the cache size. Detecting kernel support
>for SNC (if the new solution is accepted) can be done with the test for the
>existence of the files Tony mentioned in [2].

Thank you for your comments on both patches, I don't know how I missed this
fact. I'll revise my patches accordingly.

>
>> 
>> Add the SNC support message just after MBA's check_results() since MBA
>> shares code with MBM and also can suffer from enabled SNC if there is no
>> support in the kernel.
>> 
>> Signed-off-by: Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com>
>> ---
>
>Reinette
>
>[1] https://lore.kernel.org/all/20240503203325.21512-1-tony.luck@intel.com/
>[2] https://lore.kernel.org/lkml/SJ1PR11MB6083320F30DBCBB59574F0BDFCEC2@SJ1PR11MB6083.namprd11.prod.outlook.com/
>

-- 
Kind regards
Maciej Wiecz?r-Retman