Received-SPF: pass (google.com: domain of linux-kernel+bounces-196390-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: Nas Chung <nas.chung@chipsnmedia.com>
To: Hans Verkuil <hverkuil@xs4all.nl>, "mchehab@kernel.org"
	<mchehab@kernel.org>, "linux-media@vger.kernel.org"
	<linux-media@vger.kernel.org>, "sebastian.fricke@collabora.com"
	<sebastian.fricke@collabora.com>, "m.tretter@pengutronix.de"
	<m.tretter@pengutronix.de>
CC: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2] media: uapi: v4l: Change V4L2_TYPE_IS_CAPTURE
 condition
Thread-Topic: [PATCH v2] media: uapi: v4l: Change V4L2_TYPE_IS_CAPTURE
 condition
Thread-Index: AQHasKNiVaRy5Vo9MECtK40uBvrWg7Gvl+2AgAFTcaA=
Date: Fri, 31 May 2024 07:03:59 +0000
Message-ID:
 <SL2P216MB1246D6779BDDA2C03333D549FBFC2@SL2P216MB1246.KORP216.PROD.OUTLOOK.COM>
References: <20240528020425.4994-1-nas.chung@chipsnmedia.com>
 <a962e94f-a669-40e1-8b28-9ef077cf69be@xs4all.nl>
In-Reply-To: <a962e94f-a669-40e1-8b28-9ef077cf69be@xs4all.nl>
Accept-Language: ko-KR, en-US
Content-Language: ko-KR
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?LkAv/tDPxOTlXlwahPqMGCx6m7xx1162DWCvi/1zM/huasl7PY/aPJAOK+QQ?=
 =?us-ascii?Q?8NkDEbVZYwjX+R4NTWCy01C3C92E+lN2E5SQA5NawEQGxPYGv4LothlrXjRv?=
 =?us-ascii?Q?b4jZo58m47laHAT0oU+pUI1W1a9xbI3/Ze4vlSk4Y7Ov5VirIAdk/4N1VKyy?=
 =?us-ascii?Q?pF+7AMNGtJz/bu5ka2JavRjacP+1/lrHBFsYC5gF4E2eeJc1ONg42DvhqSUH?=
 =?us-ascii?Q?LUTH4fNCm6YGwhCPTEKZ+7pKQeY6WkEfonSayK/6wMiyklJrHgaNUvcubO9H?=
 =?us-ascii?Q?AmHEt0wvd9cDJXKbsjMr3zBCQ6yv2rEmI1j/qreE9dfqv7I3Nrohqsh9N/5E?=
 =?us-ascii?Q?gdTkuCYdVeLNc4GpcZ0MjdrSBuu+6QpJpDAlQZhvtjJlERs4ue79PUb+vcpK?=
 =?us-ascii?Q?KnHJfHQX06H94K+8MYjbG9h1x65CRKE4FzKx2fJ6Pa0rDFE9kxt+x/gYpvq3?=
 =?us-ascii?Q?/bvY79I1wKh8tKCCYf9vsMma70TQPatg4IbevX/aFwriiUjCjSqfAKPRKsHR?=
 =?us-ascii?Q?ou5ymUdbqUETwv8NYJugWWvNneBdUpoMycp9NQLZ4JHFKcNp6bGyMBcT1mog?=
 =?us-ascii?Q?FiYfslsFjIQgSrFWuM3wNa28zwY6NmJ9RJ9oMJYKAZHjvEsW1farcbAiGtSv?=
 =?us-ascii?Q?ubIFXsf7euYUQ8Hsax1KNGFTf2SIxAjs+N0wdF5e75ClPqLz51u2c7WX5IUD?=
 =?us-ascii?Q?L4BztgevYt67l9nsxxWYh3xpqgQrrXXpuSW8WhWWHaA2gneXzo7OAF4/4aMw?=
 =?us-ascii?Q?t1L9AARIqWxlr8IoeLpempsxAmSAYC9pm1Gcu2QUnpTOAT91dgL9UEkHc/OP?=
 =?us-ascii?Q?3g+Im36UmDqBTsaJdBPGlcXu8T6rGI9l6sgooho1o53z+ouJVscoTKF/iWiQ?=
 =?us-ascii?Q?7+6GZzUt2020FQ+3st0MlTp6uvuopUZ2Zss9kQvNMRhSvVsG5579TH/V2FR3?=
 =?us-ascii?Q?PCNVORl9V4FxoTvrzE+WoLmhPvI5XQOpkq9H7JR1Dw+/4qHyI5eSHkAJpmV8?=
 =?us-ascii?Q?6EzNUxZfhjhpZTwhxzpMkUzKzvnF2RjuLXEIFWHNmDp0KBbzfed3W0F0uJZz?=
 =?us-ascii?Q?iPlDTdgu+26/vidoDH0viBe4vNDy2/DFPJjwAYWoY4uL75BOxFuaxS0vd9pV?=
 =?us-ascii?Q?KhQ+9oBuknz5F/CddtumWh4f5Gz/EMJzyP+MLrBfO+Gz2XVisCJnEbw6kDxI?=
 =?us-ascii?Q?RQ7i2fTyCjT1TLtYbxv4j/BDvoCG2jZeeSNu10u18vmr110GClHNhw8ETril?=
 =?us-ascii?Q?kNg+SOBzEkRN+rS5Y2RnHcyQ5HJilcWJzGE1RLYZ9dVXwNm8YhXE7zBRDIHy?=
 =?us-ascii?Q?uTW+/pZudbpEdf+UmmzF1c9mookcLgzcXHlvaWTjDGAGsD2jAGS949+8587D?=
 =?us-ascii?Q?6P/NvTlrO4OfQp50p5na0SC5GmXSVFFnTww2WkQGJfAggKaeTAMX1u/qHAo4?=
 =?us-ascii?Q?LPOxQFJtDGEA0weh54VJ8Z3RUZCP2lIOfEgCO9Yi2OlySmxcp1RL8XuzrnY2?=
 =?us-ascii?Q?2RSJP7pFKunnqeIgURR4u0IuGVoCw4B3g5sUL0NY+AnOf+h06TxdvoY24SO+?=
 =?us-ascii?Q?c8v9Q0+CKZHoY7499m/cf+byjO3FjznlMV+Sim0h?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: chipsnmedia.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SL2P216MB1246.KORP216.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-Network-Message-Id: 56bf93ce-73c0-4c0c-93c6-08dc813fd8a8
X-MS-Exchange-CrossTenant-originalarrivaltime: 31 May 2024 07:03:59.7068
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4d70c8e9-142b-4389-b7f2-fa8a3c68c467
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 5ktcclnBclX+GpA5k9Im0hVEiE3G+QqVWbLWamSMb8FBjqntvl6KnFi8GsYBTK8+k23z1gxgZ3BuYkpMgUtaXHdlFFUXxHILvP8iP5yNaVc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SL2P216MB2194

Hi, Hans.

>-----Original Message-----
>From: Hans Verkuil <hverkuil@xs4all.nl>
>Sent: Thursday, May 30, 2024 7:32 PM
>To: Nas Chung <nas.chung@chipsnmedia.com>; mchehab@kernel.org; linux-
>media@vger.kernel.org; sebastian.fricke@collabora.com;
>m.tretter@pengutronix.de
>Cc: linux-kernel@vger.kernel.org
>Subject: Re: [PATCH v2] media: uapi: v4l: Change V4L2_TYPE_IS_CAPTURE
>condition
>
>On 28/05/2024 04:04, Nas Chung wrote:
>> Explicitly compare a buffer type only with valid buffer types,
>> to avoid matching the buffer type outside of valid buffer
>> type set.
>>
>> Signed-off-by: Nas Chung <nas.chung@chipsnmedia.com>
>> ---
>>  include/uapi/linux/videodev2.h | 7 ++++++-
>>  1 file changed, 6 insertions(+), 1 deletion(-)
>>
>> diff --git a/include/uapi/linux/videodev2.h
>b/include/uapi/linux/videodev2.h
>> index fe6b67e83751..fa2b7086e480 100644
>> --- a/include/uapi/linux/videodev2.h
>> +++ b/include/uapi/linux/videodev2.h
>> @@ -157,6 +157,10 @@ enum v4l2_buf_type {
>>  	V4L2_BUF_TYPE_PRIVATE              =3D 0x80,
>>  };
>>
>> +#define V4L2_TYPE_IS_VALID(type)		\
>> +	((type) >=3D V4L2_BUF_TYPE_VIDEO_CAPTURE	\
>> +	 && (type) <=3D V4L2_BUF_TYPE_META_OUTPUT)
>> +
>>  #define V4L2_TYPE_IS_MULTIPLANAR(type)			\
>>  	((type) =3D=3D V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE	\
>>  	 || (type) =3D=3D V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE)
>> @@ -171,7 +175,8 @@ enum v4l2_buf_type {
>>  	 || (type) =3D=3D V4L2_BUF_TYPE_SDR_OUTPUT			\
>>  	 || (type) =3D=3D V4L2_BUF_TYPE_META_OUTPUT)
>>
>> -#define V4L2_TYPE_IS_CAPTURE(type) (!V4L2_TYPE_IS_OUTPUT(type))
>> +#define V4L2_TYPE_IS_CAPTURE(type)	\
>> +	(V4L2_TYPE_IS_VALID(type) && !V4L2_TYPE_IS_OUTPUT(type))
>>
>>  enum v4l2_tuner_type {
>>  	V4L2_TUNER_RADIO	     =3D 1,
>
>This patch introduced this warning:
>
>In function 'find_format_by_index',
>    inlined from 'vdec_enum_fmt' at
>drivers/media/platform/qcom/venus/vdec.c:452:8:
>drivers/media/platform/qcom/venus/vdec.c:172:32: warning: 'valid' may be
>used uninitialized [-Wmaybe-uninitialized]
>  172 |                 if (k =3D=3D index && valid)
>      |                     ~~~~~~~~~~~^~~~~~~~
>drivers/media/platform/qcom/venus/vdec.c: In function 'vdec_enum_fmt':
>drivers/media/platform/qcom/venus/vdec.c:157:22: note: 'valid' was
>declared here
>  157 |                 bool valid;
>      |                      ^~~~~
>
>This driver does this:
>
>	bool valid;
>
>        if (V4L2_TYPE_IS_OUTPUT(type)) {
>                valid =3D venus_helper_check_codec(inst, fmt[i].pixfmt);
>        } else if (V4L2_TYPE_IS_CAPTURE(type)) {
>                valid =3D venus_helper_check_format(inst, fmt[i].pixfmt);
>
>With your patch both V4L2_TYPE_IS_OUTPUT(type) and
>V4L2_TYPE_IS_CAPTURE(type)
>can return false, something that wasn't possible without this patch.
>
>In this driver the fix would just be to drop the second 'if' altogether,
>so just
>'} else {'.
>
>Since these defines are part of the public API, this change introduces a
>subtle
>behavior difference that can affect applications.

Thank you for a detailed description.

>
>That said, I do consider this an improvement.
>
>I would like some changes, though:
>
>1) Just after "V4L2_BUF_TYPE_META_OUTPUT          =3D 14," in enum
>v4l2_buf_type,
>   add a comment saying that V4L2_TYPE_IS_VALID and (for output types)
>   V4L2_TYPE_IS_OUTPUT must be updated if a new type is added. It's all
>   too easy to forget that otherwise.

>2) Add a patch fixing the venus/vdec.c code.

1), 2) I will address both in v3.

>3) Something else I noticed, but I think this change should be in a
>separate patch:
>   V4L2_TYPE_IS_OUTPUT() returns true for V4L2_BUF_TYPE_VIDEO_OVERLAY, but
>that
>   definitely belongs to CAPTURE. Nobody really uses that type anymore,
>but still,
>   it should be fixed.

3) Would you prefer this modification to be included as a separate patch
in the v3 of this patch series, or should it be submitted as a new
standalone patch ?

Thanks.
Nas.

>
>Regards,
>
>	Hans