Received-SPF: pass (google.com: domain of linux-kernel+bounces-196440-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: Yunshui Jiang <jiangyunshui@kylinos.cn>
To: linux-kernel@vger.kernel.org,
	netdev@vger.kernel.org,
	linux-wpan@vger.kernel.org
Cc: alex.aring@gmail.com,
	stefan@datenfreihafen.org,
	miquel.raynal@bootlin.com,
	davem@davemloft.net,
	Yunshui Jiang <jiangyunshui@kylinos.cn>
Subject: [PATCH] net: mac802154: Fix racy device stats updates by DEV_STATS_INC() and DEV_STATS_ADD()
Date: Fri, 31 May 2024 16:07:39 +0800
Message-Id: <20240531080739.2608969-1-jiangyunshui@kylinos.cn>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable

mac802154 devices update their dev->stats fields locklessly. Therefore
these counters should be updated atomically. Adopt SMP safe DEV_STATS_INC=
()
and DEV_STATS_ADD() to achieve this.

Signed-off-by: Yunshui Jiang <jiangyunshui@kylinos.cn>
---
 net/mac802154/tx.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/net/mac802154/tx.c b/net/mac802154/tx.c
index 2a6f1ed763c9..6fbed5bb5c3e 100644
--- a/net/mac802154/tx.c
+++ b/net/mac802154/tx.c
@@ -34,8 +34,8 @@ void ieee802154_xmit_sync_worker(struct work_struct *wo=
rk)
 	if (res)
 		goto err_tx;
=20
-	dev->stats.tx_packets++;
-	dev->stats.tx_bytes +=3D skb->len;
+	DEV_STATS_INC(dev, tx_packets);
+	DEV_STATS_ADD(dev, tx_bytes, skb->len);
=20
 	ieee802154_xmit_complete(&local->hw, skb, false);
=20
@@ -90,8 +90,8 @@ ieee802154_tx(struct ieee802154_local *local, struct sk=
_buff *skb)
 		if (ret)
 			goto err_wake_netif_queue;
=20
-		dev->stats.tx_packets++;
-		dev->stats.tx_bytes +=3D len;
+		DEV_STATS_INC(dev, tx_packets);
+		DEV_STATS_ADD(dev, tx_bytes, len);
 	} else {
 		local->tx_skb =3D skb;
 		queue_work(local->workqueue, &local->sync_tx_work);
--=20
2.34.1