Received-SPF: pass (google.com: domain of linux-kernel+bounces-196438-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
From: Nas Chung <nas.chung@chipsnmedia.com>
To: Sebastian Fricke <sebastian.fricke@collabora.com>
CC: "mchehab@kernel.org" <mchehab@kernel.org>, "linux-media@vger.kernel.org"
	<linux-media@vger.kernel.org>, "m.tretter@pengutronix.de"
	<m.tretter@pengutronix.de>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2] media: uapi: v4l: Change V4L2_TYPE_IS_CAPTURE
 condition
Thread-Topic: [PATCH v2] media: uapi: v4l: Change V4L2_TYPE_IS_CAPTURE
 condition
Thread-Index: AQHasKNiVaRy5Vo9MECtK40uBvrWg7Gw9jgAgAAHCQA=
Date: Fri, 31 May 2024 08:03:58 +0000
Message-ID:
 <SL2P216MB1246BD404CD7450CD35C0D2EFBFC2@SL2P216MB1246.KORP216.PROD.OUTLOOK.COM>
References: <20240528020425.4994-1-nas.chung@chipsnmedia.com>
 <20240531072544.c3tw2uy25zctgs2j@basti-XPS-13-9310>
In-Reply-To: <20240531072544.c3tw2uy25zctgs2j@basti-XPS-13-9310>
Accept-Language: ko-KR, en-US
Content-Language: ko-KR
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?Ws6nV8CJ8u3lEAbYXU2I/hgjUzw5/yEKevsp54EhfyhN7ZrIa4tdUzyKE2cO?=
 =?us-ascii?Q?Zj1Ur21VrmUkR9993+4G3FF7Zt1xftRVJ5I7hTAjVpLg09q7+tHXPYUYTB+j?=
 =?us-ascii?Q?Tg31HThql5goxPeNYbaLUg15pjf7KNjItvy/GrUrPNAzgO9PhrP3J8LnJniE?=
 =?us-ascii?Q?psHSyLi4IclWlxc/xvSJsgULfwLvHBHSXtceL6Gq4+sHBMzOf4yLIAttDTRy?=
 =?us-ascii?Q?kPjrgF/AXzZiTFoV5nbzM9sX85soc+Y/A5Gl9xvt7wOEplLJ9FRZSJ+FVzrL?=
 =?us-ascii?Q?QaFqbHKeTnPu5x84EGkXbYoZq9kgtVVUpcf9F8ee9aNG4Lqx2pphORki7vTg?=
 =?us-ascii?Q?0Ulz5A5Fprbm3kYciCAtDAYJLcWNnBtBhcUDtberCsAbDAcLeOi70VZ2aXQJ?=
 =?us-ascii?Q?NDGpAbUiK7YYVtVEcwiLhSjLYBJYAybHIjAV1QQse3E4zS6NDtAwhzmDWnyO?=
 =?us-ascii?Q?sV8dG080ZOYKSMCFang8vAt3ANGs7d4pRHmNDkEF3YughtAWopfxTunK31MO?=
 =?us-ascii?Q?CP8hrg/wz8VT7E6lqu1rBdV0xR7JvNiOOIpzRq3B+0Emq4YRL78FkCNW9eyf?=
 =?us-ascii?Q?ydA7e10rqeuiBS6CzhSQ0e0Ki7q7D/jNFKX53TyFnWp02TxoVJNMAep+LlWT?=
 =?us-ascii?Q?upeBj6S0YjUeg5BB6W1ygdo9Kl7XptAeBZoODen6IjsBaIVcElrlXVvoN0rh?=
 =?us-ascii?Q?tQvVLh9N5GM4z14YirOwh40xTY2/C8qaW4sz1HaJP30cV7wMorWAHVFJkQJK?=
 =?us-ascii?Q?+UlOZibj5qn9qp03DcvQXEvmStuwz/QRDeW4PBSEwoFrYBR/KtQy2Lwrodh8?=
 =?us-ascii?Q?IjUHE8g9LlcBbHKxyTDDzqualuQom7GrCDfe59BE1OMlU6Omkkv8eXq/pcbd?=
 =?us-ascii?Q?3pVD186y9Er/+LMOza9Okn6/t36UtPXWFg/SJvSk40ymNrbZPTKk89R1PvkN?=
 =?us-ascii?Q?NL+QUcPpgFmZ3WScAJZQkbbAlfN1Rl2icUyc00V1lBhgVXWHh1girXWIjakQ?=
 =?us-ascii?Q?yQjiXqR82GnUSOQ4Wn9xod4M9jYGvEmpqnZR19t1MlE7/yzSYzzRBwHL5i0z?=
 =?us-ascii?Q?wAyjwZnElLfhtI/rFvnJ2/bbNHTPLxnZfnA5sH/GRFUwDAhmzyh6SVfUfZxy?=
 =?us-ascii?Q?HCBao4ASfzdTh4lRKYn+ZszMVPgqlr51/kaPzRjZwjbXmdAIgCI14lR/O2Hb?=
 =?us-ascii?Q?/mYYXdoXQrcpOgCbCQlwh9XZuC5ywRSj5RNvu8JSwLnRPdNDqPseUBMz2qBx?=
 =?us-ascii?Q?Ub4XREblqxWuE5Jgd9aagIp4iQCLrv2WAythwfP06n7SqWW+ti6Bb4cHUfEQ?=
 =?us-ascii?Q?ji42X+q4FwqiNliD8n5vX+km1st2MkH0n+N7PvAlEbUN+EHqfAuPpbg8O80h?=
 =?us-ascii?Q?0rJ6tProtj1AEUfcuFXEbXyK2SjlMOK3UJnDep4Kozyn29cs0OSxGKICC8nQ?=
 =?us-ascii?Q?SsEKNxg8dPdTDpiSvzNmkvhYvFpn7m9d0IUN++VwA9+LWiZgBzMRwVB/cGDb?=
 =?us-ascii?Q?pJZEq6k2CsfiJuqfvkwtedr0+P0Seh83jx8JWAlK4Vur96QAG9zxkcqg7gAe?=
 =?us-ascii?Q?ZB+4+HoLrzL7pKPKEq4605Vz7XM/p37N9vtBWuT2?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: chipsnmedia.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SL2P216MB1246.KORP216.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-Network-Message-Id: b3918748-2f23-47f7-513a-08dc81483984
X-MS-Exchange-CrossTenant-originalarrivaltime: 31 May 2024 08:03:58.1874
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4d70c8e9-142b-4389-b7f2-fa8a3c68c467
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 3AhAuA7YEO1CeYCmvzVryF7C1UCVz6ZtlL27m1zQTrUBEeLKubHS3WO0+E5UZQw4pZ0YfgPUnuXgtgf5NZ1coWhRUgdFK42o73ry3UAzGnI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SL2P216MB2909

Hi Sebastian.

>-----Original Message-----
>From: Sebastian Fricke <sebastian.fricke@collabora.com>
>Sent: Friday, May 31, 2024 4:26 PM
>To: Nas Chung <nas.chung@chipsnmedia.com>
>Cc: mchehab@kernel.org; linux-media@vger.kernel.org;
>m.tretter@pengutronix.de; linux-kernel@vger.kernel.org
>Subject: Re: [PATCH v2] media: uapi: v4l: Change V4L2_TYPE_IS_CAPTURE
>condition
>
>Hey Nas,
>
>just before you send out V3 ...
>
>On 28.05.2024 11:04, Nas Chung wrote:
>>Explicitly compare a buffer type only with valid buffer types,
>>to avoid matching the buffer type outside of valid buffer
>>type set.
>
>s/matching the buffer type outside of valid buffer type set/
>   matching a buffer type outside of the valid buffer type set/

Thank you for the review!
I will fix it in v3.

Thanks.
Nas.

>
>Regards,
>Sebastian
>
>>Signed-off-by: Nas Chung <nas.chung@chipsnmedia.com>
>>---
>> include/uapi/linux/videodev2.h | 7 ++++++-
>> 1 file changed, 6 insertions(+), 1 deletion(-)
>>
>>diff --git a/include/uapi/linux/videodev2.h
>b/include/uapi/linux/videodev2.h
>>index fe6b67e83751..fa2b7086e480 100644
>>--- a/include/uapi/linux/videodev2.h
>>+++ b/include/uapi/linux/videodev2.h
>>@@ -157,6 +157,10 @@ enum v4l2_buf_type {
>> 	V4L2_BUF_TYPE_PRIVATE              =3D 0x80,
>> };
>>
>>+#define V4L2_TYPE_IS_VALID(type)		\
>>+	((type) >=3D V4L2_BUF_TYPE_VIDEO_CAPTURE	\
>>+	 && (type) <=3D V4L2_BUF_TYPE_META_OUTPUT)
>>+
>> #define V4L2_TYPE_IS_MULTIPLANAR(type)			\
>> 	((type) =3D=3D V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE	\
>> 	 || (type) =3D=3D V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE)
>>@@ -171,7 +175,8 @@ enum v4l2_buf_type {
>> 	 || (type) =3D=3D V4L2_BUF_TYPE_SDR_OUTPUT			\
>> 	 || (type) =3D=3D V4L2_BUF_TYPE_META_OUTPUT)
>>
>>-#define V4L2_TYPE_IS_CAPTURE(type) (!V4L2_TYPE_IS_OUTPUT(type))
>>+#define V4L2_TYPE_IS_CAPTURE(type)	\
>>+	(V4L2_TYPE_IS_VALID(type) && !V4L2_TYPE_IS_OUTPUT(type))
>>
>> enum v4l2_tuner_type {
>> 	V4L2_TUNER_RADIO	     =3D 1,
>>--
>>2.25.1
>>