Received-SPF: pass (google.com: domain of linux-kernel+bounces-196469-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Precedence: bulk
MIME-Version: 1.0
References: <20240530232054.3559043-1-chris.packham@alliedtelesis.co.nz>
 <CAMuHMdXGJxwRDRjKQT5aa6off9nQ5WqreK9K-QhJwhUXngYA=Q@mail.gmail.com> <CAHp75Ve3-JkNUuF_LT=E53WfEfxt5yizSvoD22a3OvHiPXSRJQ@mail.gmail.com>
In-Reply-To: <CAHp75Ve3-JkNUuF_LT=E53WfEfxt5yizSvoD22a3OvHiPXSRJQ@mail.gmail.com>
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: Fri, 31 May 2024 10:22:02 +0200
Message-ID: <CAMuHMdXg1GCAqYPy++4UjFN6QsCnfikZdvsz5=2G4j13E3DUjQ@mail.gmail.com>
Subject: Re: [PATCH] auxdisplay: linedisp: Support configuring the boot message
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Chris Packham <chris.packham@alliedtelesis.co.nz>, andy@kernel.org, tzimmermann@suse.de, 
	ojeda@kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Andy,

On Fri, May 31, 2024 at 10:16=E2=80=AFAM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
> On Fri, May 31, 2024 at 10:45=E2=80=AFAM Geert Uytterhoeven
> <geert@linux-m68k.org> wrote:
> > On Fri, May 31, 2024 at 7:28=E2=80=AFAM Chris Packham
> > <chris.packham@alliedtelesis.co.nz> wrote:
> > > Like we do for charlcd, allow the configuration of the initial messag=
e
> > > on line-display devices.
>
> ...
>
> > > +#ifndef CONFIG_PANEL_BOOT_MESSAGE
> > >  #include <generated/utsrelease.h>
> > > +#endif
> >
> > The #ifndef/#endif is not really needed.
>
> It's needed to avoid unnecessary build of the module (in case of m).

OK.

> > As I see no real deficiencies:
> > Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
>
> I believe you agree with leaving ifdeffery above.

Thanks, I agree to agree ;-)

Gr{oetje,eeting}s,

                        Geert

--=20
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k=
org

In personal conversations with technical people, I call myself a hacker. Bu=
t
when I'm talking to journalists I just say "programmer" or something like t=
hat.
                                -- Linus Torvalds