Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754428AbYBDLwR (ORCPT ); Mon, 4 Feb 2008 06:52:17 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751811AbYBDLwF (ORCPT ); Mon, 4 Feb 2008 06:52:05 -0500 Received: from mx3.mail.elte.hu ([157.181.1.138]:53144 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752060AbYBDLwD (ORCPT ); Mon, 4 Feb 2008 06:52:03 -0500 Date: Mon, 4 Feb 2008 12:51:44 +0100 From: Ingo Molnar To: Jan Engelhardt Cc: Thomas Gleixner , Linux Kernel Mailing List , petr@vandrovec.name Subject: Re: Commit f06e4ec breaks vmware Message-ID: <20080204115144.GA17850@elte.hu> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1328 Lines: 45 * Jan Engelhardt wrote: > sad to say, but f06e4ec... breaks booting the kernel in vmware > (bisected). Booting just stops after > > Checking for 'hlt' instruction... > > commit f06e4ec1c15691b0cfd2397ae32214fa36c90d71 > Author: Ingo Molnar > Date: Wed Jan 30 13:32:39 2008 +0100 > > x86: read_tsc sync > > make native_read_tsc() always non-speculative. could you send us the /proc/cpuinfo data of the guest CPU? if latest -git still fails, does the patch below solve the problem? Ingo --- include/asm-x86/system.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) Index: linux-x86.q/include/asm-x86/system.h =================================================================== --- linux-x86.q.orig/include/asm-x86/system.h +++ linux-x86.q/include/asm-x86/system.h @@ -407,8 +407,7 @@ void default_idle(void); */ static inline void rdtsc_barrier(void) { - alternative(ASM_NOP3, "mfence", X86_FEATURE_MFENCE_RDTSC); - alternative(ASM_NOP3, "lfence", X86_FEATURE_LFENCE_RDTSC); + smp_mb(); } #endif -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/