Received-SPF: pass (google.com: domain of linux-kernel+bounces-196510-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Fri, 31 May 2024 11:53:29 +0300
From: Dan Carpenter <dan.carpenter@linaro.org>
To: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Cc: Edward Adam Davis <eadavis@qq.com>,
	syzbot+07762f019fd03d01f04c@syzkaller.appspotmail.com,
	linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com,
	Dan Carpenter <error27@gmail.com>
Subject: Re: [syzbot] [input?] [usb?] KMSAN: uninit-value in asus_report_fixup
Message-ID: <b86a9ef9-ea50-45e1-85b6-20b6f5358862@moroto.mountain>
References: <000000000000915d550619389e8a@google.com>
 <tencent_9FA58DAAA5CF0D8B9250DDB2DDF4192FCF07@qq.com>
 <a66819c1-1ee1-47e1-8831-c0f1a22a12c9@oracle.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <a66819c1-1ee1-47e1-8831-c0f1a22a12c9@oracle.com>

On Thu, May 30, 2024 at 08:16:59PM +0530, Harshit Mogalapalli wrote:
> > diff --git a/drivers/hid/usbhid/hid-core.c b/drivers/hid/usbhid/hid-core.c
> > index a90ed2ceae84..9f0e09f667b1 100644
> > --- a/drivers/hid/usbhid/hid-core.c
> > +++ b/drivers/hid/usbhid/hid-core.c
> > @@ -1029,7 +1029,7 @@ static int usbhid_parse(struct hid_device *hid)
> >   		return -EINVAL;
> >   	}
> > -	rdesc = kmalloc(rsize, GFP_KERNEL);
> > +	rdesc = kzalloc(rsize, GFP_KERNEL);

This kzalloc() is unnecessary because hid_get_class_descriptor() has
a memset() built in:

	memset(buf, 0, size);

I'm not a huge fan of how if hid_get_class_descriptor() runs out of
retries, we return the number of bytes in a partial read.  Then the
caller pretends it was a success instead of using the result.  But
that's a different issue.

regards,
dan carpenter