Received-SPF: pass (google.com: domain of linux-kernel+bounces-196561-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <ee3d218f-d90b-46f7-877d-4057ac84bb1b@amd.com>
Date: Fri, 31 May 2024 14:49:48 +0530
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 0/4] Export APICv-related state via binary stats interface
To: Alejandro Jimenez <alejandro.j.jimenez@oracle.com>, kvm@vger.kernel.org
Cc: seanjc@google.com, pbonzini@redhat.com, linux-kernel@vger.kernel.org,
 suravee.suthikulpanit@amd.com, vashegde@amd.com, mlevitsk@redhat.com,
 joao.m.martins@oracle.com, boris.ostrovsky@oracle.com, mark.kanda@oracle.com
References: <20240429155738.990025-1-alejandro.j.jimenez@oracle.com>
Content-Language: en-US
From: Vasant Hegde <vasant.hegde@amd.com>
In-Reply-To: <20240429155738.990025-1-alejandro.j.jimenez@oracle.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?MXNraFdzNmZiZEhleWRXRGI3YmNRd1IrWktWMTZlWU9GS3RuS0k4VUJWUlEy?=
 =?utf-8?B?YWdqQzFjTTJnd2UvS1FHdFFUUEpMQURTQmVvOGl6Q2FTUWVNQW9SNG5lK08x?=
 =?utf-8?B?ZW8xZnNKd1RzbzlzK054bkFkQ2UzQ2hOV3lSRW8zYm13MndITFRxMnZxMlQv?=
 =?utf-8?B?bi9rc2t0Vm4yM1BxVC9EMVBKbkhTQmozOUhvQ2QrTncyWjFReWxsWjhWZ1Bu?=
 =?utf-8?B?NWtndTRUVXhOaVJWNDJ3ZlJFWEJCRFlDOTRMb2pseTN5VVdtWjljMjd6QUYv?=
 =?utf-8?B?Rm8xcEZ4enZ2OE1Sc2N6TEdsNnRaeGp5aGFLemcxa1FwVDlSMjNkLzVvUnQ1?=
 =?utf-8?B?ZHBPbXprZzBaZndRMEQ2M3hvRFR6RGJDNzhVQllXUlVtNGwzaEpuRXc4Rk9T?=
 =?utf-8?B?cHZCYnp2Q2hIRFZhaGU2S1pmZTk5VXBlOEJmNjMwdDMybE1TWjkxT290Zktx?=
 =?utf-8?B?dGplOGdhUkRLajRsRXR2V3U4dHJHZEVGRm5tdW83MGlhcWJ1dzhCUlh0WGRG?=
 =?utf-8?B?UnFYSmdrRTNxQUQxaEJoWVhvVThsb054Q0FzZmxCZmI1YTg1eXYyT0VrdzQz?=
 =?utf-8?B?Tkt5dWZDY2wvcEZFQURFN1ZEWXNRaXFBeUsvZ3BYT2RHVE1GZ0Vyd3piWFQ1?=
 =?utf-8?B?Q091akc2eTVIRU1DZWFDRG1LeE1PZUJSWEEzQW9DcE9iOUxXZGZVc2puUVJr?=
 =?utf-8?B?QmVjZkFqVDZsRjFEeVNpQXN2VFcza1UyN0FVUUZoODZKb3BLNVRmdXlCOGtF?=
 =?utf-8?B?S3VpL3ZVTlZLanZjUkJMQnhtTDZnZitjQXlrdytpdjRBcUgycHoyZ0RBQlBy?=
 =?utf-8?B?MndVdGxHN2tEcVFMMVJ0K2lwZENkUWU3cUR5Qk9kTmJzSmxWSFA0cEViVitn?=
 =?utf-8?B?RDRrVEJOQ2pEaEVZeG9STXFaUUF1Uk5XeVl5c1AwQnZ6d1BwdUJ1QWJzbS9l?=
 =?utf-8?B?SW9KSWtSZlNqcGh5QjU3eHNJekFWVWRNWUdWUE9GU3NkbXVJZlVwQ0JSNmVr?=
 =?utf-8?B?bndaLy9UcEtPclNmdG9BdDZYeUVqcTRjS3dCNDZ6MjVQSzdhYUJPU2I2NVAv?=
 =?utf-8?B?N3RZbEhrMTIyTnBSMXFqS1dKYTdGZkR1YzZsSUhhYlhzUWVWeEN0eWc3THNM?=
 =?utf-8?B?UkQ2T0djN081ZUxNQTNsRU5Bd2FIdUNpZmZSOC9KWFFUWm5GV2dIRSsrWXkx?=
 =?utf-8?B?WDY0YUw0OWM5ckhTdGMvblBGZGlRY050TVZFOTA1WTRBMmI1Wm1RRjJEZFl4?=
 =?utf-8?B?ZXR0N09pRk4vbUROZjBpeTg5YkEwK2pZVlcvOVI3OW9jSEJCQWdmQWlDTUN6?=
 =?utf-8?B?VllOWk95d0ZtdURXNmpmcVBOSnVvRzlId2RqYzJKLzA4M3M1ZjRXVlZZYWRU?=
 =?utf-8?B?R2R2TmRKYm5EZEZXbjZlWUsxOXB6MFg4NVF3UXJKUW9MSFBFU1ZXMkEwajJZ?=
 =?utf-8?B?eEJDVTB4dVFwVzN4bDVwcUJYNWYvYjhkR1N4T00zTnZVL1dMc2NRb2ZnNjFi?=
 =?utf-8?B?eTU5K0x0YXJhNmhGaVlyaGRmZGsvR2RuR0VJNFdWTjNBb2EzaXFSK3E2dUFV?=
 =?utf-8?B?dHpTYThrQ1ZwZnNZVWVUZkIzbC8wUUJBT29EcDdIN1NzRFFHY0F4R1ZMMmRE?=
 =?utf-8?B?TEZFUjE3Sk0rVW9MYnovNFZZZExLcnoyOWJPeE9LVHcvbFhNU2pNWWZJSEUy?=
 =?utf-8?B?aGp6Y0hTQWx4VkE4dURqUlRXVkxUWUdNczdLUzdZejJDMXVFa0l2Q3lKMElN?=
 =?utf-8?B?Q1lkTTcxeWRza1FZY2NqeDZVeU8xQ0pjc3ZObVNzd29rMHk5MEN5NGdTNU50?=
 =?utf-8?B?UzZzMW1UT2pNWUJSdjhxSXNjRjBxQmgyK2lYdW11UFA4a1lHOFVMcXpHWUlw?=
 =?utf-8?B?QS9EY0hHcXl1TmMwTS9OUk55bTJ4Vi9BTmFsUmFWRkRzUmQyUU12YTU0MHlo?=
 =?utf-8?B?cFpnQVR0SG5oWVRIL3FRZnpRYTk3MEc1bnlhZG45U3ErL201UW0rOThYWGg1?=
 =?utf-8?B?S011cmN1VERGTlc1MjNRSVE3bU5kaHNmTEJUOWU2djYvVmtsY2NPaVRMcEpX?=
 =?utf-8?B?R05meUlVL2pzZWNvNG0zQVpEeHlJcldKZ0ZBOXp5MzRtSFN3cElWOXBpckZV?=
 =?utf-8?Q?SUbBDd4/gclzuwNzDCIo4o3FY?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 669a92fd-fd3b-4291-7d9f-08dc8152d6fd
X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB6048.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 May 2024 09:19:57.7571
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: IX0j1LNzsTWsrWajASdhZbvnf/MArgaSVLU1l3yipcJyDQC5kpif0bMu69T3jl6wJ23f1uRqDFwBfw3Vl5RQNA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB8341

Hi,


On 4/29/2024 9:27 PM, Alejandro Jimenez wrote:
> After discussion in the RFC thread[0], the following items were identified as
> desirable to expose via the stats interface:
> 
> - APICv status: (apicv_enabled, boolean, per-vCPU)
> 
> - Guest using SynIC's AutoEOI: (synic_auto_eoi_used, boolean, per-VM)
> 
> - KVM PIT in reinject mode inhibits AVIC: (pit_reinject_mode, boolean, per-VM)
> 
> - APICv unaccelerated injections causing a vmexit (i.e. AVIC_INCOMPLETE_IPI,
>   AVIC_UNACCELERATED_ACCESS, APIC_WRITE): (apicv_unaccelerated_inj, counter,
>   per-vCPU)
> 
> Example retrieving the newly introduced stats for guest running on AMD Genoa
> host, with AVIC enabled:


I have reviewed generic and AMD driver related code. Also tested this series on
AMD systems and its working fine.

Tested-by: Vasant Hegde <vasant.hegde@amd.com>

-Vasant


> 
> (QEMU) query-stats target=vcpu vcpus=['/machine/unattached/device[0]'] providers=[{'provider':'kvm','names':['apicv_unaccelerated_inj','apicv_active']}]
> {
>     "return": [
>         {
>             "provider": "kvm",
>             "qom-path": "/machine/unattached/device[0]",
>             "stats": [
>                 {
>                     "name": "apicv_unaccelerated_inj",
>                     "value": 2561
>                 },
>                 {
>                     "name": "apicv_active",
>                     "value": true
>                 }
>             ]
>         }
>     ]
> }
> (QEMU) query-stats target=vm providers=[{'provider':'kvm','names':['pit_reinject_mode','synic_auto_eoi_used']}]
> {
>     "return": [
>         {
>             "provider": "kvm",
>             "stats": [
>                 {
>                     "name": "pit_reinject_mode",
>                     "value": false
>                 },
>                 {
>                     "name": "synic_auto_eoi_used",
>                     "value": false
>                 }
>             ]
>         }
>     ]
> }
> 
> Changes were also sanity tested on Intel Sapphire Rapids platform, with/without
> IPI virtualization.
> 
> Regards,
> Alejandro
> 
> [0] https://lore.kernel.org/all/20240215160136.1256084-1-alejandro.j.jimenez@oracle.com/
> 
> Alejandro Jimenez (4):
>   KVM: x86: Expose per-vCPU APICv status
>   KVM: x86: Add a VM stat exposing when SynIC AutoEOI is in use
>   KVM: x86: Add a VM stat exposing when KVM PIT is set to reinject mode
>   KVM: x86: Add vCPU stat for APICv interrupt injections causing #VMEXIT
> 
>  arch/x86/include/asm/kvm_host.h | 4 ++++
>  arch/x86/kvm/hyperv.c           | 2 ++
>  arch/x86/kvm/i8254.c            | 2 ++
>  arch/x86/kvm/lapic.c            | 1 +
>  arch/x86/kvm/svm/avic.c         | 7 +++++++
>  arch/x86/kvm/vmx/vmx.c          | 2 ++
>  arch/x86/kvm/x86.c              | 7 ++++++-
>  7 files changed, 24 insertions(+), 1 deletion(-)
> 
> 
> base-commit: 7b076c6a308ec5bce9fc96e2935443ed228b9148