Received-SPF: pass (google.com: domain of linux-kernel+bounces-196577-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <ddd2f4a3-9d44-4f98-aee2-0a4b5553004f@amd.com>
Date: Fri, 31 May 2024 14:53:27 +0530
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 3/4] KVM: x86: Add a VM stat exposing when KVM PIT is set
 to reinject mode
To: Alejandro Jimenez <alejandro.j.jimenez@oracle.com>, kvm@vger.kernel.org
Cc: seanjc@google.com, pbonzini@redhat.com, linux-kernel@vger.kernel.org,
 suravee.suthikulpanit@amd.com, vashegde@amd.com, mlevitsk@redhat.com,
 joao.m.martins@oracle.com, boris.ostrovsky@oracle.com, mark.kanda@oracle.com
References: <20240429155738.990025-1-alejandro.j.jimenez@oracle.com>
 <20240429155738.990025-4-alejandro.j.jimenez@oracle.com>
Content-Language: en-US
From: Vasant Hegde <vasant.hegde@amd.com>
In-Reply-To: <20240429155738.990025-4-alejandro.j.jimenez@oracle.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ckdlQ3UzR0VpendEcVhVVHl2UmNmTStmMVl1NmZmNjkraisyYXRaRlM1Tzgy?=
 =?utf-8?B?M1JLaHp6QjlnWGVibzR4SU9ZUnMwWnFwV0R0MHh1Mm9zUk9SM3VhVERGaHBk?=
 =?utf-8?B?U3MyR3lLWmtLZU1mQ3c1TDVTUzFyN0RMbFpwdk1RdUwwVkdyYkpDdzVYNXhR?=
 =?utf-8?B?Z1FUUE1YQlNpSHQ4NUhLanVaUFdUSGV0QUx0NDRkNEdMMndhd2t1T0kyRUt2?=
 =?utf-8?B?ZUV0YlEvdWkrNmlYZ2xmMGtwNkpMaUZBaGhZQmQ2a0ROREdWaDhlSnRDaUJL?=
 =?utf-8?B?dDQwQlJ2R3ZOYlNtM3pmZ3F2angrelZBYjBRbkh4ZVI0d2RJdFE3TXR4MG5m?=
 =?utf-8?B?ei8zYXFzVUxvbzVuYTkvc0prQnZlemJIVk1icU9KRTJLTzZjdHFPSzBibmY1?=
 =?utf-8?B?VkMvYmx4YllNYjIzYkJ6dTRwUjROVjdlRXJHbmhOTWxSbm9SQmNNQWkyc2tN?=
 =?utf-8?B?NXpxYjMzZjc3dFpneTlvc0RkYWZCcS9wM3NFc25QQWd5Yy92NmVoQ0djUmtO?=
 =?utf-8?B?a3Q3K05qQ2pISnlzK3dyUFNXMXR4SHFhOTAvR2x0NmdmRktCRGMrc2ZYY0lu?=
 =?utf-8?B?TUlxQU03ZTVEblhIV1pNc3oyTHNMK3hZMWNMTHdZcmJTVnNyOEhZZEFoYys2?=
 =?utf-8?B?MW5OVFVJRVM4by9aZ0xZUEtYRVZFYUpmM215QWkyL2dLRlp4MUlxaXAzV2s5?=
 =?utf-8?B?dmMwRFRjV3BqQXZxRkhkdTJHcDlsSzAvZWRPQndlMkJpdzhmc2hpT2F2UkFZ?=
 =?utf-8?B?MWxiZFQ3Qi9zQXN6R0x0NmpUUkdnazdJTElNZ1c4ZFlMTVVvVGJHeExDTnRt?=
 =?utf-8?B?M1NXZTJ1YzgrZkJRSXFEeVNqeExTRER1bEMwdC9kNWV6eDNRcDBISGIzQkVw?=
 =?utf-8?B?Yngya0NEdERrTW10U0tXODdib0xqOXlXeS92YXVnNlpMUy9wL3p4cWdISlFL?=
 =?utf-8?B?aXUzdHgyUTFoRXp4djRPWnZKSkRqK1VLUTdtdUUrM1YwR3BHZUozWEZqNXRY?=
 =?utf-8?B?WThJeTE0UCtVd2NXVEV1RWZCVW1QNGgvS25icVp1Z2d0Sng3N2dTRFVZYmQy?=
 =?utf-8?B?ZWlEUkUvOVIwWHk1L0dsWUJFVy9LOVZJZ29HNFZ5NC9QVG42KzJuM0tnYnhV?=
 =?utf-8?B?WWtaMVVrenNhM0FpeVkyQ2ZZcDh6NkVxN0NjMjZRYnp6SFo0dnRyQkF4dWdC?=
 =?utf-8?B?Q0Yxaytta05waGJacStNa1FvRlFzZlBMR0lGU3lHZzJwdENGUkowUEE3ZkJv?=
 =?utf-8?B?enZPK09GNVV0RnZyZnhkUEdFM2o3R21pRWFSWXIrTUZNZWs2UXpuTmRjbjlK?=
 =?utf-8?B?WU5WWnFSUnBLbmdpRnNvVXYzTHhjeGdUS3RqV3ZmQVhyWkhkSkh2Z3ZCS2Ex?=
 =?utf-8?B?TlVxVkhxMWpMU1FTZk1pSSs4TkFYSThwUDRrQjBNRkZ0M2lCTU50dWhTUXc0?=
 =?utf-8?B?TEFJUm9FU1U0UmxIaEZVVjZNL2dvaWhmVTdER3hzVXE2aDVma2VGNk8vLzVW?=
 =?utf-8?B?L0xpWWhDbjNFTDdJQy9HS1gvQjhKK2ZFM2dYZ05XUFRiWDRNa0c2amRJK01C?=
 =?utf-8?B?SUhsSTVYNEliRm8xd0k0Z0RIV1JId2N0K3VOVXk0ZVFCZWVRL3UzVUE4LzAy?=
 =?utf-8?B?L2lRT1UxMld4ME9kbG5qOGp2RldFdllFRjNrS2lnZ3FIRnhYRHV3YUVaRVND?=
 =?utf-8?B?THVMc1R5anlWRU1oc3l4K0k3WktEcHBHZTJHanZIUCt5OTVtc3R2ZlFVcGhN?=
 =?utf-8?B?RDRBSnJkc05wdE91NFF4OWZhUnFtWkFRWGdWRkR2NjZBK0FsY2lRMU01THJ2?=
 =?utf-8?B?NUJZb3dvb0pFK3dFQ3A4eFBqcTk3VXZSWDRHVWNNYkJyMHVXOUxYMmo0Q1Vh?=
 =?utf-8?B?TDFCc09aempyQllvdHdiL28yRE1UQm5iclpMc3lBVTV6SjhDeEN3U3ErNGZr?=
 =?utf-8?B?TUdhaHQ2UHl5Q0pwYytpWTN4V0ErclpzaEpkTFF6dnoxWUV5T3hJMlB1Nk1V?=
 =?utf-8?B?SVdlc3RsQlNUUEpJVDJsbzhvRHMxaXJ1Z0UwUUkrbzJ2NkxaZGFuZEtKNHI5?=
 =?utf-8?B?OVF3WWNJZ0VzR0JrdDIveUVVR3Nqd1RoMnNySmxtVVM5ZTI5c1VHREtkMjRY?=
 =?utf-8?Q?CwskKxUHU//oW+Q9uyxDlYQXC?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 34bd5f59-88a3-4020-c2d7-08dc81535968
X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB6048.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 May 2024 09:23:36.5228
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kl2fkFhMf3+zAGyAmTtoLvz8WrxdH5QCaGu4WKHzo7vQSmE7HcDZOZ88nPh6FTMSXmclvB5sLnm+f/Rxe8KEYw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6303


On 4/29/2024 9:27 PM, Alejandro Jimenez wrote:
> Add a stat to query when PIT is in reinject mode, which can have a large
> performance impact due to disabling SVM AVIC.
> When using in-kernel irqchip, QEMU and KVM default to creating a PIT in
> reinject mode, since this is necessary for old guest operating systems that
> use the PIT for timing. Unfortunately, reinject mode relies on EOI
> interception and so SVM AVIC must be inhibited when the PIT is set up using
> this mode.
> 
> Signed-off-by: Alejandro Jimenez <alejandro.j.jimenez@oracle.com>

Reviewed-by: Vasant Hegde <vasant.hegde@amd.com>

-Vasant

> ---
>  arch/x86/include/asm/kvm_host.h | 1 +
>  arch/x86/kvm/i8254.c            | 2 ++
>  arch/x86/kvm/x86.c              | 3 ++-
>  3 files changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h
> index f3b40cfebec4..e7e3213cefae 100644
> --- a/arch/x86/include/asm/kvm_host.h
> +++ b/arch/x86/include/asm/kvm_host.h
> @@ -1535,6 +1535,7 @@ struct kvm_vm_stat {
>  	u64 max_mmu_page_hash_collisions;
>  	u64 max_mmu_rmap_size;
>  	u64 synic_auto_eoi_used;
> +	u64 pit_reinject_mode;
>  };
>  
>  struct kvm_vcpu_stat {
> diff --git a/arch/x86/kvm/i8254.c b/arch/x86/kvm/i8254.c
> index cd57a517d04a..44e593e909a1 100644
> --- a/arch/x86/kvm/i8254.c
> +++ b/arch/x86/kvm/i8254.c
> @@ -316,6 +316,8 @@ void kvm_pit_set_reinject(struct kvm_pit *pit, bool reinject)
>  		kvm_unregister_irq_mask_notifier(kvm, 0, &pit->mask_notifier);
>  	}
>  
> +	kvm->stat.pit_reinject_mode = reinject;
> +
>  	atomic_set(&ps->reinject, reinject);
>  }
>  
> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
> index 27e339133068..03cb933920cb 100644
> --- a/arch/x86/kvm/x86.c
> +++ b/arch/x86/kvm/x86.c
> @@ -257,7 +257,8 @@ const struct _kvm_stats_desc kvm_vm_stats_desc[] = {
>  	STATS_DESC_ICOUNTER(VM, nx_lpage_splits),
>  	STATS_DESC_PCOUNTER(VM, max_mmu_rmap_size),
>  	STATS_DESC_PCOUNTER(VM, max_mmu_page_hash_collisions),
> -	STATS_DESC_IBOOLEAN(VM, synic_auto_eoi_used)
> +	STATS_DESC_IBOOLEAN(VM, synic_auto_eoi_used),
> +	STATS_DESC_IBOOLEAN(VM, pit_reinject_mode)
>  };
>  
>  const struct kvm_stats_header kvm_vm_stats_header = {