Received-SPF: pass (google.com: domain of linux-kernel+bounces-196575-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <6a612d9e-e488-4604-b3e2-801767115f2c@amd.com>
Date: Fri, 31 May 2024 14:52:35 +0530
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 4/4] KVM: x86: Add vCPU stat for APICv interrupt
 injections causing #VMEXIT
To: Alejandro Jimenez <alejandro.j.jimenez@oracle.com>, kvm@vger.kernel.org
Cc: seanjc@google.com, pbonzini@redhat.com, linux-kernel@vger.kernel.org,
 suravee.suthikulpanit@amd.com, vashegde@amd.com, mlevitsk@redhat.com,
 joao.m.martins@oracle.com, boris.ostrovsky@oracle.com, mark.kanda@oracle.com
References: <20240429155738.990025-1-alejandro.j.jimenez@oracle.com>
 <20240429155738.990025-5-alejandro.j.jimenez@oracle.com>
Content-Language: en-US
From: Vasant Hegde <vasant.hegde@amd.com>
In-Reply-To: <20240429155738.990025-5-alejandro.j.jimenez@oracle.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?S2NrT1k5VWRqYzA4Z3d6SG11NXJnOWJQaGovY245VVEzNUdkaVVoRXVPUUkw?=
 =?utf-8?B?TEhjMm12TE5RMEd0cmU2ZVVzVk10ejEzZHFJYzkzWXEyczhEcSs0T2k5c2gv?=
 =?utf-8?B?bUtOdHcrSjg3RStLV2RzZy9iNlpqTzRCREhzVnYrUDN1c01LMHFBUUx3S05Y?=
 =?utf-8?B?dFFxTyswN3dJMXZLYWN5VWZiWlV0NXJTWm1RK1UzdzRMNHVjbTE4NWcyWmtU?=
 =?utf-8?B?L3VENUI4NlRCZk1YZXZYc3hnbG5jL3JPZHZFalU2ZkhzdWZOSEE2S1pNMjJI?=
 =?utf-8?B?b0I2TWF0aG9RWjl3VDI4Rk9PWHUrSUVvVk9qUFMvZ0lYR1k5d1kzSzZPbmow?=
 =?utf-8?B?MDQ4RWxEcVVyMmhJK3V6MTVaZGl0b09uUkN2dEN1NllEYkFDdzZtZGtBbUFF?=
 =?utf-8?B?TjJnUmVGUUFPbG42SHZZUmZzQ3ExK2ZwWHd4TDA0TlpFVzMySUllY0VQQThm?=
 =?utf-8?B?UjE5bU1SanFFeVNWKzFqZzh1NVVpWURNVC9KYVc3bytZV0NOS3R0VmF2UDFo?=
 =?utf-8?B?ejRjcDlQeFRYSHgzekVKMVVaY2IrKzN1OEQxczVaZzFaa0NjdzYwb2tVZmJj?=
 =?utf-8?B?dFVsQzFxZEhiMEhYQkoxVldNWStUbEpMcHZOMWEvUTdhbFpIMWdOcytaQUxN?=
 =?utf-8?B?TW1JVWJoNS9XVnBrYkJldnZvTkFycHNXTEJrSUxTNUV0eklqM2RURTNJM2Y5?=
 =?utf-8?B?MzcvZkMyZmtEdEpFZHlZUnJBSER5TjhLeTRBaTh2TGNBYVNSWUxjTTNXZnB5?=
 =?utf-8?B?ZktmUEQvMmtIV2hoT3htK2tXeUU3T3loSjFRVEdYN1dRRTNXZjRnRDA5U2FJ?=
 =?utf-8?B?Zmsza0JsRWwyS1JSd2dwN2RBT0JUSVlJcUtNQTYvekVHM0tLbUNOcVZzUUhu?=
 =?utf-8?B?R3NxdFpSNWZ6OWFEOE10QUMxOWFoOWl1RkJBUlRIRnBLRXcxaDBuTktUL3A0?=
 =?utf-8?B?T3pUa0ViTFlhRUVGRmtrQ3orb3pTK0dsakQ4L1RQc0dsQll3bklMMy82RVp2?=
 =?utf-8?B?eFpWdDlBeXo5MHB2WlRGK240dFI3c1IrcmUwcXhqWlA0UjFQV1QycFFkSXJE?=
 =?utf-8?B?RnNNcGtNTnVxWGJvalVKaERjNVZNa1R3dUdjQlhDMzdYUW1idkMwOGhzWFk1?=
 =?utf-8?B?SmFrN1NPelpYTW55NDZRaWhiejJhUURxcDFRSDBodDdGdnllN3pwYnhDV2t3?=
 =?utf-8?B?bU4xcmJXT2pIZE42dXNFbmxkb1AwVTZ5Z3lvbXIvNnFIUzc4bXV0M0xtUzVQ?=
 =?utf-8?B?L1ZHOHlhLzRsYm42dVlSVHBDbGVOSkdJWVFldkNJamVuV3BObjFHVk1JZW1V?=
 =?utf-8?B?TnRodStwc2Z6ZC91SFk5NGxVWlZuK0N5ckRvTGVBUzBPejlYNTVnWUZtRjFW?=
 =?utf-8?B?RUNJRXl3T2UxRWFvU0hRK0JwbmdtUlR4OGhiUXJMUnhtSEhNdlVkbm43YXJW?=
 =?utf-8?B?Qmp4UFFaZjhpaWU4TE5GVzdyMjNyRHVFVDIyQkMrM0ZBWHF5Q3IxR0IyVm1J?=
 =?utf-8?B?c0xyU0U0aVprQkJzaVB3cW1FQlVoSVBobndMUDEvRkk5NFliTnhSTjJYd0xZ?=
 =?utf-8?B?QUZTekthWGtVcFplaVhwWlQ4UTE5VzVneUJpcGxjRFNJN0o5RndWSHc3RE5O?=
 =?utf-8?B?dkwvSFEwTG1WY25kcllKdDNVVjdrQU1aTzFSVGxjQXpZWVZzMmdFS2RxTStR?=
 =?utf-8?B?QXphemFJMVpKWXd1ZTgzcW5sMlRTNUJnRDNDVVBYN29qcURWQy8wd2FYeUdZ?=
 =?utf-8?B?T01CWEhLRHdwYTc1T2JpMzdnYVZtdlp3ekc3TmR1VHF1RlExU3lFWFYrVm84?=
 =?utf-8?B?aktPV1ZuSlRYb2MyOWdjSmRzdUJxbzBMYUpzblFPQjh2SkhVRHByMHdwVTdz?=
 =?utf-8?B?dTRIdXNxUTlHVEJrMkhMd1Q5QmwwTWh3VUdYQ0hpWEhOSG5rQytNTGVITS8z?=
 =?utf-8?B?Qmk2Wnp3ZmN3bEt4NFhockQybUE5VnZtUHUvdUpMWFROL0ZrL2tkZGxjQkJV?=
 =?utf-8?B?OEtydW9UTUtZR0dHdERwdEhqanFXUWx6RGtoWUJ4bkRydkJrRjFpUWlYQk1j?=
 =?utf-8?B?UHBKcUNBeXVpeDVlcE13OGtFTkRzdDhpVjFTdzZNMVEweHRsWnFoSlRrNjgz?=
 =?utf-8?Q?bDWVxCJ6jwoaWVn4RgiuRPxp3?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7092feef-651d-4670-7d98-08dc81533ac5
X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB6048.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 May 2024 09:22:45.1201
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: CDV7hi0FYyH7dkh+VFiliT0YSypudnLCkCDfnvuAnGVZBGNgzBizfjUTk4d9f9T+N8SfjNmte0V9ko2Ex0uPGA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB8341

Hi Alejandro,


On 4/29/2024 9:27 PM, Alejandro Jimenez wrote:
> Even when APICv/AVIC is active, certain guest accesses to its local APIC(s)
> cannot be fully accelerated, and cause a #VMEXIT to allow the VMM to
> emulate the behavior and side effects. Expose a counter stat for these
> specific #VMEXIT types.
> 
> Suggested-by: Paolo Bonzini <pbonzini@redhat.com>
> Signed-off-by: Alejandro Jimenez <alejandro.j.jimenez@oracle.com>

Reviewed-by: Vasant Hegde <vasant.hegde@amd.com> # AMD

-Vasant

> ---
>  arch/x86/include/asm/kvm_host.h | 1 +
>  arch/x86/kvm/svm/avic.c         | 7 +++++++
>  arch/x86/kvm/vmx/vmx.c          | 2 ++
>  arch/x86/kvm/x86.c              | 1 +
>  4 files changed, 11 insertions(+)
> 
> diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h
> index e7e3213cefae..388979dfe9f3 100644
> --- a/arch/x86/include/asm/kvm_host.h
> +++ b/arch/x86/include/asm/kvm_host.h
> @@ -1576,6 +1576,7 @@ struct kvm_vcpu_stat {
>  	u64 guest_mode;
>  	u64 notify_window_exits;
>  	u64 apicv_active;
> +	u64 apicv_unaccelerated_inj;
>  };
>  
>  struct x86_instruction_info;
> diff --git a/arch/x86/kvm/svm/avic.c b/arch/x86/kvm/svm/avic.c
> index 4b74ea91f4e6..274041d3cf66 100644
> --- a/arch/x86/kvm/svm/avic.c
> +++ b/arch/x86/kvm/svm/avic.c
> @@ -517,6 +517,8 @@ int avic_incomplete_ipi_interception(struct kvm_vcpu *vcpu)
>  			kvm_apic_write_nodecode(vcpu, APIC_ICR);
>  		else
>  			kvm_apic_send_ipi(apic, icrl, icrh);
> +
> +		++vcpu->stat.apicv_unaccelerated_inj;
>  		break;
>  	case AVIC_IPI_FAILURE_TARGET_NOT_RUNNING:
>  		/*
> @@ -525,6 +527,8 @@ int avic_incomplete_ipi_interception(struct kvm_vcpu *vcpu)
>  		 * vcpus. So, we just need to kick the appropriate vcpu.
>  		 */
>  		avic_kick_target_vcpus(vcpu->kvm, apic, icrl, icrh, index);
> +
> +		++vcpu->stat.apicv_unaccelerated_inj;
>  		break;
>  	case AVIC_IPI_FAILURE_INVALID_BACKING_PAGE:
>  		WARN_ONCE(1, "Invalid backing page\n");
> @@ -704,6 +708,9 @@ int avic_unaccelerated_access_interception(struct kvm_vcpu *vcpu)
>  
>  	trace_kvm_avic_unaccelerated_access(vcpu->vcpu_id, offset,
>  					    trap, write, vector);
> +
> +	++vcpu->stat.apicv_unaccelerated_inj;
> +
>  	if (trap) {
>  		/* Handling Trap */
>  		WARN_ONCE(!write, "svm: Handling trap read.\n");
> diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c
> index f10b5f8f364b..a7487f12ded1 100644
> --- a/arch/x86/kvm/vmx/vmx.c
> +++ b/arch/x86/kvm/vmx/vmx.c
> @@ -5657,6 +5657,8 @@ static int handle_apic_write(struct kvm_vcpu *vcpu)
>  {
>  	unsigned long exit_qualification = vmx_get_exit_qual(vcpu);
>  
> +	++vcpu->stat.apicv_unaccelerated_inj;
> +
>  	/*
>  	 * APIC-write VM-Exit is trap-like, KVM doesn't need to advance RIP and
>  	 * hardware has done any necessary aliasing, offset adjustments, etc...
> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
> index 03cb933920cb..c8730b0fac87 100644
> --- a/arch/x86/kvm/x86.c
> +++ b/arch/x86/kvm/x86.c
> @@ -307,6 +307,7 @@ const struct _kvm_stats_desc kvm_vcpu_stats_desc[] = {
>  	STATS_DESC_IBOOLEAN(VCPU, guest_mode),
>  	STATS_DESC_COUNTER(VCPU, notify_window_exits),
>  	STATS_DESC_IBOOLEAN(VCPU, apicv_active),
> +	STATS_DESC_COUNTER(VCPU, apicv_unaccelerated_inj),
>  };
>  
>  const struct kvm_stats_header kvm_vcpu_stats_header = {