Received-SPF: pass (google.com: domain of linux-kernel+bounces-196648-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <1922c6893fd78b5c9af1549ac109d097341c4b0e.camel@kernel.org>
Subject: Re: [PATCH] NFSD: remove unused structs 'nfsd3_voidargs'
From: Jeff Layton <jlayton@kernel.org>
To: linux@treblig.org, chuck.lever@oracle.com, neilb@suse.de
Cc: linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org
Date: Fri, 31 May 2024 06:09:27 -0400
In-Reply-To: <20240531000838.332082-1-linux@treblig.org>
References: <20240531000838.332082-1-linux@treblig.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.50.4 (3.50.4-1.fc39) 
Precedence: bulk
MIME-Version: 1.0

On Fri, 2024-05-31 at 01:08 +0100, linux@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
>=20
> 'nfsd3_voidargs' in nfs[23]acl.c is unused since
> commit 788f7183fba8 ("NFSD: Add common helpers to decode void args
> and
> encode void results").
>=20
> Remove them.
>=20
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> ---
> =C2=A0fs/nfsd/nfs2acl.c | 2 --
> =C2=A0fs/nfsd/nfs3acl.c | 2 --
> =C2=A02 files changed, 4 deletions(-)
>=20
> diff --git a/fs/nfsd/nfs2acl.c b/fs/nfsd/nfs2acl.c
> index 12b2b9bc07bf..4e3be7201b1c 100644
> --- a/fs/nfsd/nfs2acl.c
> +++ b/fs/nfsd/nfs2acl.c
> @@ -308,8 +308,6 @@ static void nfsaclsvc_release_access(struct
> svc_rqst *rqstp)
> =C2=A0	fh_put(&resp->fh);
> =C2=A0}
> =C2=A0
> -struct nfsd3_voidargs { int dummy; };
> -
> =C2=A0#define ST 1		/* status*/
> =C2=A0#define AT 21		/* attributes */
> =C2=A0#define pAT (1+AT)	/* post attributes - conditional */
> diff --git a/fs/nfsd/nfs3acl.c b/fs/nfsd/nfs3acl.c
> index 73adca47d373..5e34e98db969 100644
> --- a/fs/nfsd/nfs3acl.c
> +++ b/fs/nfsd/nfs3acl.c
> @@ -221,8 +221,6 @@ static void nfs3svc_release_getacl(struct
> svc_rqst *rqstp)
> =C2=A0	posix_acl_release(resp->acl_default);
> =C2=A0}
> =C2=A0
> -struct nfsd3_voidargs { int dummy; };
> -
> =C2=A0#define ST 1		/* status*/
> =C2=A0#define AT 21		/* attributes */
> =C2=A0#define pAT (1+AT)	/* post attributes - conditional */

Reviewed-by: Jeff Layton <jlayton@kernel.org>