Received: by 2002:a05:6500:2018:b0:1fb:9675:f89d with SMTP id t24csp352818lqh; Fri, 31 May 2024 03:28:25 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUujamrFCZsEb68IPIz7Qoc/RU03QWOqL5guLMogoT4Yuo0WPc7I6iRc0O9fl/l4LHGzvrGNkOuKl7dO3cBcd92q0s8AUiDa+hPFrlg6g== X-Google-Smtp-Source: AGHT+IGg8O5AoHoHl7mwfUWL5QfR88izJH5KbUHO7qCiIRqpee+j4wLlQs5GK71Ntg45lY9VxFhz X-Received: by 2002:a50:d493:0:b0:578:6198:d6fa with SMTP id 4fb4d7f45d1cf-57a36349402mr1041758a12.2.1717151305553; Fri, 31 May 2024 03:28:25 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1717151305; cv=pass; d=google.com; s=arc-20160816; b=tOHFu3KuaHl5THSZJ/XeqtkY4SLeZohN+6pt8qN9z2d2r9mzn2FFJjYGmP4NUx9rqe rqLdZOQyOcBasgVtbZFNWKxnvf0205tKKT5qZnlBi1bkTbtl5VJQ4Ht4dk11X1ep3l/C i3OttVKdUqqDyp9U+JOnCaCxbkRcUCPsfznbb/xJdPv0gPG1pbt7jEuXixj0N1V3ctxO XIlyk1ex353O6Z7Zt0nCiY1KHJ1C4QG2JX3BNlqI0YuaX2NqmRxgH3u6vDUh7N9NHjeN Xdf+qAQnSi2Z2it4SCIInIEWNrFCqYgZJna/Dv0DMevRHCpfqvvvJYVcTjViCGRre+pd s9lA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=A/jqzJ30udmjiCKH8UpKHnt2ITLX9Faq+5fQCwJ3v/Q=; fh=CWAak03JF7+wGZvRH+EFUrUR8lA3Ge3oR7OzyEnM6tg=; b=e0pkmYwjitQFORuOWstPCQYgtvZoLsLYoNATTEts5i7dO+fPw7H/DgIWGKh1qZXjUl 0a1MTP6gl2UA8md6YTtts9DXz34vVYLtYdvLmnFBHl9MZysvqhXG0Kbe3NeXM0X4iK7b WphIGaKwJvAJKeG78jCk7t9+ElGnAlsTb+d+frIbyD3rk49hFKB0qSrGjFdVfjf+3Mqp M8fYwxencVxnLrEJ1/aWjPbTJS2PpacfyjZHK/GlfGaL5bAkgYA0jwg1184V18YZCyyz 817gYVP174FmAvvSRRHDp9hbHK2fhMLrRj5bDownUsUSHMr1h8ycmI0wUyJKsOx4evhf no1g==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=NCWKVfCM; arc=pass (i=1 dkim=pass dkdomain=linuxfoundation.org); spf=pass (google.com: domain of linux-kernel+bounces-196672-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-196672-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id 4fb4d7f45d1cf-57a31c62d7esi817906a12.328.2024.05.31.03.28.25 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 May 2024 03:28:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-196672-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=NCWKVfCM; arc=pass (i=1 dkim=pass dkdomain=linuxfoundation.org); spf=pass (google.com: domain of linux-kernel+bounces-196672-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-196672-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 49B251F22CCC for ; Fri, 31 May 2024 10:27:51 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C4BEA155A5D; Fri, 31 May 2024 10:27:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="NCWKVfCM" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E8F5E150997; Fri, 31 May 2024 10:27:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717151264; cv=none; b=SeY4eNl3uM5xcl50HVpLKbb/U69TcqOhq5wUsgDBuWF2JOEd59vFWmUknrucl+AqxsPSGVhNAzuNM5Pgg8rCZJyw1G8UHPjPLrbv/KmCRtGHwTtKobMG1KjF15sX0bxFpP/ljFKDeYASymmSzmvUe3Qk84nI2HuUIm64PZcMR+s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717151264; c=relaxed/simple; bh=PM8ANQnKhvkI+gz4ItjHDKqR6gOZxi2IR2Bb937AyPI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Dx0nldO5ofz9F3xyKtYvmfQhxq5u45Z5dxRRppdQMpwLGi/ddcK7eY6b6W+0xxU4dN87kdzf8pvj+Ae/NVLIYQJEbupKa86R7y9xdj4O4bUD0wkmVMnI0gWfBd1L/vfolUVmLMcXtdHci7xzHEeB57gNqk7FZXRfE3lpG2rSMzQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=NCWKVfCM; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0C960C116B1; Fri, 31 May 2024 10:27:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1717151263; bh=PM8ANQnKhvkI+gz4ItjHDKqR6gOZxi2IR2Bb937AyPI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NCWKVfCMa9YNVJZ0npgh0NnanJsG2pPCP05jHEGQYUIKOXmoUP4ijuS0lttbjPNSz xs1QABG861GkgPMFZ5kgeU9ksJLRoSjiaPzHV+wnMNdYT3h6jAWHOzFnKRr+raGyWm fNj1jnTUcCYgrN5Jc4VoCH1pseZDuRPtEYlaGaJI= Date: Fri, 31 May 2024 12:27:49 +0200 From: Greg KH To: Daniel Mack Cc: hvilleneuve@dimonoff.com, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] serial: sc16is7xx: set driver name Message-ID: <2024053127-custody-bankable-817d@gregkh> References: <20240531101959.181457-1-daniel@zonque.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240531101959.181457-1-daniel@zonque.org> On Fri, May 31, 2024 at 12:19:59PM +0200, Daniel Mack wrote: > Set the drv_name field of the driver struct so that the tty core > registers a procfs entry for it. This is useful for debugging. > > Signed-off-by: Daniel Mack > --- > drivers/tty/serial/sc16is7xx.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/tty/serial/sc16is7xx.c b/drivers/tty/serial/sc16is7xx.c > index bf0065d1c8e9..308edbacda7b 100644 > --- a/drivers/tty/serial/sc16is7xx.c > +++ b/drivers/tty/serial/sc16is7xx.c > @@ -351,6 +351,7 @@ static struct uart_driver sc16is7xx_uart = { > .owner = THIS_MODULE, > .driver_name = SC16IS7XX_NAME, > .dev_name = "ttySC", > + .driver_name = SC16IS7XX_NAME, Are you sure this patch is correct? Look 2 lines up :)