Received-SPF: pass (google.com: domain of linux-kernel+bounces-196736-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <e6b7858b-39cd-432d-9206-4ccbd153baa2@arm.com>
Date: Fri, 31 May 2024 17:01:49 +0530
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [QUESTION] mm: Redundant const parameter?
From: Dev Jain <dev.jain@arm.com>
To: zhouchengming@bytedance.com
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
 Anshuman.Khandual@arm.com
References: <e5f01ffe-de51-4079-a87f-2886788422f9@arm.com>
Content-Language: en-US
In-Reply-To: <e5f01ffe-de51-4079-a87f-2886788422f9@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

I guess it would be better if I send this as a patch and wait for comments.

On 5/31/24 16:42, Dev Jain wrote:
> Hi Chengming,
>
> In mm/slub.c, you had defined slab_test_node_partial() to take a const 
> parameter.
>
> Is there any point of taking in a const, when you are anyways 
> typecasting it to
>
> a (struct folio *) from (const struct folio *) ? In fact, at the place 
> where you call
>
> slab_test_node_partial(), the struct slab *slab is not const.
>
> Please comment.
>
>
> Thanks
>
> DJ
>
>
>
>