Received-SPF: pass (google.com: domain of linux-kernel+bounces-196837-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
From: Subbaraya Sundeep Bhatta <sbhatta@marvell.com>
To: Breno Leitao <leitao@debian.org>, Pravin B Shelar <pshelar@ovn.org>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>
CC: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "horms@kernel.org"
	<horms@kernel.org>,
        "open list:OPENVSWITCH" <dev@openvswitch.org>,
        open list
	<linux-kernel@vger.kernel.org>
Subject: RE: [EXTERNAL] [PATCH net-next 2/2] openvswitch: Remove generic
 .ndo_get_stats64
Thread-Topic: [EXTERNAL] [PATCH net-next 2/2] openvswitch: Remove generic
 .ndo_get_stats64
Thread-Index: AQHas0wBf9yoYda2AkybQGVh8GPWCbGxT9+g
Date: Fri, 31 May 2024 13:07:02 +0000
Message-ID: 
 <CO1PR18MB4666072D5694E38AABDB8CEEA1FC2@CO1PR18MB4666.namprd18.prod.outlook.com>
References: <20240531111552.3209198-1-leitao@debian.org>
 <20240531111552.3209198-2-leitao@debian.org>
In-Reply-To: <20240531111552.3209198-2-leitao@debian.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?rqzuq0UMVrZMdqknogzp1730HTGrQ44yMQpWUZqwxQ6eB9uT1XLihR8pYoYM?=
 =?us-ascii?Q?v+Av0Gwuz1I096Rp37anXGM5crMvg5dc2FjNQnuFJmMvOtqVTTkVOVmamC5P?=
 =?us-ascii?Q?cRBy2oHEw9yzGxZoFVUD+qFmq9Yubc0rtsihgNUz6meTtTQQbNySqIv+Rfrd?=
 =?us-ascii?Q?/1vd+bsM0/72KNpS2YrL41hCMSAhFhNOl3T+84/x+QzFAN0zIB4dc/n3aw9i?=
 =?us-ascii?Q?s/9y7+vk/fOwNfCio39iVz3cv7B1Okp++eBu/FsSD5mffNseFuDdnLEjIsGL?=
 =?us-ascii?Q?W97lr5jR6O3rjdbe5z3rrokUUs6HZAexOnqvhBeMfsky9IoGK+6Q6dJc9MmD?=
 =?us-ascii?Q?pzP1ZCR9iHQbhaTEqXQcjebdAhcTcBAsqGPkLkhr8FJNKo2YhyC6v09KEQV6?=
 =?us-ascii?Q?dHBgZc1dY8bKgtbOiCL4i5q+3nn/Rn2BBrxnC9UtOtmpDzfReyoTHw9Ob5u3?=
 =?us-ascii?Q?skilO1U5sXrE6yDMo6nCrWfN1/6ukjpoZ5rpIA3NASd8pqtEuxgOx+g7eiKJ?=
 =?us-ascii?Q?TdlORMK1bjkhZMyPJcpevESYO8Ec2DydkigBqOqbkR4dbuTpDnbrWmNzTOJn?=
 =?us-ascii?Q?lxML86IJfCjTghp4PCo2vKDgHaSkmYqlmv5bFz0IUxdl6ls517+SYg5Ve/iU?=
 =?us-ascii?Q?6e2zwfFVOHxHF+I5r8Hf5NKVnpLW6o40XShFgHV1qzFaZSDIFeJ708qDX2Dh?=
 =?us-ascii?Q?NJ0K6oZyxfJFUzjiOwE3pK3WslFfadLvVPVfr3sycesTj2g/+T0T/I8E6Akg?=
 =?us-ascii?Q?17cHwZ91DDZsiFVZUct7Nk8i/dhOXe/KpAnSwKjg5Bz4N/D3dqShzcJZ9X8f?=
 =?us-ascii?Q?8oxd5aM5EvvWbrLZz7yhVgiG523AevIzgkYKgSmNaFBb5qBZCYOgj8/dqbPZ?=
 =?us-ascii?Q?/Nuw/5zRajhepuxlo6vu0jcxaEqQbjz941Dasfc1rmabquvs6hen927tYnkH?=
 =?us-ascii?Q?hOmG3l2MSM/vP4x5WKiQGhywkjr7y3t7DuVDpT2fbsElCtjWy5MZA18K7EM4?=
 =?us-ascii?Q?YGEqUKPUwUXjN2b98U2dGVHwOLHo63Q63cspf8lCwmtqDFvj+WRrPnvm/H/2?=
 =?us-ascii?Q?LuG6fs7LIPbd7LFv8fFxDygJy8TedEkqH0hM7B+hmUEn1UIOgRrDGIPADBOY?=
 =?us-ascii?Q?1F21f9QiNVN2zg5oIAf2hopg0D1gDoxP75N3Mi2ZTbRcngW7BVHms8kSn2NA?=
 =?us-ascii?Q?qnNWfLLva45O1eLsMXEIDmF9jyBcZ/tk0Q6veMoZj3sVlJGislRzaQANawzm?=
 =?us-ascii?Q?h4/ftAh6cLJyTBAdj7A/fciB2nwh64vivWT1M0sxOz55Q0Rwbm0gjFSa4BD6?=
 =?us-ascii?Q?sD3/bBxx57g6uEyuGL5JnLQHGFFN8Q1sO+FOIsIdZJ4WgaW6FWXpAEbvoNd7?=
 =?us-ascii?Q?8vjUmgGli2Q699YfXkAcSweXuUsZ+Z3Lh+8VJi2OKm6J+/d+SnC5qynwlBdy?=
 =?us-ascii?Q?eoLWOTj88I5FOfSx+XuEvOTuQbBJxLz7LhLfrH4mYNhCxFSrbml40hCB5Amh?=
 =?us-ascii?Q?s/hl6o6AJZ+fTqGM3jcpcgN8iud2OUF47RylwAVd5Fr3gG97PfW9y4mfyeUB?=
 =?us-ascii?Q?sVzL5kDvTBCDWvd37BQ=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CO1PR18MB4666.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fa408da5-112d-4a3f-e950-08dc81729009
X-MS-Exchange-CrossTenant-originalarrivaltime: 31 May 2024 13:07:02.2354
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Fm0wElUbR2seXLslfTdzt0tzdjM0dpwFDmLVTjedsc/4e+dYPmbFdlp/hfbAKok6gTisBnuOiHnhZtTfBYuBlA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR18MB5058
X-Proofpoint-ORIG-GUID: wQqBc5tpdH8YKW6UKr7cyNXKe585HIm1
X-Proofpoint-GUID: wQqBc5tpdH8YKW6UKr7cyNXKe585HIm1
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.650,FMLib:17.12.28.16
 definitions=2024-05-31_08,2024-05-30_01,2024-05-17_01

Hi,

>-----Original Message-----
>From: Breno Leitao <leitao@debian.org>
>Sent: Friday, May 31, 2024 4:46 PM
>To: Pravin B Shelar <pshelar@ovn.org>; David S. Miller <davem@davemloft.ne=
t>;
>Eric Dumazet <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>; Paol=
o
>Abeni <pabeni@redhat.com>
>Cc: netdev@vger.kernel.org; horms@kernel.org; open list:OPENVSWITCH
><dev@openvswitch.org>; open list <linux-kernel@vger.kernel.org>
>Subject: [EXTERNAL] [PATCH net-next 2/2] openvswitch: Remove generic
>.ndo_get_stats64
>
>Commit 3e2f544dd8a33 ("net: get stats64 if device if driver is
>configured") moved the callback to dev_get_tstats64() to net core, so,
>unless the driver is doing some custom stats collection, it does not
>need to set .ndo_get_stats64.
>
>Since this driver is now relying in NETDEV_PCPU_STAT_TSTATS, then, it
>doesn't need to set the dev_get_tstats64() generic .ndo_get_stats64
>function pointer.
>
>Signed-off-by: Breno Leitao <leitao@debian.org>

Reviewed-by: Subbaraya Sundeep <sbhatta@marvell.com>

Thanks,
Sundeep

>---
> net/openvswitch/vport-internal_dev.c | 1 -
> 1 file changed, 1 deletion(-)
>
>diff --git a/net/openvswitch/vport-internal_dev.c b/net/openvswitch/vport-
>internal_dev.c
>index 7daba6ac6912..4b33133cbdff 100644
>--- a/net/openvswitch/vport-internal_dev.c
>+++ b/net/openvswitch/vport-internal_dev.c
>@@ -85,7 +85,6 @@ static const struct net_device_ops internal_dev_netdev_o=
ps
>=3D {
> 	.ndo_stop =3D internal_dev_stop,
> 	.ndo_start_xmit =3D internal_dev_xmit,
> 	.ndo_set_mac_address =3D eth_mac_addr,
>-	.ndo_get_stats64 =3D dev_get_tstats64,
> };
>
> static struct rtnl_link_ops internal_dev_link_ops __read_mostly =3D {
>--
>2.43.0
>