Received-SPF: pass (google.com: domain of linux-kernel+bounces-196963-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: "Sukrit.Bhatnagar@sony.com" <Sukrit.Bhatnagar@sony.com>
To: Christoph Hellwig <hch@infradead.org>
CC: Pavel Machek <pavel@ucw.cz>, "Rafael J. Wysocki" <rafael@kernel.org>,
        Christian Brauner <brauner@kernel.org>,
        "Darrick J. Wong"
	<djwong@kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        "linux-xfs@vger.kernel.org" <linux-xfs@vger.kernel.org>,
        "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
        "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>
Subject: RE: [PATCH 0/2] Improve dmesg output for swapfile+hibernation
Thread-Topic: [PATCH 0/2] Improve dmesg output for swapfile+hibernation
Thread-Index: 
 AQHarBuqqIQ7Mttzp0e7Oah3njC7eLGlO2CAgAW3O9CAAATqAIAABjfQgAAVSQCABlmkcA==
Date: Fri, 31 May 2024 14:15:43 +0000
Message-ID: 
 <TYAPR01MB4048E8F253CBFE44EBF9836CF6FC2@TYAPR01MB4048.jpnprd01.prod.outlook.com>
References: <20240522074658.2420468-1-Sukrit.Bhatnagar@sony.com>
 <Zk+c532nfSCcjx+u@duo.ucw.cz>
 <TYAPR01MB4048D805BA4F8DEC1A12374DF6F02@TYAPR01MB4048.jpnprd01.prod.outlook.com>
 <ZlRseMV1HgI4zXNJ@infradead.org>
 <TYAPR01MB40481A5A5DC3FA97917404E2F6F02@TYAPR01MB4048.jpnprd01.prod.outlook.com>
 <ZlSDinoWgqLt21QD@infradead.org>
In-Reply-To: <ZlSDinoWgqLt21QD@infradead.org>
Accept-Language: en-US, ja-JP, en-GB
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?Ss6XjYY/p9NA0XtUICifgUNKLGnTq1KXcRoxTDr1fI5nP/hg05p9PBYPoYyi?=
 =?us-ascii?Q?PSxNN4zTncatqd+nG+bIlcEi9ZfSqT7TWayNWkpWHfgCs33jTyEiZ8hqwUsz?=
 =?us-ascii?Q?iv2OBjbaWR2VMoo84lg2B/XhJnoX3FLnoPJ8XESxNVmT7Tu3suWrqGVLBSu8?=
 =?us-ascii?Q?X8eN6d6vxaLdSThAE/Jq+/RLcR9TGVOmCmG2iV3cGNCiuE553R1Z+gY4cxs4?=
 =?us-ascii?Q?TrVp8UwVz+F/mDbf6skrqqmWUKGFliGFifo/UaWFUri5g5K8tfdYVjlX/L27?=
 =?us-ascii?Q?thhKUPBHfERs7uU2DSX7IrBmcKkSjbcB4+MThTL954FMkvya5mckVOUaSnr+?=
 =?us-ascii?Q?/SliI5j6niu5xiBXpo3oKC3zfgnIVcRsCCsrPDEkF2G5LUl1QRqHKORg30y7?=
 =?us-ascii?Q?s5ER4dqQqvLp4Zc8enKbJoe5a4TBVDk2EayEuDn9i8WuRvAI+hfNbeKgFd2E?=
 =?us-ascii?Q?oxrJU3V1WW+Tye8OXl7VKOwpKOMOp7GtwK6nbNHvg+M6HgdssvPK3RBNNOBT?=
 =?us-ascii?Q?5CyN3nkMrESdOC9/jTnYkC4ZDrkI2AGTGLrKT8JUA4pJaHqx71NKZLfG8/kG?=
 =?us-ascii?Q?L4/b2K1NP1PppQ/vfAGhEtsLJqRxtsnmjsU5F6vnDppR2wy/ctUiVXeU8f/V?=
 =?us-ascii?Q?sTSZNNe4g1VU+0fCWECpAcoQk2nVS+hvPZC/KhyEaZbN6cXdtwrZyELMYOS2?=
 =?us-ascii?Q?hoJeGIEmF3K6OOU4bkBwp3HBPoG1JT1wlsu8Ocbn/REfWMGz5Q7dQfYx0AIq?=
 =?us-ascii?Q?/V1dPuylpnKHRuNNQG73pifi1M3nxhFC2z0IjmUgOgFFxvoWqCgNcB7VrW4Q?=
 =?us-ascii?Q?qOeuJfKW57DHZzO/XGvF/r4V9nYXRz1qHhjyw7pmuu/Xq+2iXKNa5qrnGPgy?=
 =?us-ascii?Q?BXd3TLfX614oSujyJUl8g2yUjnPFAwIhT01F6qQSZ4HJq2PZC56NLivR4ZJU?=
 =?us-ascii?Q?PI+B+51zP1hJqrND6VOlpCkeke6kL3z8UA5AAxggxrf7j7cdXbnbYq8DVaxj?=
 =?us-ascii?Q?UAzsiggrucNZw7ZfWnJc8QZEgK/XTrnietdpFMzAzdgKBuhD0sk/OjBCHaQz?=
 =?us-ascii?Q?sROd5gppVt56kF6V+sK/+h+Q5G+2i55DdaOy8LwN2XrzGg1SjV2qDqMTzKjD?=
 =?us-ascii?Q?MVBzCzfE1MNFAqEP65s/PQYIcn8VlXO3dz6i3zsSG43j6TujUDQWKOmp9Ftd?=
 =?us-ascii?Q?O/lirkoeMrcfg+gr5S/PhTjWiTBTvxJLodKIpn0sD+Fw5J9A2w3gcXc005RP?=
 =?us-ascii?Q?iAx86CRK48M4/cuoCd9WSnWgK69qfe50sZBUQ1hPuFQGL6jsSgODrEGBvEe0?=
 =?us-ascii?Q?ZoXoX703Kd461EBSosvxLxv+uNeoSwoQD9+2HG5SBwLFOPDkAqyVaijzU3U/?=
 =?us-ascii?Q?YRGbDEf4uXZWHgXeu0mzv2WJGgiqBtkzcjGvKCENibRp2NJ0CLF1+qvaazCR?=
 =?us-ascii?Q?U0mNGTEqXnexd4KdFYVT3jHkiR6Tfv827nB0PceCf9mDvwzjw2ykvj2gMdFV?=
 =?us-ascii?Q?2oUcp2aMaPHLhTjbNiXBHAewNcBz5TJENJPDlGKLBq7T3/Hm5rVGMp6GNBIf?=
 =?us-ascii?Q?cFjC2N3jm/VOamOoO9cmJO2QJ4OPwUf0YAAcy9lo?=
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	V6tuBXVDJ6SUmedlhJI/X8uk6guc/LPfzL0dohzakzmnMKC1WUiVJdsWyKAvL+k7o6qaICqX2vxZUNLFoIqEnDgfoSIWNRd6w5VgLHoZ9zrOVUxr6uJpVVGaBQkcjr8rs9usaUIYTYULBt/coRLTahgiOSFFfkfcHz1Ezi7zqbCIpOXiyTemyADhkG8ttd6rcKhzuMN8PiKp22VJED0Mj2LL1f5O08qMkvsqrhdVUS2Avg6pIgwDBN2gow8m4pyKBrMPxK1Xrus4tStffGei1KJq3ElEjVGnjOQmxyAVrUvtyjUwNexTxQwbd9FvnpEta4ChPLkV52T6w6BQpXD21J6Heb2fLfg2NH9zOSV1FzYEkV9PByHvuM2RV77jBPgk8mVkAsa4OlAs621uIelNI+WqsNYNrtF5foWxJSmUY6PYdx7gLLSIJJ9cDunIXDK4SzutMXch5quXUoZVXVJY8BtoKpO9dAhRw/Vda6whE+xwOAUd8iBvYO0ooK00cNMjYoks7Cz50Cgkv2VL6dSDWMJB+7T3Aaue+/IKtQonEA0m1aFvu6Jzi2L9JonS/APBZM4fVquH9dajenSSjfujNRSJFzdlAvbDNAzjMnqltuUAyucHPw4ZlJDEyE+7+Cv6
X-OriginatorOrg: sony.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: TYAPR01MB4048.jpnprd01.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f0efda80-2d3a-4eb9-dfe8-08dc817c2884
X-MS-Exchange-CrossTenant-originalarrivaltime: 31 May 2024 14:15:43.5225
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 66c65d8a-9158-4521-a2d8-664963db48e4
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 5EZcmHSV1n1qpPL3kkAN/8403/d5cG36v9cXFP3li6SiMjzHSDPn7iKOugXvK9C+4FtBAAZjuzIaG6bpTq9MYKKRDpjiej3ZqC7WhwzENBM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: OSAPR01MB7255
X-Proofpoint-ORIG-GUID: fv4UwVxttMOYqwiwpLRvG-HE3bEr2uwB
X-Proofpoint-GUID: fv4UwVxttMOYqwiwpLRvG-HE3bEr2uwB
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
X-Sony-Outbound-GUID: fv4UwVxttMOYqwiwpLRvG-HE3bEr2uwB
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.650,FMLib:17.12.28.16
 definitions=2024-05-31_10,2024-05-30_01,2024-05-17_01

On 2024-05-27 21:58, Christoph Hellwig wrote:
> On Mon, May 27, 2024 at 12:51:07PM +0000, Sukrit.Bhatnagar@sony.com wrote=
:
>> In my understanding, the resume offset in hibernate is used as follows.
>>=20
>> Suspend
>> - Hibernate looks up the swap/swapfile using the details we pass in the
>>   sysfs entries, in the function swsusp_swap_check():
>>   * /sys/power/resume - path/uuid/major:minor of the swap partition (or
>>                         non-swap partition for swapfile)
>>   * /sys/power/resume_offset - physical offset of the swapfile in that
>>                                partition
>>   * If no resume device is specified, it just uses the first available
>>   swap! - It then proceeds to write the image to the specified swap.
>>   (The allocation of swap pages is done by the swapfile code
>>   internally.)
>=20
> Where "it" is userspace code?  If so, that already seems unsafe for
> a swap device, but definitely is a no-go for a swapfile.

By "it", I meant the hibernate code running in kernel space.
Once userspace triggers hibernation by `echo disk > /sys/power/state`
or a systemd wrapper program etc., and userspace tasks are frozen,
everything happens within kernel context.

>> - Hibernate gets the partition and offset values from kernel command-lin=
e
>>   parameters "resume" and "resume_offset" (which must be set from
>>   userspace, not ideal).
>=20
> Or is it just for these parameters?  In which case we "only" need to
> specify the swap file, which would then need code in the file system
> driver to resolve the logical to physical mapping as swap files don't
> need to be contiguous.

Yes, it is just for setting these parameters in sysfs entries and in kernel
commandline.
I think specifying the swapfile path *may* not work because when we resume
from hibernation, the filesystems are not yet mounted (except for the case
when someone is resuming from initramfs stage).
Using the block device + physical offset, this procedure becomes Independen=
t
of the filesystem and the mounted status.
And since the system swap information is lost on reboot/shutdown, the kerne=
l
which loads the hibernation image will not know what swaps were enabled
when the image was created.

--
Sukrit