Received: by 2002:a05:6500:2018:b0:1fb:9675:f89d with SMTP id t24csp482107lqh; Fri, 31 May 2024 07:21:01 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUHuLw58yJp9BPOdS3s8dSYJ8RbXMssoxorMutP2gPvDmN3DKtY/yZNU539hUS1ks83yuKlyvuJYLlZmauGgcer2kUOHp6haf0a+UDuzg== X-Google-Smtp-Source: AGHT+IG2PLULGohZC2zhEyPyhsssDVDPmUFkiWqWC4sKmnL2hSqGtPFeo3KokH1Ar5yqyjXkSrx8 X-Received: by 2002:a17:907:7751:b0:a66:9834:dce8 with SMTP id a640c23a62f3a-a6820900b03mr132592166b.37.1717165260899; Fri, 31 May 2024 07:21:00 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1717165260; cv=pass; d=google.com; s=arc-20160816; b=Bj13B+p4DJAkT8860tVB0C4c/11Qv14Tps3G2N7EZFnr9tSA0f+LiPRKq7DKB7BWdQ LOObKX/Klfm7qZ5upnPltgAQ6VZstr9yyRW+fhzyvM/13L/YflwznXRqRcDuGQkcPUKX yY2jRlK1riueoWPBsGe0Ayh3XLKXX5c5Y9tKTf9rQmS+LNaTLEKIw6YdC2KwheCeY9t3 XGobPEUauQ/O0PZKcXOdf/9kcT5WSJ5ov6jNmQ+vNKEmivrjBcag1OH3uenc/H/lm3kl W7V9Sf4KdvXG/psVpD+cPQQ82oEpLQlheO6UPZbn/1VeIweYjfugvEoYSL5+i8OeWn5r +r0Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=Ihs7/+bcBpwVpoiC2uzmLNWs0LtrfpGs5TXuAlBDbOU=; fh=Ns0bpPld5hjywSRyxWZyWGe/pfT5ALTpQzwSvWmir9A=; b=fWWjb5EcwPWfqJ9CG4t+TUyQSYNo49Y0dScUr0uXsAxE4wN9gyuoKYSyo9tZWcO1Gp lZgHTJ9dBBxHV0Pp+UCJWVRxRqv3aNIy/H9nAj5LwUS+z1G1vV6u/u146CV3M4O8C4/U XcL2TtP8HTrXMvpCdMVXk8nAajg7k0OSOc27oSgL63OZgRaJNQYztFT+oWwKVrT9j79/ QwrH9675qYTGv2RJc1w0jItKy5FvBl9f6gQZE6Ri8h6A5Ljm1zdoZM4UK5jtAyI4S5gl PAGnvjjHFlcWmNgbM5XsqGhybE7j6HvTe8QKZWHVXmDT+6/H8oGO2NNX9xWqBiCV8EN4 Mv6A==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=SOlKdpgx; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-196967-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-196967-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id a640c23a62f3a-a67eb72345asi91304866b.972.2024.05.31.07.21.00 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 May 2024 07:21:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-196967-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=SOlKdpgx; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-196967-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-196967-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 9DBC61F2756C for ; Fri, 31 May 2024 14:21:00 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 790EE1B812; Fri, 31 May 2024 14:20:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="SOlKdpgx" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A3140848D; Fri, 31 May 2024 14:20:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717165251; cv=none; b=EZY9Kh33cySxNzhIli/OkKgMtgnLlEDv2Vs1kDkgyXRlrrBPcxFdSTNbqmBAfH/bd9AkI+DAJo0HtoRY9osXYpw0jNnjNREAusKudNvQmUIEl9RJpxZoOYvsIeh15pQ/+3mk91ikbgupQUzHnSYX0GNxBQVXdprBeV365C0fnmQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717165251; c=relaxed/simple; bh=24V3OlbxU0oH/IDoFPcIbXWPFTslHktxEQ/AHEVjUE8=; h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References: Mime-Version:Content-Type; b=co0ZWUxByv1RO9zZ1Q2CTE0G7FCKuHlPTnVc8kODqW7NttXqsA+T7liqOnzUf53JEiNGJvCtR2+rq8c7pg+Z7pXn54Fa+Y4zPxUM+D8se48co9XicmPoB1o+pPDYk6C52yb9LFa0LDbdMi/ES5lDBjhUU4uR/06XoR1x2KvhAD8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=SOlKdpgx; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id B2FCCC116B1; Fri, 31 May 2024 14:20:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1717165251; bh=24V3OlbxU0oH/IDoFPcIbXWPFTslHktxEQ/AHEVjUE8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=SOlKdpgxpSj7lq6hDLoL1tF1g/GGWKh5KA5HAsdir79YDyeQpUSJq0COLrAqFghLF 6MoPfU+3yju32iVlBfjOgRQOtGpYJOV1zx6nohksPpyKgtaGPeAYjt88r6rf2+EMSJ 2TThXzlD1T73ZY+2732EeD/h0DKUkxy5qtnhjUTErGLKZJFox7C4HdgXGtXO7zy1yd usLMt1t8TpyWZgiCdxZfHEy8ogqKASb2WVxzhlrQIoKnSXxw2mjibQsIZTvJOSdelx ZpWthZLdYomTP8lTydUbuJ1R90naklRwfjSI6dtfyMlNJNg6Bmv/jrwk0uZJPG4OyL fXswou4LYx+tw== Date: Fri, 31 May 2024 23:20:47 +0900 From: Masami Hiramatsu (Google) To: Steven Rostedt Cc: Tom Zanussi , LKML , Linux Trace Kernel Subject: Re: [PATCH 0/3] tracing: Fix some selftest issues Message-Id: <20240531232047.fca5712a98e360d4a27fd92c@kernel.org> In-Reply-To: <20240531032425.3635dc93@rorschach.local.home> References: <171671825710.39694.6859036369216249956.stgit@devnote2> <20240527192907.49c9220f@rorschach.local.home> <20240529014640.3a04f7301f12eb44738f9f2d@kernel.org> <20240529083818.b7835de167191d4567405ce6@kernel.org> <3a7e679712fb47b6c75af84163b5d3ea252f4da9.camel@linux.intel.com> <20240531113721.c0314e0cdb3beb70c1a6ba7d@kernel.org> <20240531032425.3635dc93@rorschach.local.home> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 31 May 2024 03:24:25 -0400 Steven Rostedt wrote: > On Fri, 31 May 2024 11:37:21 +0900 > Masami Hiramatsu (Google) wrote: > > > So, in summary, it is designed to be a module. Steve, I think these tests > > should be kept as modules. There are many reason to do so. > > > > - This test is designed to be used as module. > > - This can conflict with other boot time selftest if it is embedded. > > - We can make these tests and boot time selftest mutable exclusive but > > if we make these tests as modules, we can build and run both tests > > safely. > > - Embedding these tests leave new events when the kernel boot, which > > user must be cleaned up by manual. > > > > What would you think? > > I was mostly following what Ingo told me long ago, where having it > built in is just one more way to test it ;-) Ah, would you mean embedding the module is also a part of tests? > > But that said, from your first patch, you show the stack dump and > mention: > > > Since the kprobes and synth event generation tests adds and enable > > generated events in init_module() and delete it in exit_module(), > > if we make it as built-in, those events are left in kernel and cause > > kprobe event self-test failure. > > But you don't explain what exactly the conflict is. What about those > events causes kprobe selftests to fail? The major conflict happens when the boot-time test cleans up the kprobe events by dyn_events_release_all(&trace_kprobe_ops); And I removed it by [3/3] patch in this series :) because it does not needed and not confirmed there is no other kprobe events when the test starts. Also the warning message are redundant so I removed it by [2/3]. So without this [1/3], if we apply [2/3] and [3/3], the problem will be mitigated, but I think the root cause is that these modules are built-in. Thank you, > > > -- Steve -- Masami Hiramatsu (Google)