Received-SPF: pass (google.com: domain of linux-kernel+bounces-197014-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Fri, 31 May 2024 15:53:57 +0100
From: Conor Dooley <conor@kernel.org>
To: Ramona Alexandra Nechita <ramona.nechita@analog.com>
Cc: linux-iio@vger.kernel.org, Jonathan Cameron <jic23@kernel.org>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Michael Hennerich <Michael.Hennerich@analog.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH v3 1/1] dt-bindings: iio: adc: add a7779 doc
Message-ID: <20240531-relocate-sassy-fd31e418845b@spud>
References: <20240531133604.1380-1-ramona.nechita@analog.com>
 <20240531133604.1380-2-ramona.nechita@analog.com>
 <20240531-dairy-king-5a4e6c09b670@spud>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="3hx+xfsV8K1ufwsd"
Content-Disposition: inline
In-Reply-To: <20240531-dairy-king-5a4e6c09b670@spud>


--3hx+xfsV8K1ufwsd
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, May 31, 2024 at 03:51:56PM +0100, Conor Dooley wrote:
> On Fri, May 31, 2024 at 04:35:52PM +0300, Ramona Alexandra Nechita wrote:
> > Add dt bindings for adc ad7779.
> >=20
> > Signed-off-by: Ramona Alexandra Nechita <ramona.nechita@analog.com>
> > ---
> >  .../ABI/testing/sysfs-bus-iio-adc-ad777x      | 23 +++++
> >  .../bindings/iio/adc/adi,ad7779.yaml          | 87 +++++++++++++++++++
> >  2 files changed, 110 insertions(+)
> >  create mode 100644 Documentation/ABI/testing/sysfs-bus-iio-adc-ad777x
> >  create mode 100644 Documentation/devicetree/bindings/iio/adc/adi,ad777=
9.yaml
> >=20
> > diff --git a/Documentation/ABI/testing/sysfs-bus-iio-adc-ad777x b/Docum=
entation/ABI/testing/sysfs-bus-iio-adc-ad777x
> > new file mode 100644
> > index 000000000000..0a57fda598e6
> > --- /dev/null
> > +++ b/Documentation/ABI/testing/sysfs-bus-iio-adc-ad777x
> > @@ -0,0 +1,23 @@
> > +What:		/sys/bus/iio/devices/iio:deviceX/filter_type_available
> > +KernelVersion:  6.1
> > +Contact:	linux-iio@vger.kernel.org
> > +Description:
> > +		Reading returns a list with the possible filter modes. Only supporte=
d by
> > +		AD7771.
> > +
> > +		  * "sinc3"	- The digital sinc3 filter implements three main notches=
, one at
> > +				the maximum ODR (128 kHz or 32 kHz, depending on the
> > +				power mode) and another two at the ODR frequency selected to
> > +				stop noise aliasing into the pass band.
> > +
> > +		  * "sinc5"	- The sinc5 filter implements five notches, one at
> > +				the maximum ODR (128 kHz or 32 kHz, depending on the
> > +				power mode) and another four at the ODR frequency
> > +				selected to stop noise aliasing into the pass band.
> > +
> > +What:		/sys/bus/iio/devices/iio:deviceX/filter_type
> > +KernelVersion:  6.1
> > +Contact:	linux-iio@vger.kernel.org
> > +Description:
> > +		Set the filter mode of the differential channel. The current samplin=
g_frequency
> > +		is set according to the filter range. Only supported by AD7771.
>=20
> This patch is really confusing to me. Why is there a file documenting
> the sysfs interface for a driver that isn't in the tree? Shouldn't this
> patch be part of a series that adds the driver? I suggest you speak to
> Nuno or another collogue about how to submit a series.

Colleague*, auto accepting vim's first spelling suggestion strikes again
:)

--3hx+xfsV8K1ufwsd
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZlnkhQAKCRB4tDGHoIJi
0nXXAP966lZ8z3VVf9rnxuQw1i1VXpZKPKxSQiG466XA5dsYqAD+I8LN4L4lVZig
X0B+rTyY5jhEO206qTbesfcpsvoivQ4=
=D6pP
-----END PGP SIGNATURE-----

--3hx+xfsV8K1ufwsd--