Received: by 2002:a05:6500:2018:b0:1fb:9675:f89d with SMTP id t24csp510813lqh; Fri, 31 May 2024 08:05:48 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVmWnafEPS+aT3Uguf4IsybYxxE1JxeHWgL3O8ayoFOaaKInpgoPqpQ6RwjV3+2CR15znHb4LGvvmeVKoGDNH76N5KWi5A/5piDllwEmg== X-Google-Smtp-Source: AGHT+IHdpHHn4WXpv7YX1KgAoZa6+mQFLC7X6A2GNpUSnYE3r+5FH2feCNRy7f5HmjbZhK9u1ejK X-Received: by 2002:a17:902:db02:b0:1f3:2f9c:bb72 with SMTP id d9443c01a7336-1f635993534mr34216515ad.5.1717167947830; Fri, 31 May 2024 08:05:47 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1717167947; cv=pass; d=google.com; s=arc-20160816; b=gdjXi2XdYb/tUFeDNDPvmbS2KYzxKMt9PWBH522OcEs0/wB8UJp8/sYhjEa6hZKevh qvyWNssVemPipOBULBwJv7A3nXEbOcQNS/TDS8BuI2m9SPN+cz1HwwGofXUdynd89DyS tG3ZCNczrakW+WzL4zacW6kHJUVjF/10FPrDsx8JWA/jUnlfraOrZ/FrlN7xnJxWFwI8 UWx1HNeW07GP4zsVOPTUeJ9vvJTITH7vPZXM7IygGTLVMqPjJLIrnWiFmfhNpwTVvLI7 7PK7OAh2Cv3EPPGtWeVIezc22Mha2mBGx5G4YZK8nV8JiDCd7louxOb2Ae8ieog6v1tY fAwQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:subject :references:in-reply-to:cc:to:from:dkim-signature; bh=5O3lWLlzOGPGg0VNCIn+neGZ60MJIlY0Ig5X8MlxrGk=; fh=vnzeg3HUaXAPxPXdmlVXKfjXlr/QExfq5+rTqExqH1E=; b=IUibNNf0mV1YT6EihSA7Hz4pmrIRrkSVHHey9WAWJYOgiNzkWByLcO+TSu7MPrxmZx daMPHRrIf2cx4z9Z7XffnlqXuFXZZpMOTuctB/vihQg1jbJpFRrd2+W6L2H2DGkWBCaJ aJ1dUvISLeybka2A/PqV+eH7TGj0ltm696iSM31YP/5msVveN5sPKVSllK1FMGjhhn3G d9SHqbOZk2UFIVUbJ63+p4Z/Ec3wTKi0lk+10n+Vsn2IDr0fhW48GJqTxvek6mxdwPYC LUOCexZAuMfDsSq3sBm3lvmKAAQ8hDoUmiuNRQPtn7Ub//R7EY7nTNI5UTL/Vtsqn+C7 hNaQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=FDKF8ibz; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-197026-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-197026-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id d9443c01a7336-1f63240155asi17792525ad.451.2024.05.31.08.05.47 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 May 2024 08:05:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-197026-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=FDKF8ibz; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-197026-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-197026-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 5889D28E5FC for ; Fri, 31 May 2024 15:05:47 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id CB84A7406C; Fri, 31 May 2024 15:05:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="FDKF8ibz" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EFA5E7483; Fri, 31 May 2024 15:05:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717167939; cv=none; b=XQ61WCNaCKpWdeaGR9/y/yFtTFczRUV6krZwujh95KBSzdURnsOc0Zx4UXEtHdf2e53AnE+8uiTUSvoYGoncN6kuZtsSpmZKozRN3xA9Ilf6TNLmGsBZji8ZyyJyk7Jar7V9xzwoXBDm+WA+6oOZkp2yMyVeff5co52zzQVgOGg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717167939; c=relaxed/simple; bh=V4IL9FSiAAaLAbgQkaH0wiehW1wHmmkNYh1G0Mg9i/U=; h=From:To:Cc:In-Reply-To:References:Subject:Message-Id:Date: MIME-Version:Content-Type; b=CWcF/jN8aN9GIViM9MH/yJvPuPqFXcKxtRcRiZs8tF1iYA/sq4mofuf5ntdU+cwtX01JxVxyaE5PTmJNQiFNwrwXmUYhJhnGSCDvutmiaS4Bw7n09AhXCRGWFE5u3w838HiBzciwZzNOwTGK8XkLDlcChWocrQCtqSMizAMAvbY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=FDKF8ibz; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id C7FB5C116B1; Fri, 31 May 2024 15:05:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1717167938; bh=V4IL9FSiAAaLAbgQkaH0wiehW1wHmmkNYh1G0Mg9i/U=; h=From:To:Cc:In-Reply-To:References:Subject:Date:From; b=FDKF8ibzRSbpSFndvIT0WdMV2FWGLP7O+n6psQ4tzFDDZ981mSapldkAF0l85vKwc r3FSfVhUbjS9Tt8cVSFTGbPLd2Y9Jco7o1z4ZQrDSV6lBz/m7KsLwTOUW1urzW/9pw qeX2rUIps6B8eG6IL7SnoxON0XeUodaY0h3kCL1WLknvRqj5eSN6BtsmjTRZX/Whqw HoDqHAE1/4dx9C53QWXpp7Pv7HpZwWwRtbd384kcC5OKsbK+FQ/6zCumWblMS2b6uO skiZqpOzdKucUb8Sa6klbupI+XoaPY/lsC8UPqREObXg2F7k5fsMzWIk2wM86x8l4T ENYrB6qrir6Gg== From: Lee Jones To: Pavel Machek , Lee Jones , Dave Hansen , Richard Purdie , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, =?utf-8?q?Ilpo_J=C3=A4rvinen?= Cc: stable@vger.kernel.org In-Reply-To: <20240527132700.14260-1-ilpo.jarvinen@linux.intel.com> References: <20240527132700.14260-1-ilpo.jarvinen@linux.intel.com> Subject: Re: (subset) [PATCH 1/1] leds: ss4200: Convert PCIBIOS_* return codes to errnos Message-Id: <171716793655.1148553.64082330680622077.b4-ty@kernel.org> Date: Fri, 31 May 2024 16:05:36 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Mailer: b4 0.12.4 On Mon, 27 May 2024 16:27:00 +0300, Ilpo Järvinen wrote: > ich7_lpc_probe() uses pci_read_config_dword() that returns PCIBIOS_* > codes. The error handling code assumes incorrectly it's a normal errno > and checks for < 0. The return code is returned from the probe function > as is but probe functions should return normal errnos. > > Remove < 0 from the check and convert PCIBIOS_* returns code using > pcibios_err_to_errno() into normal errno before returning it. > > [...] Applied, thanks! [1/1] leds: ss4200: Convert PCIBIOS_* return codes to errnos commit: c1f69631a8f438997621c9ff322452b744525048 -- Lee Jones [李琼斯]