Received-SPF: pass (google.com: domain of linux-kernel+bounces-197040-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <d3969a10-7cd2-3dfb-2e49-37ebad2d6440@gmail.com>
Date: Fri, 31 May 2024 17:10:08 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Subject: Re: [PATCH 02/14] x86/alternatives: Add nested alternatives macros
To: Borislav Petkov <bp@alien8.de>
Cc: Borislav Petkov <bp@kernel.org>, X86 ML <x86@kernel.org>,
 LKML <linux-kernel@vger.kernel.org>, Peter Zijlstra <peterz@infradead.org>
References: <20240531123512.21427-1-bp@kernel.org>
 <20240531123512.21427-3-bp@kernel.org>
 <3a86f790-3194-4ea0-de8d-0af231ec7525@gmail.com>
 <20240531143625.GHZlngaQfx6CiJlujI@fat_crate.local>
Content-Language: en-US
From: Uros Bizjak <ubizjak@gmail.com>
In-Reply-To: <20240531143625.GHZlngaQfx6CiJlujI@fat_crate.local>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit


Borislav Petkov je 31. 05. 24 ob 16:36 napisal:
> On Fri, May 31, 2024 at 04:30:31PM +0200, Uros Bizjak wrote:
>> Please don't resurrect the %P modifier, use %c instead.
> 
> Btw, out of curiosity, is %P being phased out?

No ;)

> I'm looking at
> 
> 41cd2e1ee96e ("x86/asm: Use %c/%n instead of %P operand modifier in asm templates")
> 
> and yeah, %c is the generic one while %P is the x86-specific one but
> phasing latter out is probably going to take a bunch of gcc releases...

The intention of '%P' operand modifier is primarily to be used with PIC, 
where:

'P'        If used for a function, print the PLT
            suffix and generate PIC code.  For
            example, emit 'foo@PLT' instead of 'foo'
            for the function foo().  If used for a
            constant, drop all syntax-specific
            prefixes and issue the bare constant.  See
            'p' above.

the fact that is handles constants is due to historic reasons.

The '%c' operand modifier will also check its operand that it is indeed 
an immediate integer operand, so should be used with 'i' operand constraint:

'c'        Require a constant operand and print the
            constant expression with no punctuation.

Uros.