Received: by 2002:a05:6500:2018:b0:1fb:9675:f89d with SMTP id t24csp523009lqh; Fri, 31 May 2024 08:22:09 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWBYeAF3LVJs7K97CijddAKNwDvbMQTOlHmY+4S/3lTG5kae/91sY3xBfksyLG7u28mxrRiDnJxaqaLLuNYgKzCOqHRJGnXEiXmqARnww== X-Google-Smtp-Source: AGHT+IFoXKfzAD+NgD800Y2onRQXEtFKQweO5/vEN/wwXMn40FhpOf+aLScPzFHChllCqLkW13Is X-Received: by 2002:a17:90b:fc4:b0:2bd:d2f9:c22a with SMTP id 98e67ed59e1d1-2c1dc59b6aemr1996916a91.29.1717168929476; Fri, 31 May 2024 08:22:09 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1717168929; cv=pass; d=google.com; s=arc-20160816; b=PnQvPshJ6k/OJndE1AaOcQ3fXGVoKEIGZW9RZlViTV8TEkcYgZdkTaqjQmLp1vQyCw nWYJNQt/N8ClVVXAoP95rWf+ZEVPRZwAnAtzgGlEAwKzlrh5bOuBnYDQpFgeIdNRrjbI ZPO/vHJUWfmZIxQaZS8cy2RzkxDUY6S68SDeLqB3ddUevvFVCloSH2eki0QB+PfAsvyf zXNRN1EVEft1Eqes4HGx/LB9+tX0Z63cPkalgzpWHs1g2n1qhecQ3CHQKnTFDXC+2kFU X3ksQvB5MiJF4eHJr2Zc5QtDN6jWnplcLe9ewbdSzF0r4AzhsTlMTWvqU+7+HHAbLFxJ d2Zw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=qUsSAY8N7AKSenNGLa8xZV3wN1+8yO51gSj1XEWRIaQ=; fh=EelKNb4C4N/Kh+Qnxp5AWU4KZJWkttCqVVez9a39kjc=; b=R51DHTzyYqBN80ulxObZj2j3tWfCLskdhBNxVLHBZN7Io1rc8sjm4NnWPhLNaNQYpp Z+F4fHS8aymQzAtsagF2YfT+1J3CgTLBQvAIVy67OClJlJ1teGYpi6TZxwn7mHGhsM4K fZY7UvJ6taUGpOOavqfg41SdFlc/zQs7AtZI8HLk6z57llw84dfkoTUXpFPnuIn9XCTD ghySulyeqP3HIr/WYB+Rzf8NLvElHrmrPfcbOz+9Zr3/Fb1tIhSf8ihgFy9H5LY6gc0J nuD4qoH7Efu02XNC+g/l6zLRgbZJUevF3SjY3atjcDf5sqsXmuk5Uyeb4T+nGkgXLW+P Rf/A==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@cirrus.com header.s=PODMain02222019 header.b=CLZcLiF3; arc=pass (i=1 spf=pass spfdomain=opensource.cirrus.com dkim=pass dkdomain=cirrus.com dmarc=pass fromdomain=opensource.cirrus.com); spf=pass (google.com: domain of linux-kernel+bounces-197055-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-197055-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=cirrus.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id 98e67ed59e1d1-2c1c282ad70si1766015a91.108.2024.05.31.08.22.09 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 May 2024 08:22:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-197055-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@cirrus.com header.s=PODMain02222019 header.b=CLZcLiF3; arc=pass (i=1 spf=pass spfdomain=opensource.cirrus.com dkim=pass dkdomain=cirrus.com dmarc=pass fromdomain=opensource.cirrus.com); spf=pass (google.com: domain of linux-kernel+bounces-197055-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-197055-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=cirrus.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 55B18282B75 for ; Fri, 31 May 2024 15:16:06 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 2F6AF15CD55; Fri, 31 May 2024 15:15:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b="CLZcLiF3" Received: from mx0b-001ae601.pphosted.com (mx0b-001ae601.pphosted.com [67.231.152.168]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1842479B7E; Fri, 31 May 2024 15:15:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=67.231.152.168 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717168532; cv=none; b=DWoHd6YIoUaUSg22g4eDtvR9/J86/TTmPZag/HLOhqlNfrfc0f5ledJ5d2Db1ubBYDKu9Wn6RWe/a89dMuvhEnw53y7NlLV55zIO2S9U2dWuoQxdnbgBVyGFXM/7FX2eP99x/jyy/GUKBrmmDNouCbxY3E15kI/tn5GXRO3Ca04= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717168532; c=relaxed/simple; bh=e+bL2RoRUJlaWlprGpWktgCZQsKmm2hk0ARDnnJF7nM=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ICrbVfFa8tSkLlvRFgInNCqfEuT9GEn96msOBWqG0WexgRmStV2s3XUgYyPfJpjYmKRfpIe0JHIR+hDGJoIfHGeAwokZ6aJ6NrDZuzahfDO0b0nGh9VezwdUDZFAeLKDaPdZOYlvqttNGV51hExFiD1lC1UxNh8rD78qbt/IPG0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com; spf=pass smtp.mailfrom=opensource.cirrus.com; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b=CLZcLiF3; arc=none smtp.client-ip=67.231.152.168 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=opensource.cirrus.com Received: from pps.filterd (m0077474.ppops.net [127.0.0.1]) by mx0b-001ae601.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 44VB0WSq017940; Fri, 31 May 2024 10:15:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= PODMain02222019; bh=qUsSAY8N7AKSenNGLa8xZV3wN1+8yO51gSj1XEWRIaQ=; b= CLZcLiF3fZZsVHXhgFHJEslpe79acK49wAoZBxqvkL6cHilbPZ7Sx9y8kLiQqaTU JrDmbfSmcTr2DtnPPoVQTv5aznA2zLqyy5NSXJUpax6qj3xZbSB5gaBN0JJKY0Rh 10ESmzp9exw7Be8QgHLrIn5z9fLnlC1rRLOIsapbn+JbcCtxy6eV51q5HAQbmBOM 4VnHkrUHz2pkGXfsyeq5m91pp+uixsAMBcYHPMmZ0n2zK76MSJIe+N6YArOooZiz NAEgv6hpv8QlVopHGlPg5UqcCijLEm8I6aCp4u+kmzkl1NFUuxtGzU9AZoSdUQKw xgphlkPrlK3yJP1fapmMNA== Received: from ediex01.ad.cirrus.com ([84.19.233.68]) by mx0b-001ae601.pphosted.com (PPS) with ESMTPS id 3ybcdhe0a3-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 31 May 2024 10:15:12 -0500 (CDT) Received: from ediex02.ad.cirrus.com (198.61.84.81) by ediex01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Fri, 31 May 2024 16:15:10 +0100 Received: from ediswmail9.ad.cirrus.com (198.61.86.93) by anon-ediex02.ad.cirrus.com (198.61.84.81) with Microsoft SMTP Server id 15.2.1544.9 via Frontend Transport; Fri, 31 May 2024 16:15:10 +0100 Received: from EDIN6ZZ2FY3.ad.cirrus.com (EDIN6ZZ2FY3.ad.cirrus.com [198.61.65.72]) by ediswmail9.ad.cirrus.com (Postfix) with ESMTP id AE85982024B; Fri, 31 May 2024 15:15:09 +0000 (UTC) From: Simon Trimmer To: CC: , , , , , , , , , Simon Trimmer Subject: [PATCH 1/7] ALSA: hda: cs35l56: Component should be unbound before deconstruction Date: Fri, 31 May 2024 16:14:03 +0100 Message-ID: <20240531151409.80284-2-simont@opensource.cirrus.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240531151409.80284-1-simont@opensource.cirrus.com> References: <20240531151409.80284-1-simont@opensource.cirrus.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Proofpoint-GUID: b3wft8Zp-wn9IqPAuSloKUX1mfEWAe5b X-Proofpoint-ORIG-GUID: b3wft8Zp-wn9IqPAuSloKUX1mfEWAe5b X-Proofpoint-Spam-Reason: safe The interface associated with the hda_component should be deactivated before the driver is deconstructed during removal. Signed-off-by: Simon Trimmer --- sound/pci/hda/cs35l56_hda.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/pci/hda/cs35l56_hda.c b/sound/pci/hda/cs35l56_hda.c index 0923e2589f5f..e134ede6c5aa 100644 --- a/sound/pci/hda/cs35l56_hda.c +++ b/sound/pci/hda/cs35l56_hda.c @@ -1077,12 +1077,12 @@ void cs35l56_hda_remove(struct device *dev) { struct cs35l56_hda *cs35l56 = dev_get_drvdata(dev); + component_del(cs35l56->base.dev, &cs35l56_hda_comp_ops); + pm_runtime_dont_use_autosuspend(cs35l56->base.dev); pm_runtime_get_sync(cs35l56->base.dev); pm_runtime_disable(cs35l56->base.dev); - component_del(cs35l56->base.dev, &cs35l56_hda_comp_ops); - cs_dsp_remove(&cs35l56->cs_dsp); kfree(cs35l56->system_name); -- 2.34.1