Received-SPF: pass (google.com: domain of linux-kernel+bounces-197080-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Fri, 31 May 2024 16:35:30 +0100
From: Lee Jones <lee@kernel.org>
To: Thomas =?iso-8859-1?Q?Wei=DFschuh?= <linux@weissschuh.net>
Cc: Benson Leung <bleung@chromium.org>, Guenter Roeck <groeck@chromium.org>,
	Tzung-Bi Shih <tzungbi@kernel.org>, Pavel Machek <pavel@ucw.cz>,
	chrome-platform@lists.linux.dev, linux-kernel@vger.kernel.org,
	Dustin Howett <dustin@howett.net>,
	Mario Limonciello <mario.limonciello@amd.com>,
	linux-leds@vger.kernel.org,
	Rajas Paranjpe <paranjperajas@gmail.com>
Subject: Re: [PATCH v3 0/4] cros_kbd_led_backlight: allow binding through
 cros_ec mfd device
Message-ID: <20240531153530.GP1005600@google.com>
References: <20240526-cros_ec-kbd-led-framework-v3-0-ee577415a521@weissschuh.net>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20240526-cros_ec-kbd-led-framework-v3-0-ee577415a521@weissschuh.net>

On Sun, 26 May 2024, Thomas Weißschuh wrote:

> Extend the cros_ec MFD device to also load cros_kbd_led_backlight
> when the EC reports EC_FEATURE_PWM_KEYB.
> As the driver can now be probed multiple times, some preparation in the
> LED core is necessary to avoid name collisions.
> 
> Patch 1 is a general cleanup for the LED core.
> Patch 2 modifies the LED core to skip the default collision handling.
> Patch 3 adds the new probing logic to cros_kbd_led_backlight.
> Patch 4 wires up the driver to the cros_ec mfd devices.
> 
> The helper keyboard_led_is_mfd_device is a bit iffy.
> But using match data doesn't work.
> 
> * driver_data from platform_device_id is overwritten by the mfd platform data
> * Setting the driver_data in drivers/mfd/cros_ec_dev.c would expose the
> internals of cros_kbd_led_backlight
> 
> Tested on a Framework 13 AMD, Firmware 3.05, and a Jinlon Chromebook.
> 
> To: Lee Jones <lee@kernel.org>
> To: Benson Leung <bleung@chromium.org>
> To: Guenter Roeck <groeck@chromium.org>
> To: Tzung-Bi Shih <tzungbi@kernel.org>
> To: Pavel Machek <pavel@ucw.cz>
> Cc: chrome-platform@lists.linux.dev
> Cc: linux-kernel@vger.kernel.org
> Cc: Dustin Howett <dustin@howett.net>
> Cc: Mario Limonciello <mario.limonciello@amd.com>
> Cc: linux-leds@vger.kernel.org
> Cc: Rajas Paranjpe <paranjperajas@gmail.com>
> Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
> 
> Changes in v3:
> - Avoid probing multiple times (Confirmed by Rajas)
> - Add Kconfig dependency on MFD_CROS_EC_DEV
> - Link to v2: https://lore.kernel.org/r/20240511-cros_ec-kbd-led-framework-v2-0-b20c48109e46@weissschuh.net
> 
> Changes in v2:
> - Fix build with CONFIG_MFD_CROS_EC_DEV=n (kernel test robot)
> - Split out mfd registration into own commit (Lee)
> - Simplify keyboard_led_is_mfd_device() with mfd_get_cell()
> - Link to v1: https://lore.kernel.org/r/20240505-cros_ec-kbd-led-framework-v1-1-bfcca69013d2@weissschuh.net
> 
> ---
> Thomas Weißschuh (4):
>       leds: class: warn about name collisions earlier
>       leds: add flag to avoid automatic renaming of led devices
>       platform/chrome: cros_kbd_led_backlight: allow binding through mfd device
>       mfd: cros_ec: Register keyboard backlight subdevice
> 
>  drivers/leds/led-class.c                         |  9 +++---
>  drivers/mfd/cros_ec_dev.c                        |  9 ++++++
>  drivers/platform/chrome/Kconfig                  |  2 +-
>  drivers/platform/chrome/cros_kbd_led_backlight.c | 40 ++++++++++++++++++++++--
>  include/linux/leds.h                             |  1 +
>  5 files changed, 54 insertions(+), 7 deletions(-)

Looks okay.

Does the platform patch need to be applied with the others?

-- 
Lee Jones [李琼斯]