Received-SPF: pass (google.com: domain of linux-kernel+bounces-197091-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Precedence: bulk
MIME-Version: 1.0
References: <20240531094658.1598969-1-andy.shevchenko@gmail.com> <1ea41944-a107-4528-8e8d-559c06907e3f@notapiano>
In-Reply-To: <1ea41944-a107-4528-8e8d-559c06907e3f@notapiano>
From: Andy Shevchenko <andy.shevchenko@gmail.com>
Date: Fri, 31 May 2024 18:46:20 +0300
Message-ID: <CAHp75VeG9K3Ar4UJnGxus3zz_vtt4QfFdkYQ8=6D8pt2aB8kmA@mail.gmail.com>
Subject: Re: [PATCH v1 0/2] spi: Make dummy SG handling robust
To: =?UTF-8?B?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= <nfraprado@collabora.com>
Cc: Mark Brown <broonie@kernel.org>, linux-spi@vger.kernel.org, 
	linux-kernel@vger.kernel.org, Neil Armstrong <neil.armstrong@linaro.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, May 31, 2024 at 5:37=E2=80=AFPM N=C3=ADcolas F. R. A. Prado
<nfraprado@collabora.com> wrote:
> On Fri, May 31, 2024 at 12:44:31PM +0300, Andy Shevchenko wrote:
> > There's an unreliable code to handle DMA mappings on unidirection trans=
fers.
> > This series does two things:
> > - it reverts the seemingly unnecessary change
> > - it reworks dummy SG list handling
> >
> > There is no need to backport that AFAIU, but no harm to apply for v6.10=
 aka
> > the current release cycle. Guys, please test these.
> >
> > Andy Shevchenko (2):
> >   spi: Revert "Check if transfer is mapped before calling DMA sync APIs=
"
> >   spi: Do not rely on the SG table and respective API implementations

> Hi Andy,
>
> applying either of these patches causes issues. See the traces for each o=
ne
> below. This was tested on top of next-20240531, which works fine.

Oh, thank you very much for prompt testing! Can you test just the
second one without the revert?

So, your patch seems needed for the sync API calls, while I considered
only mapping APIs.

--=20
With Best Regards,
Andy Shevchenko