Received-SPF: pass (google.com: domain of linux-kernel+bounces-196758-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Fri, 31 May 2024 13:17:03 +0100
From: Matthew Wilcox <willy@infradead.org>
To: Dev Jain <dev.jain@arm.com>
Cc: zhouchengming@bytedance.com, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org, Anshuman.Khandual@arm.com
Subject: Re: [QUESTION] mm: Redundant const parameter?
Message-ID: <Zlm_vlhYa91fA1wu@casper.infradead.org>
References: <e5f01ffe-de51-4079-a87f-2886788422f9@arm.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <e5f01ffe-de51-4079-a87f-2886788422f9@arm.com>

On Fri, May 31, 2024 at 04:42:59PM +0530, Dev Jain wrote:
> Hi Chengming,
> 
> In mm/slub.c, you had defined slab_test_node_partial() to take a const
> parameter.
> 
> Is there any point of taking in a const, when you are anyways typecasting it
> to
> 
> a (struct folio *) from (const struct folio *) ? In fact, at the place where
> you call
> 
> slab_test_node_partial(), the struct slab *slab is not const.

I have a patch to fix this; hang on a second ...