Received-SPF: pass (google.com: domain of linux-kernel+bounces-197187-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <e2ff917300939bb017b8f587a66a93022f3d1eeb.camel@linux.intel.com>
Subject: Re: [PATCH v2 3/6] platform/x86/intel: TPMI domain id and CPU
 mapping
From: Tero Kristo <tero.kristo@linux.intel.com>
To: Ilpo =?ISO-8859-1?Q?J=E4rvinen?= <ilpo.jarvinen@linux.intel.com>
Cc: srinivas.pandruvada@linux.intel.com, Hans de Goede
 <hdegoede@redhat.com>,  platform-driver-x86@vger.kernel.org, LKML
 <linux-kernel@vger.kernel.org>,  Andy Shevchenko
 <andriy.shevchenko@linux.intel.com>
Date: Fri, 31 May 2024 19:47:08 +0300
In-Reply-To: <e56885a4-3344-b9f9-92d5-33c9af00636d@linux.intel.com>
References: <8646d7dbeb507ce28b6ddca1222ee3c9892d61cc.camel@linux.intel.com>
	 <20240528073457.497816-1-tero.kristo@linux.intel.com>
	 <e56885a4-3344-b9f9-92d5-33c9af00636d@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.52.0-1build2 
Precedence: bulk
MIME-Version: 1.0

On Fri, 2024-05-31 at 16:45 +0300, Ilpo J=C3=A4rvinen wrote:
> On Tue, 28 May 2024, Tero Kristo wrote:
>=20
> > From: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> >=20
> > Each TPMI power domain includes a group of CPUs. Several power
> > management settings in this case applicable to a group of CPUs.
> > There can be several power domains in a CPU package. So, provide
> > interfaces for:
> > - Get power domain id for a Linux CPU
> > - Get mask of Linux CPUs in a power domain
> >=20
> > Hardware Punit uses different CPU numbering, which is not based on
> > APIC (Advanced Programmable Interrupt Controller) CPU numbering.
> > The Linux CPU numbering is based on APIC CPU numbering. Some PM
> > features
> > like Intel Speed Select, the CPU core mask provided by the hardware
> > is
> > based on the Punit CPU numbering. To use the core mask, this mask
> > needs to be converted to a Linux CPUs mask. So, provide interfaces
> > for:
> > - Convert to a Linux CPU number from a Punit CPU number
> > - Convert to a Punit CPU number from a Linux CPU number
> >=20
> > On each CPU online, MSR 0x54 is used to read the mapping and stores
> > in
> > a per cpu array. Create a hash for faster searching of a Linux CPU
> > number
> > from a Punit CPU number.
> >=20
> > Signed-off-by: Srinivas Pandruvada
> > <srinivas.pandruvada@linux.intel.com>
> > [tero.kristo: minor updates]
> > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > Reviewed-by: Ilpo J=C3=A4rvinen <ilpo.jarvinen@linux.intel.com>
> > Signed-off-by: Tero Kristo <tero.kristo@linux.intel.com>
> > ---
> > v2:
> > =C2=A0 * changed to use X86_MATCH_VFM() instead of
> > X86_MATCH_INTEL_FAM6_MODEL()
>=20
> I've applied this v2 + the other patches from v1 series now to
> review-ilpo=20
> branch.
>=20
> For the record, I removed "All rights reserved." lines from the
> patches=20
> while applying. I asking first (privately) a permission from Tero
> whether=20
> it's okay with him I remove those lines.
>=20

Thanks Ilpo!

-Tero