Received-SPF: pass (google.com: domain of linux-kernel+bounces-197135-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <e2e3df20-13b2-4883-8d0a-bd561ac43bc3@oracle.com>
Date: Fri, 31 May 2024 09:18:13 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v9 06/19] x86: Add early SHA-1 support for Secure Launch
 early measurements
To: Eric Biggers <ebiggers@kernel.org>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org,
        linux-integrity@vger.kernel.org, linux-doc@vger.kernel.org,
        linux-crypto@vger.kernel.org, kexec@lists.infradead.org,
        linux-efi@vger.kernel.org, iommu@lists.linux-foundation.org,
        dpsmith@apertussolutions.com, tglx@linutronix.de, mingo@redhat.com,
        bp@alien8.de, hpa@zytor.com, dave.hansen@linux.intel.com,
        ardb@kernel.org, mjg59@srcf.ucam.org,
        James.Bottomley@hansenpartnership.com, peterhuewe@gmx.de,
        jarkko@kernel.org, jgg@ziepe.ca, luto@amacapital.net,
        nivedita@alum.mit.edu, herbert@gondor.apana.org.au,
        davem@davemloft.net, corbet@lwn.net, ebiederm@xmission.com,
        dwmw2@infradead.org, baolu.lu@linux.intel.com,
        kanth.ghatraju@oracle.com, andrew.cooper3@citrix.com,
        trenchboot-devel@googlegroups.com
References: <20240531010331.134441-1-ross.philipson@oracle.com>
 <20240531010331.134441-7-ross.philipson@oracle.com>
 <20240531021656.GA1502@sol.localdomain>
Content-Language: en-US
From: ross.philipson@oracle.com
In-Reply-To: <20240531021656.GA1502@sol.localdomain>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?K3JIWDlqV2s2N2Q3eEVkNEppOU1YYUY3OEVUQmFDRmsrdnZzWlpUNnVTY244?=
 =?utf-8?B?NGVKc2h6Ym9DTWk5ZXRURlFKekUvR1dpeEpSb21VNXBHaVE0TjNMWGpjeG5P?=
 =?utf-8?B?cGpxWHIrVko0WDd3TUNnRjVGZHIxaUpLMHJ4cXBZTjBwUjlld2JQN3NMdnNJ?=
 =?utf-8?B?SkFtK1dVZ2pnRnlBaERnNy8xRW5MVC9xdXNUVUtWd0oxaGVaOExLOVRSMXNl?=
 =?utf-8?B?ckRpUnJydk05Rnp2WS85bUgxYmRiSXBIYzZkT1FLaTRuc1psSEQ4bGtkME9u?=
 =?utf-8?B?alRtRjVvM1dpcnNpa2dhTjFndWMwc2tTK28zdDFLNGhLMk8yT211SGhYTS9S?=
 =?utf-8?B?dTBFMjZsZG5ad0RSNDZVb0Z5RGNWV3hNSW81eXNKRGY5STAydGlTcGU3dUp3?=
 =?utf-8?B?amkwbno4Tlp0eXFNRGJkK0pRczhXVGFxMG1pL2tRK1FpdGtFaWhka3dQc0Rw?=
 =?utf-8?B?Q2NSK3d1K3gzUlRLa2tnWFd5UWdCL2xsRTVwS1dydEsvYzgzYTZ1Yi95OFpY?=
 =?utf-8?B?UEhCNkdmZGRkK2F5bXpFRkg5cHNrQnNDbURZdXRmZG9yMktOYXFqNjFUV0Va?=
 =?utf-8?B?MVRqamZuYTRpQlV3WnVmbzFFQ042NkZ3YkY1bnl6dExPU0twUWNhOEtURUUx?=
 =?utf-8?B?VTdyb0tsSjN4Q1dFN3ZVWTNjR05sc1NTbUhibFg1bUlZcURDdWdKd2FoUnc3?=
 =?utf-8?B?TzZFM2dpcUQyeGlYZzF4SFZIakxBM042Wi9CTmhFNkhMSGNtaWUrZnk0Skoy?=
 =?utf-8?B?Z3g4YkN2Nno3cVFkbDg4YXZBYjZ3UTVOa1dEQXFBZlhNQThlQkE4Qmgyck54?=
 =?utf-8?B?NlQyWVBJMWZOakRlRUFRWnZsOUEvSmNBSmxhVWl6dHQ2YmQyWFhsSll2ZEhO?=
 =?utf-8?B?dGFieWFoa0diRnBncFR2U3ljSTkzTzZsZHRyNG5EaFFLY0YvbE9sN0ladlhJ?=
 =?utf-8?B?cFZicUxicnl4Q1A0dDBGVTFoQllwUEFQSFkwNFBQUVJ4Ui90UEhFaHFPTXZS?=
 =?utf-8?B?aHBTQXk0aExTaG55VVlldE5JN3lqb1NFTGRDbnUrQ0grNWU5cWFxMXJ6VVJq?=
 =?utf-8?B?UXV0RkJXZFlNazJKbVZxQWNFbXdrTnkvU3hrMVdsbU9oOWFSTnU3N1NGaE9H?=
 =?utf-8?B?c1EyRFJGRks5Zm5SeURjT2pJczBJS3V4Mkd2MFJwOFJiTkoxYVNiYTNLcnlG?=
 =?utf-8?B?a3FvMlBTSjJ2RXZWaDcwN1ppS05UZ3JLTjNBWGo2M0s4bldaRnhQSDh5N0p0?=
 =?utf-8?B?WGZ0M2tYYzVZTmI4aDdWYnU3WWVEb0RGdWVnVU45Mmcyc25oYkNUOU4zcHRv?=
 =?utf-8?B?VlE1OWRSakNlcW1JbDNLV29DczJyYmZMZnM3R0dIb2JaV08vZXh6RENEbURO?=
 =?utf-8?B?VmRvd2Z3dzlCeWUraG9kVW9lUTJDT1JHckdTYzBHSWZIRWgrblh3OGRsRmxh?=
 =?utf-8?B?akFDTFRqbWhYWFovdWZIVzJ2eGFOMVlRUGhPQmpFaklBZWpJZEQ5VkFtbEYz?=
 =?utf-8?B?TUxHK0JCQ1gxNDRwYWVhQTF4NE1BRy9td2kvQTErQ2ZBTTlCS0hDNDIrODVP?=
 =?utf-8?B?ZTFKOVVrbysvRDU4M1YyQkRjREt0MkpnbVVpQUFsd0Z2MW11bGtsaXQ3aHhx?=
 =?utf-8?B?dFpOTXA5RDVvdExZVWZWb2tKMGV1VFkxbkJHYURLTVM4Zjl0MlNVZksvR2J4?=
 =?utf-8?B?ZndWc21NbG5Xb2NwSmlIL1UveDYraDRySTJibm0vWk9rK3llQjhwekJjWmN6?=
 =?utf-8?B?U0szOHJSdVJiKzNFUVhNaHlWMUlYYXNHL3FUcTdSdVY1d2ZzY1V1bm50Y0pU?=
 =?utf-8?B?SVIrQ2g1aENZVzYrUWozY3hCMkxxTGhDWkM5RmNnZndPMXJhMXFwaHpkSDJW?=
 =?utf-8?B?bXE0eXdwakdFeDB6dmhrWmw2TVBxNFQyRGwrMmFadDJUd1FLWkdxemZSMEY5?=
 =?utf-8?B?YzBYUis0YXBhZHpacXJwM0FpNWl1YXFBeThUcGJPSENBNWZNSVA5N3hGUWRH?=
 =?utf-8?B?dDF1TlBLMmZRa3ZsSkZJZmQ3L0JhaG1BaEFOQ1JxWUdYMmFlNmhkcFpQZHRs?=
 =?utf-8?B?RzJ5Rk4rSUF6MVlMSVM0alg4dXhlYjlkbFcvcmZuNE1qd01wb1ZyRjBuN2th?=
 =?utf-8?B?RzFWczg4ODBuVmdaOFhUa2dOdDRwL2pEbVBQL3Bqb1hCV1JzNHQrOW9kRTd5?=
 =?utf-8?B?M0E9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	gWbX1htP5+7Cxlg9TF+wjAxS1FlhUurYgdecBtz6l9fuKBmyvT8Q/+95bWAgzfomiJdYttHVk5a6pS3yNiWv5n+0uQwOcpAUchpJ0/a2NARcqDV9AzE7e6mbOuMGfIbVZ+RzDz1j/DI7qxO/fpFNpqbnBpBUwGaayK6i11AoXXQKN8oNDyYG9P+M29GZikc4/l/QO9tdvHl3nx4lbuluxL1hfhNQ/1hfAgXZCrAd6q3h25SO9XXz9zA+3B5ZSPTNZ9FlDp2i7Z2pTt4QgwP58vdQGvuF/GU2e5QN06pvg+Ypc7vjPHBuO3okZi2/gkAFl1Xlf9174y3WoibDPi6ZD4qldrY6MUaSO4AjndTyTLkuF2uy6cwX9OMR7VKYScT7uUuI1Y2+kp1NONPXDGIvOWKZ/YfXQIm6ffyls+pAQQ9Eii5O8XQKNbKJG9wIQbtKiOz1zGOzGmGGjOuFQ05NVKAn5DYOu33aa2gOaw3lW/sA9H+IKmhOmkbIJIgi0J+aTw5x4qbfH1TsOMKYm76TpfPmYLNcCIUOXTYO5KpKP0ZWIZA/W3zaVOGAxz27ufIvRop3TmcYNg9208exG+X0KumKz7OVgzPIQkHpFQLrQIY=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7838f045-fe1f-41af-6c4f-08dc818d4788
X-MS-Exchange-CrossTenant-AuthSource: DS0PR10MB7224.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 May 2024 16:18:17.1851
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: UWCwz4rh8/CkShWVEznih20ygQAMpVwer6lhiQFwyhX/ytvnpmNlsg+xi8/USSlArBarKNVbIXhZE05zFCCBkkZkn6rO7zVtB0JWFJYtmtU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR10MB6845
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.650,FMLib:17.12.28.16
 definitions=2024-05-31_12,2024-05-30_01,2024-05-17_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 malwarescore=0 bulkscore=0
 suspectscore=0 mlxscore=0 adultscore=0 spamscore=0 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2405010000
 definitions=main-2405310123
X-Proofpoint-GUID: HQjBpf9v0VxXyeeD8BjnW2901M_Ak8IU
X-Proofpoint-ORIG-GUID: HQjBpf9v0VxXyeeD8BjnW2901M_Ak8IU

On 5/30/24 7:16 PM, Eric Biggers wrote:
> On Thu, May 30, 2024 at 06:03:18PM -0700, Ross Philipson wrote:
>> From: "Daniel P. Smith" <dpsmith@apertussolutions.com>
>>
>> For better or worse, Secure Launch needs SHA-1 and SHA-256. The
>> choice of hashes used lie with the platform firmware, not with
>> software, and is often outside of the users control.
>>
>> Even if we'd prefer to use SHA-256-only, if firmware elected to start us
>> with the SHA-1 and SHA-256 backs active, we still need SHA-1 to parse
>> the TPM event log thus far, and deliberately cap the SHA-1 PCRs in order
>> to safely use SHA-256 for everything else.
>>
>> The SHA-1 code here has its origins in the code from the main kernel:
>>
>> commit c4d5b9ffa31f ("crypto: sha1 - implement base layer for SHA-1")
>>
>> A modified version of this code was introduced to the lib/crypto/sha1.c
>> to bring it in line with the SHA-256 code and allow it to be pulled into the
>> setup kernel in the same manner as SHA-256 is.
>>
>> Signed-off-by: Daniel P. Smith <dpsmith@apertussolutions.com>
>> Signed-off-by: Ross Philipson <ross.philipson@oracle.com>
> 
> Thanks.  This explanation doesn't seem to have made it into the actual code or
> documentation.  Can you please get it into a more permanent location?
> 
> Also, can you point to where the "deliberately cap the SHA-1 PCRs" thing happens
> in the code?
> 
> That paragraph is also phrased as a hypothetical, "Even if we'd prefer to use
> SHA-256-only".  That implies that you do not, in fact, prefer SHA-256 only.  Is
> that the case?  Sure, maybe there are situations where you *have* to use SHA-1,
> but why would you not at least *prefer* SHA-256?

Yes those are fair points. We will address them and indicate we prefer 
SHA-256 or better.

> 
>> /*
>>   * An implementation of SHA-1's compression function.  Don't use in new code!
>>   * You shouldn't be using SHA-1, and even if you *have* to use SHA-1, this isn't
>>   * the correct way to hash something with SHA-1 (use crypto_shash instead).
>>   */
>> #define SHA1_DIGEST_WORDS	(SHA1_DIGEST_SIZE / 4)
>> #define SHA1_WORKSPACE_WORDS	16
>> void sha1_init(__u32 *buf);
>> void sha1_transform(__u32 *digest, const char *data, __u32 *W);
>> +void sha1(const u8 *data, unsigned int len, u8 *out);
>  > Also, the comment above needs to be updated.

Ack, will address.

Thank you

> 
> - Eric