Received-SPF: pass (google.com: domain of linux-kernel+bounces-197290-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <d8972012-269a-47d8-a150-f97aa6312efd@intel.com>
Date: Fri, 31 May 2024 11:17:28 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v5 05/16] selftests/resctrl: Use correct type for pids
To: =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>,
	<linux-kselftest@vger.kernel.org>, Shuah Khan <shuah@kernel.org>, Babu Moger
	<babu.moger@amd.com>, =?UTF-8?Q?Maciej_Wiecz=C3=B3r-Retman?=
	<maciej.wieczor-retman@intel.com>
CC: <linux-kernel@vger.kernel.org>, Fenghua Yu <fenghua.yu@intel.com>, "Shuah
 Khan" <skhan@linuxfoundation.org>
References: <20240531131142.1716-1-ilpo.jarvinen@linux.intel.com>
 <20240531131142.1716-6-ilpo.jarvinen@linux.intel.com>
From: Reinette Chatre <reinette.chatre@intel.com>
Content-Language: en-US
In-Reply-To: <20240531131142.1716-6-ilpo.jarvinen@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?REx6RWxrczlEV1ZFc2U0eDhESVRKVExOWWljR2pHYUJmQkhsYUh0Qk1pSEdH?=
 =?utf-8?B?SFZFN09uS253aGF4UjZpTW5VVThMcmdZUElwenowaWcrc0pUL2hWWGgyYXlK?=
 =?utf-8?B?Z2FFb1pTdENLWmcra25pUEptNlcveEFCVzQ4Z2thZk9KazFrWHA2WVVXcE9M?=
 =?utf-8?B?QXNRVkdwVk9ZNTRBL2VvdEJCMVNyV3hJMGRKWU5oV3ArT3hNZ2tUczZlOElx?=
 =?utf-8?B?MG1Ra2xHbW5uWDZPMHFldDA3bHlzYWd2UWhsTGF6NFgyNHM3RGcxaU5ZTEs4?=
 =?utf-8?B?eFZLdGlFNHdBOVF6YlloMHI4eWtxZFJ5eDROOUpDTFY1T1BjcWlyQWRsSFJ0?=
 =?utf-8?B?SmNyOGx3a1ArVXk2VzVtSjdpWWZWZ3p0SmVXS2ZWMkVvdldFRGdqc1Z6ZDMy?=
 =?utf-8?B?TGlHbFVwM25SeFlzWCsydGcvTUd6TUIzSVpnRVlyOHRKS2xLSHYwVGpuZVkx?=
 =?utf-8?B?WHE0em8rNEN0aGZqSldwbmFkWXZSa3dBaTcxejJ2d2RQY2l6VG9KcEVEZ1h1?=
 =?utf-8?B?TTNmT0FYQTY2OFloVWF4SXJzOFNRZmJ5NmxvUFJZb0FlcXhSdXE4MWtuWVVB?=
 =?utf-8?B?Y0ZaOGc4Ym0yVkdiTUZaSTQ4K1E5elVsNk9JcHJ1S1hXb1dJcjZTcUNKN25Z?=
 =?utf-8?B?MUdCMi8xMVFHWCsyaUVQdWlNRDk4dDczbjBISGwyTURkTk96QjNNbkNrZU9y?=
 =?utf-8?B?R3Q5Z3dYVWlxZ2FDeDh6amdIOHltYmNTWkVIdUgzbEs3WTNTWm90MklFUW0r?=
 =?utf-8?B?eTc2R1lGb1hITEk4TmN1MjVYbWlYaUorbkpqRW1SSks2OWY1R3YrelM1M1Nv?=
 =?utf-8?B?bXU1dlRrbHlJOE9oY2E0WFRzU0M3UXoyYXpmNGttWFZXUEp2SFpxMHhkK09F?=
 =?utf-8?B?SVhYSmNnekorL0JCR21nNzNuUnhYVFh1Y1pyUXBGc1RlRkRuOXE3UFJaUFFJ?=
 =?utf-8?B?YmJSNmUxM3hnbVFxK1d2c0N0eDdsdmkvNytQUCtueFBUaTJQZTBhUDFRcGhy?=
 =?utf-8?B?NlpqQjZtVk9zczlTc1NRc0RJOGxvWWJ4M3B3U3FpNHQvQUZidy9SbTNOaENS?=
 =?utf-8?B?VmtDdUtreXdrVW01ckJwcGl6TTN6SHdsUkdjdGZMVFhMZS80R0lTSm9zUGRa?=
 =?utf-8?B?d0NjVHNOQjR3OFduTS96ditwdTdXd1lTOS9wRVJSbElTOHZvbStLcEhEUlkv?=
 =?utf-8?B?UWM2eDFvRXcyOWZReVRUL2s5V3htSnQ0VEhLY2FuQUZlelN1TFpRSW9SYVJK?=
 =?utf-8?B?T2RZS1BDZ250ZkhVVG5TVFFjakVTTXQwVFl4akJheHcvMVhpUlgxaVpjdEsy?=
 =?utf-8?B?ZGR5VlNMUThXYW1NUVNuUlNzdmRUVkF1RnROUXYxZE9aY3R0VlJiT2xWNFdq?=
 =?utf-8?B?NkZMRHZLWFF5c2hvY2xQbktqaGNzckpVeWZpVXVtMWdTVlNPcHA2SHJQdWJi?=
 =?utf-8?B?SlF6cTlNOVQ0a3lpRFk3b2lodmV6TGdJWVQ4ejQ1WUVTbm5IR0pSKzZhOCtV?=
 =?utf-8?B?bmp6R1FNMlBTT0NmbWVIMTVCa3BiQng0R3ZHZjRsN0xUbTU3cm1aaUI3NElm?=
 =?utf-8?B?MXlQbzgwSStuaVh1aFZMYzFNSzIrNlp6MndkU2NFek5GSE1FN2cwMlhVMWJG?=
 =?utf-8?B?Z2t2TC9iVW9QazZwdzlkVjNtZVNSOWNUQzl3WThaSURmT1JvMDVqTmE4Q1RM?=
 =?utf-8?B?RXcrMUgzN3BGODFaY0o1d1pTaUtNem9Dc2pGZjJUNHdrOVhKSGhRWWRVOHVG?=
 =?utf-8?B?UVRSNTBCYnpSbW5QUWFMK0VUa2ZGQjlMMGF3SmlITE9kRE1SN3Y2KzFKeTB1?=
 =?utf-8?B?b2lzcUpaYm1yaGdyV0RYM2F3UlNOMzhNNmE4UTdsb2hhOXN2aFIyUUpsdTlS?=
 =?utf-8?B?UUl1Q0w1bFdxN3NxNTVXYTNzeFB5WnRpWFVCc1VpYUVQejBDUFRxVDRGN3Fo?=
 =?utf-8?B?UjFuNE45bTJvS3daaE53OUgySHJGY0pORXI5ckNWdm0vMVBMeDMwWWVGQ3Aw?=
 =?utf-8?B?R0svaE9YVXFaNklYUVFZSmZkVVNxcGhXUk16UHBaT3VxUEVxNS8wVmFRYjJC?=
 =?utf-8?B?VEdRUHcwOUhGNmplM2lwRHU2OWFXZE9NWnRjeGRUQ0dCSGhMQ1hRTWt5VDN1?=
 =?utf-8?B?YzMrOFBOVGRDbDFVMmpOMXlLYWpCUlcrMEV3U0tsNS9xaWxCTVlPUFNuYUg1?=
 =?utf-8?B?Wnc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: f5093481-88c9-4491-36ae-08dc819def93
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 May 2024 18:17:31.0193
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: r1s4CnEb0GQRh5SC/fIOftyY3sZ49fslSnxe5XfDK/pSMDinZK6J5XIAE0bk/YeY89lBUn13Odj+IxJFB1SK+XoN6esLYQSjuHPJI+JVSus=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB8316
X-OriginatorOrg: intel.com

Hi Ilpo,

On 5/31/24 6:11 AM, Ilpo Järvinen wrote:
> A few functions receive PIDs through int arguments. PIDs variables
> should be of type pid_t, not int.
> 
> Convert pid arguments from int to pid_t.
> 
> Before printing PID, match the type to %d by casting to int which is
> enough for Linux (standard would allow using a longer integer type but
> generalizing for that would complicate the code unnecessarily, the
> selftest code does not need to be portable).
> 
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> ---

Thank you.

Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette