Received-SPF: pass (google.com: domain of linux-kernel+bounces-197293-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <f65c35a9-1b77-41cd-95e0-38ae2e4ced24@intel.com>
Date: Fri, 31 May 2024 11:18:25 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v5 16/16] selftests/resctrl: Remove test name comparing
 from write_bm_pid_to_resctrl()
To: =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>,
	<linux-kselftest@vger.kernel.org>, Shuah Khan <shuah@kernel.org>, Babu Moger
	<babu.moger@amd.com>, =?UTF-8?Q?Maciej_Wiecz=C3=B3r-Retman?=
	<maciej.wieczor-retman@intel.com>
CC: <linux-kernel@vger.kernel.org>, Fenghua Yu <fenghua.yu@intel.com>, "Shuah
 Khan" <skhan@linuxfoundation.org>
References: <20240531131142.1716-1-ilpo.jarvinen@linux.intel.com>
 <20240531131142.1716-17-ilpo.jarvinen@linux.intel.com>
From: Reinette Chatre <reinette.chatre@intel.com>
Content-Language: en-US
In-Reply-To: <20240531131142.1716-17-ilpo.jarvinen@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Z2lRS1N1SjVHTzJ6L3RIZThDRjlkVzZ5OEcvdUxpeERmZldhVjZyK1l3eVpZ?=
 =?utf-8?B?dWdpZXRLWWRER2tvUW5WeVFEMVhvMzJnVDcra0haQ1dyWGlyRlNhaHdPTFBz?=
 =?utf-8?B?cXRtKzNpaXRkODVnWU9iRWc2ZzJwaU1Hd25lNjJCbk8xMDYwZ2s4c05DN05o?=
 =?utf-8?B?dVc4M0ljdDAwejBQMzFnc1FPWmdFWUdxNlV3VVFKQnBUZkhBc25nN1prQ2dF?=
 =?utf-8?B?UlhUNGRtK3czVk9aeFhERDloRWkveklkSDV2UGtRcTBLcUpiS2Y3bjNmTWd1?=
 =?utf-8?B?azBKaW1JYTU4VFVNb0d2NzU1Yk9Pa1JPVzZHWnFjRytPSUhxbUhFeXljaEtC?=
 =?utf-8?B?ZzRiaUhBbkxNUDBrSGZMTnhTWWdmTDhMOUd0c3h1NEVmVDV6bm5HVy92MXE1?=
 =?utf-8?B?VFYzK0pqTlg3V0FmNDVlbWE3Q2tLM0JxM2d1akxoOXNTQXY2d0F2ZmErTkdy?=
 =?utf-8?B?UWZQQnhuZ2tlUXZCMkFtOXlwTlhteEd2ZzdMRXNRN0tKMGdacGNqdGpCZlM5?=
 =?utf-8?B?dHVuVEczczlXdEU4OW9pZjRrN0FaWUU1VEVMTlBuQk84YWxXdHByNnVORGlm?=
 =?utf-8?B?V1h4eUlCRUVJWVlIdzBIU2hiUEVUMVY3dk0xSTQ0R3pjMkNZMVJscm5JUmVu?=
 =?utf-8?B?MHZRUnZsWEdVdDFjR094ZkgySFAxelJZdmdMYlZUTXo2ajFjaGEyRmlpMzFH?=
 =?utf-8?B?M1A1dkpVd3EyUllZYlF0cXFWQ3lkVHpKcmpiU1dxdURDLzFmbFFFd2lmQmpE?=
 =?utf-8?B?aU1LYlBjQWZ1VEhMVlJDSlVTRmlub2xtTlluYVF2VTJRZHA5TW9TVDkzU1RZ?=
 =?utf-8?B?ZVhuRm5iWENCSmRWUTh0ZENsdnpLY3VIaEFTMkRacCtSUjBDRVZZdjlTdjE1?=
 =?utf-8?B?U2sxejlENlhZcHgrWHlJN09ZVEtaV2JyS3hZWkgvVmVDQ05vbEh6ZnNKZmFq?=
 =?utf-8?B?SGhDMGhqSDZtc2R6bGhMQnh4WlpOZUswL3lza01McG0yQzErU2lRSzBWY3Mv?=
 =?utf-8?B?TC85dTBLZmVJVEpOUlBtekpVVjBiYW01Sm8xQS9BN0RYSlB2b1EybEh3Njcz?=
 =?utf-8?B?bGlUUTZBQ1YxZHBTWWFFcTR0cmxENytWN240emNXeUIyU0g4RllEem5DYmJY?=
 =?utf-8?B?YTYxVERrN0s2cE9KSDYzeGRhNHVaS3lWTEpNR3VXdUg4RDdRU2oyMW1adXFN?=
 =?utf-8?B?ZFhIU2NibERtdFQ5SGpKajlaYk1ubGVyVVk1dW8xWnpqcVhNM2tuUTEyZmMw?=
 =?utf-8?B?QVpMZVV5Z2Vwb0l0bVB5WW52SzMwR1dDVjFxMTBwTnV6VzJVemM2cU1jOVk2?=
 =?utf-8?B?NTFXU3VxblNIZTlBNlZjdEZyU1ZKdEVJbW1LQXRoTk9wWkZrSjNtbUtRNzAz?=
 =?utf-8?B?V2dSclU0VXVzTWxXUktRSVNxWWhnRDVuSm1ZVmRucUFsNDBhQStVS2JTeE4z?=
 =?utf-8?B?Y2h4cjg3L3VubmEzSmxKRWR0aWRFMnFWdUZRcmkwZUQydUxNMUdCbzlEcVRh?=
 =?utf-8?B?RlZZZDNqUWVFcDRUVmZIeXhma1hPVVJadEMvR0J5bFhHR1VQRytmMDkvWkQz?=
 =?utf-8?B?cW52c0NXeCtwaGJvWGVLTWFDaDhzRFluL0xHVHRFVkZ2d2V0aG5wUVdaQk4v?=
 =?utf-8?B?VjNqcFZqUnNweUtRMWNpWGVqdDJiaitiTExXUnA4bmhnVVdUNmk0VUxYSjJ3?=
 =?utf-8?B?WWNnRk5nVGx2VWhhanAwMk9KSWFpV3Z5K3AxM2F1d3BXb1hBY2NxaStDQjNl?=
 =?utf-8?B?UXRIMDhzWW9SWlBrbWk4OEpXQjVtQ01CTUYzTmRxaXVoYTB5bzNZT0pRemVj?=
 =?utf-8?B?cXk5ZDhWdGJ1SkNwZnNpM1RUR1crYU1QdTVDeWdBd3VVYlJ2aGlnaHhhRnBw?=
 =?utf-8?B?dlNYakxTUEhZNHZrZGlENms4ZC9PeEVNc2tGU1krWnVNNW1mY21sMWV1dlJz?=
 =?utf-8?B?QzQ2Z0lIRFlrWmZsZTF1OVUzdlRHeDN4elY2a0RDamlXc1VHQnNtaWIzc2I2?=
 =?utf-8?B?SWpoK0VGZ00wZDJpSGtkNHpLR2FSeFBJdCtMRjdyR05mZG9haDQ1cStyc0k4?=
 =?utf-8?B?Nno2MHRuZktqa2J1OEc5d2U2bmJLTEtMNE1CV1BGWDkydVFuSkh6UXZJY3NC?=
 =?utf-8?B?NXV0T1BwdGkyMnE1aDlOazY5cHh5SWNnNjFZMTlhOCsyV0o5Z3pGMlNJQ3JN?=
 =?utf-8?B?NVE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 39b44cef-331e-43c3-be98-08dc819e1138
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 May 2024 18:18:27.4495
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: tbhrg2R6sR/uW/1EC2EFB/4lXncAsWEOXsGLtovaphqN87gzOrC0/viHH7b3bvEo22wMBvs37eUM1aIDbryHHse8ojdp/cpJsb+ID5EosHY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB8316
X-OriginatorOrg: intel.com

Hi Ilpo,

On 5/31/24 6:11 AM, Ilpo Järvinen wrote:
> write_bm_pid_to_resctrl() uses resctrl_val to check test name which is
> not a good interface generic resctrl FS functions should provide.
> 
> Tests define mongrp when needed. Remove the test name check in
> write_bm_pid_to_resctrl() to only rely on the mongrp parameter being
> non-NULL.
> 
> Remove write_bm_pid_to_resctrl() resctrl_val parameter and resctrl_val
> member from the struct resctrl_val_param that are not used anymore.
> Similarly, remove the test name constants that are no longer used.
> 
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> ---

Thank you.

Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette