Received-SPF: pass (google.com: domain of linux-kernel+bounces-196875-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Fri, 31 May 2024 14:20:53 +0100
From: Matthew Wilcox <willy@infradead.org>
To: Chengming Zhou <zhouchengming@bytedance.com>
Cc: Dev Jain <dev.jain@arm.com>, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org, Anshuman.Khandual@arm.com
Subject: Re: [External] Re: [QUESTION] mm: Redundant const parameter?
Message-ID: <ZlnOtboo8mpWVBxR@casper.infradead.org>
References: <e5f01ffe-de51-4079-a87f-2886788422f9@arm.com>
 <e6b7858b-39cd-432d-9206-4ccbd153baa2@arm.com>
 <7f7c3bbe-e250-420d-a7d5-89508d881f0b@bytedance.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <7f7c3bbe-e250-420d-a7d5-89508d881f0b@bytedance.com>

On Fri, May 31, 2024 at 08:30:08PM +0800, Chengming Zhou wrote:
> On 2024/5/31 19:31, Dev Jain wrote:
> > I guess it would be better if I send this as a patch and wait for comments.
> 
> Ah, you're right. I think it should be:
> 
> 	return folio_test_workingset(slab_folio(slab));
> 
> Right? Don't notice there isn't any build warning about this "const" discard.

But there used to be!  I fixed that in ce3467af6bde dated Feb 27 2024,
which took a fair amount of prep work to make happen.