Received-SPF: pass (google.com: domain of linux-kernel+bounces-197325-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Fri, 31 May 2024 18:58:45 +0000
From: "Dr. David Alan Gilbert" <linux@treblig.org>
To: Muhammad Usama Anjum <usama.anjum@collabora.com>
Cc: davidgow@google.com, linux-kselftest@vger.kernel.org,
	kunit-dev@googlegroups.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] list: test: remove unused struct 'klist_test_struct'
Message-ID: <Zlod5TMzmXinDu2X@gallifrey>
References: <20240531151801.128792-1-linux@treblig.org>
 <89e07c93-a54d-4cc2-8ee1-664389ffcdd7@collabora.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <89e07c93-a54d-4cc2-8ee1-664389ffcdd7@collabora.com>
User-Agent: Mutt/2.2.12 (2023-09-09)

* Muhammad Usama Anjum (usama.anjum@collabora.com) wrote:
> On 5/31/24 8:18 PM, linux@treblig.org wrote:
> > From: "Dr. David Alan Gilbert" <linux@treblig.org>
> > 
> > 'klist_test_struct' has been unused since the original
> > commit 57b4f760f94d ("list: test: Test the klist structure").
> Probably a fixes by tag would be needed here.

I'm generally avoiding fixes tags in this set of changes, since
  a) They have no behavioural change at all.
  b) Downstream and stable kernel people use fixes tags to indicate
     stuff they should pick up if they have the original, and there's
     no need for them to do that with this cleanup.

Dave

> > 
> > Remove it.
> > 
> > Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> > ---
> >  lib/list-test.c | 6 ------
> >  1 file changed, 6 deletions(-)
> > 
> > diff --git a/lib/list-test.c b/lib/list-test.c
> > index 0cc27de9cec8..383ee0ad582e 100644
> > --- a/lib/list-test.c
> > +++ b/lib/list-test.c
> > @@ -1201,12 +1201,6 @@ static struct kunit_suite hlist_test_module = {
> >  };
> >  
> >  
> > -struct klist_test_struct {
> > -	int data;
> > -	struct klist klist;
> > -	struct klist_node klist_node;
> > -};
> > -
> >  static int node_count;
> >  static struct klist_node *last_node;
> >  
> 
> -- 
> BR,
> Muhammad Usama Anjum
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/