Received-SPF: pass (google.com: domain of linux-kernel+bounces-197340-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <f9091516-37ff-43d1-b515-ae8eb3f80e80@linuxfoundation.org>
Date: Fri, 31 May 2024 13:13:27 -0600
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] list: test: remove unused struct 'klist_test_struct'
To: "Dr. David Alan Gilbert" <linux@treblig.org>,
 Muhammad Usama Anjum <usama.anjum@collabora.com>
Cc: davidgow@google.com, linux-kselftest@vger.kernel.org,
 kunit-dev@googlegroups.com, linux-kernel@vger.kernel.org,
 Shuah Khan <skhan@linuxfoundation.org>
References: <20240531151801.128792-1-linux@treblig.org>
 <89e07c93-a54d-4cc2-8ee1-664389ffcdd7@collabora.com>
 <Zlod5TMzmXinDu2X@gallifrey>
Content-Language: en-US
From: Shuah Khan <skhan@linuxfoundation.org>
In-Reply-To: <Zlod5TMzmXinDu2X@gallifrey>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 5/31/24 12:58, Dr. David Alan Gilbert wrote:
> * Muhammad Usama Anjum (usama.anjum@collabora.com) wrote:
>> On 5/31/24 8:18 PM, linux@treblig.org wrote:
>>> From: "Dr. David Alan Gilbert" <linux@treblig.org>
>>>
>>> 'klist_test_struct' has been unused since the original
>>> commit 57b4f760f94d ("list: test: Test the klist structure").
>> Probably a fixes by tag would be needed here.
> 
> I'm generally avoiding fixes tags in this set of changes, since
>    a) They have no behavioural change at all.
>    b) Downstream and stable kernel people use fixes tags to indicate
>       stuff they should pick up if they have the original, and there's
>       no need for them to do that with this cleanup.
> 
> Dave

+1 on using careful use of Fixes tag only on real fixes for the
reasons mentioned above.

thanks,
-- Shuah