Received-SPF: pass (google.com: domain of linux-kernel+bounces-197359-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: <Tristram.Ha@microchip.com>
To: <horms@kernel.org>
CC: <Woojung.Huh@microchip.com>, <andrew@lunn.ch>, <vivien.didelot@gmail.com>,
	<f.fainelli@gmail.com>, <olteanv@gmail.com>, <davem@davemloft.net>,
	<edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
	<UNGLinuxDriver@microchip.com>, <netdev@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: RE: [PATCH net] net: dsa: microchip: fix initial port flush problem
Thread-Topic: [PATCH net] net: dsa: microchip: fix initial port flush problem
Thread-Index: AQHasUaa3Zq2wVoFDEumZ+nfFFvgXbGxt6MAgAADn3A=
Date: Fri, 31 May 2024 19:19:54 +0000
Message-ID: <BYAPR11MB35583B3BA16BFB2F78615DBBECFC2@BYAPR11MB3558.namprd11.prod.outlook.com>
References: <1716932145-3486-1-git-send-email-Tristram.Ha@microchip.com>
 <20240531190234.GT491852@kernel.org>
In-Reply-To: <20240531190234.GT491852@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?19OtagTYn5FLO9IKwv9U83RbNQYSvSCX0A8L0MlyMGoSSRRahDGthOjM3izv?=
 =?us-ascii?Q?EiLftPA0DTUYqKybv2xpK9+KE5EFi1mj75Wsb5U+NDFT322qZynORN9Jr3wW?=
 =?us-ascii?Q?cOVx+SdcuIXaqSX5kkamMyHuFalEKhmyEbCsIr7M8v3Cx9umI6/YVaTd09u2?=
 =?us-ascii?Q?J5b2BWoqCRL+62IRJtHnjZpOcsu37cOaudRFUfNVSmHlHdRpxRIZkbXujucW?=
 =?us-ascii?Q?nK3xZ1z1zxEqn3eNxeCq7dLcsqKDjuioERlMHqjxgcNWPJXMVGm+TfxCnjGQ?=
 =?us-ascii?Q?95PHjhuNwLRC4fsBYZ5hwsJCymAQ0XhL+i/rrq8fTbivST/kaUqSB3i7Nivx?=
 =?us-ascii?Q?MiH6Y1SJ1BmEXBeCoWnGyKYV2RM+G9QN4DZiQPCsZozGLNGvegcy0yVVMB71?=
 =?us-ascii?Q?Cp6ySNIjBkHGHJrxcXGBJS4IluLF7Q3lBdLJLNoy8PXm0/BGWO055kFyBijl?=
 =?us-ascii?Q?+aiZ/fNMDQ0mW2Oj5fJDVuHqKYr6iV+f/4RiP75KOM/sC0XcNauPcPxZpsY8?=
 =?us-ascii?Q?H+MFnXoRtqC00lijKn+um+N/8qRj8asqdDgM7q6QJTEiEtrVZ4tUCNAhIhVN?=
 =?us-ascii?Q?SgMEEL63RkpV/46blzTaSKvFWm2nWqFMAIewOR47kjXrD8j0t5I+cYzcgkGX?=
 =?us-ascii?Q?tee6zb11xV74dVhSBuqHTLQGXvL4D/bosUSLcwNp/d/3cgBSxtTB+sEtEunm?=
 =?us-ascii?Q?8zgdM8gry977MdgOgHlIa/u++ZX0hBlvG0dcQtPAr61KzSDhfCklHjIX6Nis?=
 =?us-ascii?Q?mABiB0FkYNsxXwV+f0mkFWlDjzSKbDB2U7z4UbYxaJbCQdHTzSW1H8J14W7x?=
 =?us-ascii?Q?2Uhzjkcal2eZDZ6fiLPzPbkdU6WyXV5Mnhg9vsjA4GubQB2VlDDnUZc08pKE?=
 =?us-ascii?Q?Fh5U4goKlDzV5p3a9/MCMH3AXmJ/dSpThIV2J3oWnmaio2wfCUGi8J+OtXz+?=
 =?us-ascii?Q?aid1Ty9PxcGhSpkNJmwjQQFZ+bSmQRDmUqEPVvUGQ0GDZYph8SXjtRMBIRhk?=
 =?us-ascii?Q?FuIHGD2c1qtWxsBVITT1nXuL53UsEWg4Q3MA3HBqorCURT7CC8hmY9tHTmgr?=
 =?us-ascii?Q?Qsw800WabO2ivYz+s3zNiLbU8kEpWyO5Dhd47wASk9H0xzRVKE8A7qAGU3FB?=
 =?us-ascii?Q?W9AOcsNepFLZilfV4xkQxAxcqC4KKUrHn/9JM8cWdh3u4kHZCdrb1cedqDbs?=
 =?us-ascii?Q?CiYeCaYCei4BU4sgYS5vTjTg5l/HMacFFURgnEnnerDDDItxQjtMN4xRWyFL?=
 =?us-ascii?Q?h90wHyhSf2t6GAh2P+cQS+mv91SNuBwkb6iPDutwOm/cI55CbElLoBQ0D/Vp?=
 =?us-ascii?Q?K6LN36HyhM+qkqojROEoSFJVHA+LMp8TwuM1ZyH/QI+9kTqae6dfmaUOrZ0S?=
 =?us-ascii?Q?aCMWZIE4MU5WMlfQUY6Th6b7frplHVXFRroeM5+FUMj8WkNcuKN0DWx3ZeII?=
 =?us-ascii?Q?Jc7X8IrmCSeTFHhukM7FfuCoj9pcy9u/AF1NgwT82F3rhExTslPXHdzB32vh?=
 =?us-ascii?Q?qLA67UJuRNanSqpLMOu50DdGTO91YAO8AwJNMesEXQdNFOFv+fsRjbnacwRo?=
 =?us-ascii?Q?r3WcJxQ2NPrQGQ0+nO9LFIR8q168zR/1vJK2tsf5?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3558.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7b42d3e2-6bc5-40a6-55fa-08dc81a6a72f
X-MS-Exchange-CrossTenant-originalarrivaltime: 31 May 2024 19:19:54.8756
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: dT2QDnwJk8qhNcW6pR2Yi9BwcBoAwqU/QA28pwvOk8b1bm0DHwhwtXZL8mSAJEZ3J1PpDfIgbDJfR3rw5RjeRD7rezJJttnH0ZXX9BCOHlU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR11MB8515

> Subject: Re: [PATCH net] net: dsa: microchip: fix initial port flush prob=
lem
>=20
> EXTERNAL EMAIL: Do not click links or open attachments unless you know th=
e content
> is safe
>=20
> On Tue, May 28, 2024 at 02:35:45PM -0700, Tristram.Ha@microchip.com wrote=
:
> > From: Tristram Ha <tristram.ha@microchip.com>
> >
> > The very first flush in any port will flush all learned addresses in al=
l
> > ports.  This can be observed by unplugging a cable from one port while
> > additional ports are connected and dumping the fdb entries.
> >
> > This problem is caused by the initially wrong value programmed to the
> > register.  After the first flush the value is reset back to the normal =
so
> > the next port flush will not cause such problem again.
>=20
> Hi Tristram,
>=20
> I think it would be worth spelling out why it is correct to:
> 1. Not set SW_FLUSH_STP_TABLE or SW_FLUSH_MSTP_TABLE; and
> 2. Preserve the value of the other bits of REG_SW_LUE_CTRL_1

Setting SW_FLUSH_STP_TABLE and SW_FLUSH_MSTP_TABLE bits are wrong as they
are action bits.  The bit should be set only when doing an action like
flushing.

> >
> > Fixes: b987e98e50ab ("dsa: add DSA switch driver for Microchip KSZ9477"=
)
> > Signed-off-by: Tristram Ha <tristram.ha@microchip.com>
> > ---
> >  drivers/net/dsa/microchip/ksz9477.c | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/drivers/net/dsa/microchip/ksz9477.c
> b/drivers/net/dsa/microchip/ksz9477.c
> > index f8ad7833f5d9..7cc92b90ffea 100644
> > --- a/drivers/net/dsa/microchip/ksz9477.c
> > +++ b/drivers/net/dsa/microchip/ksz9477.c
> > @@ -356,8 +356,7 @@ int ksz9477_reset_switch(struct ksz_device *dev)
> >
> >       /* default configuration */
> >       ksz_read8(dev, REG_SW_LUE_CTRL_1, &data8);
> > -     data8 =3D SW_AGING_ENABLE | SW_LINK_AUTO_AGING |
> > -           SW_SRC_ADDR_FILTER | SW_FLUSH_STP_TABLE | SW_FLUSH_MSTP_TAB=
LE;
> > +     data8 |=3D SW_AGING_ENABLE | SW_LINK_AUTO_AGING |
> SW_SRC_ADDR_FILTER;
> >       ksz_write8(dev, REG_SW_LUE_CTRL_1, data8);
> >
> >       /* disable interrupts */
> > --
> > 2.34.1
> >
> >