Received-SPF: pass (google.com: domain of linux-kernel+bounces-197370-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: SeongJae Park <sj@kernel.org>
To: Alex Rusuf <yorha.op@gmail.com>
Cc: SeongJae Park <sj@kernel.org>,
	damon@lists.linux.dev,
	linux-mm@kvack.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/2] DAMON multiple contexts support
Date: Fri, 31 May 2024 12:33:07 -0700
Message-Id: <20240531193307.71424-1-sj@kernel.org>
In-Reply-To: <20240531122320.909060-1-yorha.op@gmail.com>
References: 
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Hello Alex,

On Fri, 31 May 2024 15:23:18 +0300 Alex Rusuf <yorha.op@gmail.com> wrote:

> Currently kdamond uses only one context per kthread
> and most of its time it sleeps, so utilizing several
> contexts can scale kdamond and allow it to use
> another set of operations.
> 
> This patch-set implements support for multiple contexts
> per kdamond.
>
[...]
> 
> ---
> Changes from v1 (https://lore.kernel.org/damon/20240515152457.603724-1-yorha.op@gmail.com/)
> - Compatibility for DebugFS interface is kept
> - Kunit tests build/execution issues are fixed
> - Patches from v1 are sqaushed, so that consistency between patches is
> kept

My request was to avoid unnecessary temporal changes that will be removed in
next patches.  Some of those are well removed in this version, but I still show
some.  E.g., nr_contexts field.  Also, this resulted in two big patches.

I'd also appreciate if you can separate changes into smaller ones of logical
single change.  For example, changes for lru_sort.c, reclaim.c, and sysfs.c on
first patch could be much smaller in my opinion.  Traceevent change can also be
separated from patch 2.  Some of multi-context support seems mixed in patch 1.

I'd suggest below patches flow.

Patch 1: Introduce new struct and control functions for the struct.  Don't
really use the struct and the functions.

Patch 2: Modify core.c to use the struct and implement multiple contexts
support.  Minimize changes to core.c users.  Just keep those work as before.
Don't implement multi contexts support on sysfs.c or trace events at this
point.

Patch 3: Update sysfs.c to support the multiple contexts.

Patch 4: Update trace events to better support it.

> - Added/Fixed comments about data structures/functions

Also, you don't need to put version history under '---' marker if it is a cover
letter.  You can put it on the body.

> 
> Alex Rusuf (2):
>   mm/damon/core: add 'struct kdamond' abstraction layer
>   mm/damon/core: implement multi-context support

I will try to put more detailed comments on each patch.

> 
>  include/linux/damon.h        |  80 ++++--
>  include/trace/events/damon.h |  14 +-
>  mm/damon/core-test.h         |   2 +-
>  mm/damon/core.c              | 509 ++++++++++++++++++++++-------------
>  mm/damon/dbgfs-test.h        |   4 +-
>  mm/damon/dbgfs.c             | 342 ++++++++++++++---------
>  mm/damon/lru_sort.c          |  31 ++-
>  mm/damon/modules-common.c    |  35 ++-
>  mm/damon/modules-common.h    |   3 +-
>  mm/damon/reclaim.c           |  30 ++-
>  mm/damon/sysfs.c             | 303 +++++++++++++--------
>  11 files changed, 872 insertions(+), 481 deletions(-)
> 
> -- 
> 2.42.0


Thanks,
SJ