Received-SPF: pass (google.com: domain of linux-kernel+bounces-197372-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <d97f837e-fe7c-64ed-78ec-2581607150c6@amd.com>
Date: Fri, 31 May 2024 14:34:37 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Subject: Re: [PATCH v4 10/15] virt: sev-guest: Choose the VMPCK key based on
 executing VMPL
Content-Language: en-US
To: Borislav Petkov <bp@alien8.de>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org, linux-coco@lists.linux.dev,
 svsm-devel@coconut-svsm.dev, Thomas Gleixner <tglx@linutronix.de>,
 Ingo Molnar <mingo@redhat.com>, Dave Hansen <dave.hansen@linux.intel.com>,
 "H. Peter Anvin" <hpa@zytor.com>, Andy Lutomirski <luto@kernel.org>,
 Peter Zijlstra <peterz@infradead.org>,
 Dan Williams <dan.j.williams@intel.com>, Michael Roth
 <michael.roth@amd.com>, Ashish Kalra <ashish.kalra@amd.com>
References: <cover.1713974291.git.thomas.lendacky@amd.com>
 <b8508f57712e3194484aa8695494eea26abe1b73.1713974291.git.thomas.lendacky@amd.com>
 <20240531125503.GEZlnIp7YobFu7g9iS@fat_crate.local>
 <ad55da28-e5e0-a348-3cbc-d1a80d0ab2bb@amd.com>
 <20240531190348.GKZlofFDL4ESfpOQ6O@fat_crate.local>
From: Tom Lendacky <thomas.lendacky@amd.com>
In-Reply-To: <20240531190348.GKZlofFDL4ESfpOQ6O@fat_crate.local>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?L0FHN0pmM3RoOEIvNmdQOEI2MmVBbkZGWXUzQ2RCM3M0M1NIWTRlVWF0TVlU?=
 =?utf-8?B?N0ZOZGpxOHZUOU5EYTlHRGZJaHYyMWZxSStWOW83MHc2UTd5TUNIcFRMcXpL?=
 =?utf-8?B?aEFCTUFmK3VnY1VQZDA1SnhOTjcwd0dGaFlHdDZNcHNxanBPUlBBR01FMGR5?=
 =?utf-8?B?U2ZqNnFTYzRWaTQwK2RMVXNBWjQ1OUI5RHdDUG05aTVZbHVab3JEYnBwNVVu?=
 =?utf-8?B?WDMyKzBmSGVpUFBqWEhiTml1NHZIMzEvWEhVOU40ZFJQaGJZNXkzYjQwK2V6?=
 =?utf-8?B?ZXRxUkV4T3JMay9oZzNOeWhURHQrK1Y0SzY0RFkrQkR3VG9JUU9Ec2FtaEp5?=
 =?utf-8?B?RG5YZXl0RkdOQXRPdURUL01WRWtmbXd2dUROS01SZHFqTGZsL200dytiWldj?=
 =?utf-8?B?cXF5SndYcTNsUFBwY3BhQmRhWVhKdlAxQytnZHBSNEpwQ2h2UmRUTVBQVCtu?=
 =?utf-8?B?Zzc0U1UzTElFOHVXY2NDbkhlNXp3VHNmMSttRUtmUWQ2MStPS0pvMXhTak54?=
 =?utf-8?B?ajBpSE5JdUptb0p1c2luZGI2Q0hEMzJVRzQyY2JyUWkvYkNFVTlzK1MwRy9K?=
 =?utf-8?B?ck9aUnpLaFBOSzc3aHFuSXJYSllCaEZoWFQ0SWl0MVU2MDhlbWNqQzFPNzJI?=
 =?utf-8?B?TUFXU05HK1VHSFFjbXRqSXZ3a0I4WEJ6OEtXeGx5SUoxd2tYVCs4NmdsUGs1?=
 =?utf-8?B?dUtYZlN2UkdUOWZtVHRVcEFaWm5nbTVYRzVscGxvcU91TUp3SmVUZ282aDQ3?=
 =?utf-8?B?cGJBV01weUtnQUszN3BiSnkwNm96dWp0NjR0MGdZeWNGYmRpYnBuODZpUW5m?=
 =?utf-8?B?b3Z3TFBITEJROUl2NWVWcVQ2NXhYSWYxOUNaZVlwRUxYWitPWXJVV09jdVlP?=
 =?utf-8?B?NnNuaU9CV3JzRUZGbW9MOEFraWNlNGFFc0RzWU4yQnpsNzVseFJza0pLdmRW?=
 =?utf-8?B?Y0hxcFJ2SFNUK2dVM0RYNHdpVDZ1LzJIcVZmOWVBUm5CckdQRk1XTUxOY0FD?=
 =?utf-8?B?NGJLblVwWFZnNkJ6cXVzY0NPdkpOdjI2aW5MemJPRXo4NlJQakF2VHY0TjJ5?=
 =?utf-8?B?bVVZcU9mUTN6d01ZSHJGWXg3T3hXSGJnbWlWRHhsbFZueW1nZ1FZMlh3RnAw?=
 =?utf-8?B?MTRSSzA2dTQ4OTlhZzIvRUdlcjdqSFNZZS9OVU1ETmhQTUtJbDk5LzVrMjJM?=
 =?utf-8?B?Um9ncW92V1ZPZmpHQ0N5OXNzdEdYTXFsQ2pDQUpPa3hDRXF6Sk9OTjVBNjJ3?=
 =?utf-8?B?Ykx1emFOOWtwajN2UVpPYkgyc1poZ2ZpMEhxc0pZMWdSNWdlR1d3M3NISis4?=
 =?utf-8?B?N2wxMzVyR2kyREh3Y2ZSYWNTSXRKalh5OFp6dTlCKzQycEJNTDJyaG50RExT?=
 =?utf-8?B?aEdQRC9MRW5vdzJ4NWxza211dnBsdTlrNUxNMmdwdzU0ZVU5MnZZRllHT2t5?=
 =?utf-8?B?YURWWTZTaGJZQTlKbUhzWjJjYndBdHhJeWVWZE5PSDFKaktNaCtWSDYvK2VY?=
 =?utf-8?B?ditMdnNqRUlwNkZMUm9BYTFuVmE4VURwVWJLSDFOMy9USmx3b2pVdEUyMEY3?=
 =?utf-8?B?eGdnTitPeDI2VVVUbzR4ZVExZUpieTloUlQ5dCsyTGFUdXRTeUplNENJdFlt?=
 =?utf-8?B?cGdDY1RWUkpnSFJMMVdzY28zbmhlQnQ1cGl5UjB3SXRwdkgwUS91TlhLQm5E?=
 =?utf-8?B?TUpEemJQMGYyTVJ4UVB6SFRoZG80QjJXRkFpVVFEUkJNY04waVplbm8vNjg0?=
 =?utf-8?B?dEZSZWZ0REJRTXM0bGhxNU1CNHhZT24yZVpPN1JrL1F2WmgrYW5YK2REYnRv?=
 =?utf-8?B?Q2ZBUk9Qa2pzVWpES05EV2FKM3VaVzRMcVl2OWJCNE9Zc3BKbGlyTWloVGNX?=
 =?utf-8?B?bS9ZcjR3QTZudWUrdmxSYTI1WnZTWTJLNzI3LzdqckQwVnY4STFoQ0w1M1hU?=
 =?utf-8?B?TWZtK3ZzRFB5NC8wb3psRmVuK1RMZEt3ZGZHdHREaDNvejhkVGxUbjF6Z1pN?=
 =?utf-8?B?L1RtMDBvZkRmbnkvaGpJdjRsUDdsWXd6U3Rsd2pYNWFzMlN0cFVacEg2VXpW?=
 =?utf-8?B?N1doUzlKcjI0bTMwZWlLUEpnR2c5RGNseUJKVmRXOHNQakl3em1xeVFwdUFq?=
 =?utf-8?Q?CyjTiTBH6jmZoFApLL8dWOEfT?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c36712bc-f5f9-4951-8eb3-08dc81a8b60f
X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5732.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 May 2024 19:34:39.0302
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: sLY3zkQpsYXuRg/UvRvKSYfX12fv0uxrvZzETKQUEs8CYRIGg3c9RPAwjMQUtgLVvMotBA88r6lofDs49+oakQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4095

On 5/31/24 14:03, Borislav Petkov wrote:
> On Fri, May 31, 2024 at 01:36:06PM -0500, Tom Lendacky wrote:
>> The sev-guest driver needs to access it. Given it is a driver/module, I
>> created the accessor rather than mark the variable EXPORT_SYMBOL_GPL(). Your
>> call, I'm fine with either.
> 
> Yeah, if the variable doesn't change after init, then you don't really
> need an accessor.
> 
>> Yes, the driver can and does figure it out. However, this module parameter
>> was added in the off chance the default VMPCK gets wiped. Then you can
>> reload the driver and use a different (less privileged) VMPCK.
> 
> Is that what the text over snp_disable_vmpck() is alluding to?

Yes, I believe so.

> 
> Or where are we documenting this intended use?

It probably should have been documented above the module parameter itself 
and/or in the sev-guest documentation. Those can be done as part of this 
patch or separate, whichever is preferred.

Thanks,
Tom

> 
> Thx.
>