Received-SPF: pass (google.com: domain of linux-kernel+bounces-197377-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: John Hubbard <jhubbard@nvidia.com>
To: Shuah Khan <shuah@kernel.org>
Cc: angquan yu <angquan21@gmail.com>,
	"Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
	Ingo Molnar <mingo@kernel.org>,
	Binbin Wu <binbin.wu@linux.intel.com>,
	Alexey Dobriyan <adobriyan@gmail.com>,
	Rick Edgecombe <rick.p.edgecombe@intel.com>,
	Sohil Mehta <sohil.mehta@intel.com>,
	Yu-cheng Yu <yu-cheng.yu@intel.com>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	Muhammad Usama Anjum <usama.anjum@collabora.com>,
	Valentin Obst <kernel@valentinobst.de>,
	linux-kselftest@vger.kernel.org,
	LKML <linux-kernel@vger.kernel.org>,
	llvm@lists.linux.dev,
	x86@kernel.org,
	John Hubbard <jhubbard@nvidia.com>
Subject: [PATCH v3 0/7] selftests/x86: fix build errors and warnings found via clang
Date: Fri, 31 May 2024 12:38:31 -0700
Message-ID: <20240531193838.108454-1-jhubbard@nvidia.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?bBeZDNtMgtmO97bdwAdcphg784Tj8bkR03KfF/06vjBCcUlAiVJghoPauZOd?=
 =?us-ascii?Q?VOE5UD/em2RXcWXvlAgJveUE3l0L6TwAIcnhWFaGvkADUupFxD3NJ3iY3RMH?=
 =?us-ascii?Q?SOYoEXxQDJZkZw1k5m1/wZwMmiU+uI6K9bl42o90jBeCd0v5531SGkKrpnTf?=
 =?us-ascii?Q?fZHLr3MjcmgbWr3ogdcyrIvB7meFCWyaePptyxsMLPNRSjc9Fr6fVtO6h+K6?=
 =?us-ascii?Q?UF3rVTO0U92D14JmQgC9ld5AmFW98wU67xsAcmIa4KGTHUshrR5GlzdLattV?=
 =?us-ascii?Q?z6mEfHI0px3lom9rpM7LRNPHwMNz4oJ/zcTJtJrqbAdSnzdmkU3pCXl7pJmT?=
 =?us-ascii?Q?gslnxX/rA8xGY+EgpxAwZPG0M8+bSa8kMe3HDCxKFklTUAY8OhC/eFkxB+3C?=
 =?us-ascii?Q?3RBF3YKl8AAgSBZbalxS7PMI+6s1RJfoP0rtj36vrLtKd/43ClgxVxbXMU24?=
 =?us-ascii?Q?ZW2dhlkAitEqGpdj8AgHa6hYkb0zW8IoX6DURwnlsRQnXUllTVh/HjMvlas9?=
 =?us-ascii?Q?dSldXD4ITEQhwl40/5hROPY1necBx3z3Krezreg4vUPLhYfud2HYR44rMk8P?=
 =?us-ascii?Q?TDA2FppMCv2jY1QZ5OPrmS6H6X9i2ooIfZJoqoXgNek8qbPNeJ6ItDfrz2Hr?=
 =?us-ascii?Q?xrOChkXHBP1jJy0RtQiRwLUhe2gr88qtxTHyPU2NUUpSnC6aDYRQxK5GKs8H?=
 =?us-ascii?Q?SKkDDUEh+cEYFTX/ecQyEXZjOW+cUoxYtB6jvC1hS4zjalkcfFEedrhoVgj4?=
 =?us-ascii?Q?etxw4uRmuJ+PXmbvRJnCYRHTXFjoZw7x0zotSduTFFNZTyLd5qeil9UUrj8r?=
 =?us-ascii?Q?8F+BeyOZ6Fvv9wxRL+RRemvAsGVM3/FKJVZM8i5reVuUK/V8ImohN27MKI2P?=
 =?us-ascii?Q?hSqy/K/CecdpynWVmfc+0c94vUwfOGts3KX2lHKJQ1AwuStxqwfC025Lb4Qr?=
 =?us-ascii?Q?OjZjsnInVYVO85Gh5ngZrg3h8mV8MwGaal5wR69C/Tz0GGJizqs9l4Xtjhd4?=
 =?us-ascii?Q?oDIAD3OuQGNWc3Nu2yuegRwiYDferMNRPazY6CK69YeFFJpbVk9AtMHUzdg9?=
 =?us-ascii?Q?RITOyTGbsohGXUEF9W0QQpGxzq2J34AWziGWxOjIWEeilwO6wvia6nerVkVK?=
 =?us-ascii?Q?rkViBg5IGyQsxddH5omjqAA3E7+X6RQhTm4KmfZI9d3V7XA2jTM8pCfJFiND?=
 =?us-ascii?Q?tGOq2Zx5Afgkby0F+yIsqk+xhb1mAlg/McrkifP6nyMp9J3tbxeqSdLKUjDS?=
 =?us-ascii?Q?tqvZxWjsTwBJ09ZfhmcLXlfFpPvIcKYoQZjejMtuivZGvFB5FR3POSAcPFhg?=
 =?us-ascii?Q?VEcs47u2OF61FXbt3GLGZBznlfmZbMEN2PlMBmC6XWIz3tNbE1mwC0B9HGf3?=
 =?us-ascii?Q?Vc0KK2i+e8ZYZl5rSoYbtoJSDXS7tYCYEFwH5QxKmnMBIO1yQJ8aO59E9yyR?=
 =?us-ascii?Q?PE8mNr14pK2rwX9HHzYnYB+HnJzXwjv652GeIwUewqbnnzvR8AEnrwzEQwQO?=
 =?us-ascii?Q?q8JK+sHV+PLA1iKukEr0+F+epR6e6g57hfsWEKSIQbC1ZddXziQFLh5yxy+N?=
 =?us-ascii?Q?pigoNU9d/hAn1az4m0pY2fEsBONa0CK5b8/dmqCu?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a00d64c3-83aa-4367-5dd0-08dc81a945fe
X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB4130.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 May 2024 19:38:40.4416
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: rLfGlM+6H6f+TbOiaRxx8ZcW0V9r/ENz6j6gBh99rGkPYLf4YMJ1ekhXZFuEFbjkpuC8UQLpA27fwsDjNlnG8w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB7712

Hi,

Dave Hansen, Muhammad Usama Anjum, here is the combined series that we
discussed yesterday [1].

As I mentioned then, this is a bit intrusive--but no more than
necessary, IMHO. Specifically, it moves some clang-un-inlineable things
out to "pure" assembly code files.

I've tested this by building with clang, then running each binary on my
x86_64 test system with today's 6.10-rc1, and comparing the console and
dmesg output to a gcc-based build without these patches applied. Aside
from timestamps and virtual addresses, it looks identical.

Earlier cover letter:

Just a bunch of build and warnings fixes that show up when building with
clang. Some of these depend on each other, so I'm sending them as a
series.

Changes since v2:

1) Dropped my test_FISTTP.c patch, and picked up Muhammad's fix instead,
   seeing as how that was posted first.

2) Updated patch descriptions to reflect that Valentin Obst's build fix
   for LLVM [1] has already been merged into Linux main.

3) Minor wording and typo corrections in the commit logs throughout.

Changes since the first version:
1) Rebased onto Linux 6.10-rc1

Enjoy!

[1] https://lore.kernel.org/44428518-4d21-4de7-8587-04eceefb330d@nvidia.com

thanks,
John Hubbard

John Hubbard (6):
  selftests/x86: fix Makefile dependencies to work with clang
  selftests/x86: build fsgsbase_restore.c with clang
  selftests/x86: build sysret_rip.c with clang
  selftests/x86: avoid -no-pie warnings from clang during compilation
  selftests/x86: remove (or use) unused variables and functions
  selftests/x86: fix printk warnings reported by clang

Muhammad Usama Anjum (1):
  selftests: x86: test_FISTTP: use fisttps instead of ambiguous fisttp

 tools/testing/selftests/x86/Makefile          | 31 +++++++++++++++----
 tools/testing/selftests/x86/amx.c             | 16 ----------
 .../testing/selftests/x86/clang_helpers_32.S  | 11 +++++++
 .../testing/selftests/x86/clang_helpers_64.S  | 28 +++++++++++++++++
 tools/testing/selftests/x86/fsgsbase.c        |  6 ----
 .../testing/selftests/x86/fsgsbase_restore.c  | 11 +++----
 tools/testing/selftests/x86/sigreturn.c       |  2 +-
 .../testing/selftests/x86/syscall_arg_fault.c |  1 -
 tools/testing/selftests/x86/sysret_rip.c      | 20 ++++--------
 tools/testing/selftests/x86/test_FISTTP.c     |  8 ++---
 tools/testing/selftests/x86/test_vsyscall.c   | 15 +++------
 tools/testing/selftests/x86/vdso_restorer.c   |  2 ++
 12 files changed, 87 insertions(+), 64 deletions(-)
 create mode 100644 tools/testing/selftests/x86/clang_helpers_32.S
 create mode 100644 tools/testing/selftests/x86/clang_helpers_64.S


base-commit: 4a4be1ad3a6efea16c56615f31117590fd881358
-- 
2.45.1