Received-SPF: pass (google.com: domain of linux-kernel+bounces-197379-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: John Hubbard <jhubbard@nvidia.com>
To: Shuah Khan <shuah@kernel.org>
Cc: angquan yu <angquan21@gmail.com>,
	"Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
	Ingo Molnar <mingo@kernel.org>,
	Binbin Wu <binbin.wu@linux.intel.com>,
	Alexey Dobriyan <adobriyan@gmail.com>,
	Rick Edgecombe <rick.p.edgecombe@intel.com>,
	Sohil Mehta <sohil.mehta@intel.com>,
	Yu-cheng Yu <yu-cheng.yu@intel.com>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	Muhammad Usama Anjum <usama.anjum@collabora.com>,
	Valentin Obst <kernel@valentinobst.de>,
	linux-kselftest@vger.kernel.org,
	LKML <linux-kernel@vger.kernel.org>,
	llvm@lists.linux.dev,
	x86@kernel.org,
	John Hubbard <jhubbard@nvidia.com>
Subject: [PATCH v3 2/7] selftests: x86: test_FISTTP: use fisttps instead of ambiguous fisttp
Date: Fri, 31 May 2024 12:38:33 -0700
Message-ID: <20240531193838.108454-3-jhubbard@nvidia.com>
In-Reply-To: <20240531193838.108454-1-jhubbard@nvidia.com>
References: <20240531193838.108454-1-jhubbard@nvidia.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?l3Dw55TeSySlnIrt4shEgLbfuat5p51eSoZxkYQuWGd54N1zzc8kYtreNY/J?=
 =?us-ascii?Q?1579vc2UwMdxA8IVlwZ35gUa+O+I71hFG/lfyhv7sxJfm2TOUiBES6LpsIKL?=
 =?us-ascii?Q?NW5KE63sEMmWRTTeeFA2v9u4r9RsAyAqb7P6C+Ty8sK2/Wr8SMi1JAgb7h9y?=
 =?us-ascii?Q?BXqTA3vV0mFX6bB7OuqTx56GJp2CHGeaiDsgyAfCsu9vrgj2WmnBMgKK4nWV?=
 =?us-ascii?Q?FPnSTYKBkYICLoeU6ZvHHt9JKF14q70/3Nt2yjHkc9V5wcmlBcI/gRjszlpU?=
 =?us-ascii?Q?FB1dveY7K+TkKCmBYtkdRxWzLAATv+yIrdEoYvgG3ffBvGDunrF1TCK7Dlcj?=
 =?us-ascii?Q?IgnnJzjUfHG9RQ4NESSftNmjB6a5BR0KYVm9rGo2UmY4BSdXCZ7HLvK8OgxQ?=
 =?us-ascii?Q?rL4iVSSkgm/EDSVKRoXYeHX/Que0Opve5fYEGzj+kkqSm3LVwGEHb+88FIcx?=
 =?us-ascii?Q?LF4Qc3rVhneGiwrGg8cdb1MFy2TX4NaPlxrqH1WIoEw0rd7vQeDphjE4SFSW?=
 =?us-ascii?Q?FuJgAR5ryJnr6OMFRqz1nFcqqgdVc7YU4QX9hDG8EXbow39PWSWd28sGRV2+?=
 =?us-ascii?Q?bGM8ca+nGwy31EtUT0Jib4X2dFUu4NY4yW8GmW8Xr/8TqsS3QxgMedwqVYmH?=
 =?us-ascii?Q?amk/0DhRg5tnhUtFzUrvvi+9nnDw0hw8xTADplNd41F0mrPgaMDlCAZIDQIi?=
 =?us-ascii?Q?vY1p2O4whyKaZjjp+Q4cWI+T/UA09J3/GwrgY+EqAjsW6GdNvZJHu84lmRGv?=
 =?us-ascii?Q?kMIkOwQbhFgN3Dxwso6zOeOn6QwQrNxi7Db8MJ3j9ioiSQJYoaxO4YW4SYKx?=
 =?us-ascii?Q?t2xYTrgkYyoS1iPZTjZPeVHYLTEfYmX357wb9AE6j5sc1/bwtOIrbvIOhNRy?=
 =?us-ascii?Q?exepc33sOg3H6h2Sr11PWTyjhAfh3mzWWt3M3TTnVtdmpEKNVsEhigkb0+g4?=
 =?us-ascii?Q?NTjpH5+8+ih6G8QN8H/4S1p8rKQIJ0wr4XXeesqQakdT5SCOA1o5tJk+eF5m?=
 =?us-ascii?Q?y9O84KtMQhkuv+vzoQiH2rb9NLD81fw12hSH0TPrMSh4iMqr6BoVJmkfFn3g?=
 =?us-ascii?Q?2KDZ0EoeMIc3+JOdJAmCwlSDo0sg+55f+FaARG1cRsw1lDquxljZcN+mLvsQ?=
 =?us-ascii?Q?cEc3P5Efszd9p+8vbNchO1T9OByoIEBnE1E9/fw25N9hnY8BX3Bz0cXW6Bt2?=
 =?us-ascii?Q?8qnbPj6v9kX9Rx/wFNoukxEtU5n9Ci7E5J7fYF3W2BRodQhbekZ1aW+FAF8O?=
 =?us-ascii?Q?JNcsiyuvokzcAk2jnjH4hotUjr6SBqMOuy8i+z9GagCvHYPygPBJyTCbY853?=
 =?us-ascii?Q?qUGYf+qHMC1u2JLtPFt5O+ioIWouxLkJ3H521yNscKdZWQi3z39ZfAV+qgk3?=
 =?us-ascii?Q?wq0ORIyc6bY6APbCuJRPhYBId62zLl7yoXkAwUR1XOUyqrhOnu8juXYmqqJc?=
 =?us-ascii?Q?w7emvrFyykrKD/VLhN9lSbN96xHqWwMkna6mY34fzInnWYUYYBYwbzT7InR0?=
 =?us-ascii?Q?6Jik4TbdfSSF4lOJ2xdE9mMZ9u++t59Ztj8wAsSh+UuHOTm96r9GCmRUkQ0c?=
 =?us-ascii?Q?ru1QTwNAeFx6llz9Z6wfFv5U/GIjySX3xRFJfLSb?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cef0077f-628c-479b-f454-08dc81a946d9
X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB4130.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 May 2024 19:38:41.8638
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: NP5JlPt+tBcu6nnIeMzXbIzCVpjOKwe78gTLA+A8Xy8QJhG0CZOjUJcOUghukuNSra7nX3/ZYHOMpTnfXazTNg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB7712

From: Muhammad Usama Anjum <usama.anjum@collabora.com>

Use fisttps instead of fisttp to specify correctly that the output
variable is of size short.

test_FISTTP.c:28:3: error: ambiguous instructions require an explicit suffix (could be 'fisttps', or 'fisttpl')
   28 |         "       fisttp  res16""\n"
      |          ^
<inline asm>:3:2: note: instantiated into assembly here
    3 |         fisttp  res16
      |         ^

...followed by three more cases of the same warning for other lines.

Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
[jh: removed a bit of duplication from the warnings report, above, and
     fixed a typo in the title]
Signed-off-by: John Hubbard <jhubbard@nvidia.com>
---
 tools/testing/selftests/x86/test_FISTTP.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/tools/testing/selftests/x86/test_FISTTP.c b/tools/testing/selftests/x86/test_FISTTP.c
index 09789c0ce3e9..b9ae9d8cebcb 100644
--- a/tools/testing/selftests/x86/test_FISTTP.c
+++ b/tools/testing/selftests/x86/test_FISTTP.c
@@ -25,7 +25,7 @@ int test(void)
 	feclearexcept(FE_DIVBYZERO|FE_INEXACT|FE_INVALID|FE_OVERFLOW|FE_UNDERFLOW);
 	asm volatile ("\n"
 	"	fld1""\n"
-	"	fisttp	res16""\n"
+	"	fisttps	res16""\n"
 	"	fld1""\n"
 	"	fisttpl	res32""\n"
 	"	fld1""\n"
@@ -45,7 +45,7 @@ int test(void)
 	feclearexcept(FE_DIVBYZERO|FE_INEXACT|FE_INVALID|FE_OVERFLOW|FE_UNDERFLOW);
 	asm volatile ("\n"
 	"	fldpi""\n"
-	"	fisttp	res16""\n"
+	"	fisttps	res16""\n"
 	"	fldpi""\n"
 	"	fisttpl	res32""\n"
 	"	fldpi""\n"
@@ -66,7 +66,7 @@ int test(void)
 	asm volatile ("\n"
 	"	fldpi""\n"
 	"	fchs""\n"
-	"	fisttp	res16""\n"
+	"	fisttps	res16""\n"
 	"	fldpi""\n"
 	"	fchs""\n"
 	"	fisttpl	res32""\n"
@@ -88,7 +88,7 @@ int test(void)
 	feclearexcept(FE_DIVBYZERO|FE_INEXACT|FE_INVALID|FE_OVERFLOW|FE_UNDERFLOW);
 	asm volatile ("\n"
 	"	fldln2""\n"
-	"	fisttp	res16""\n"
+	"	fisttps	res16""\n"
 	"	fldln2""\n"
 	"	fisttpl	res32""\n"
 	"	fldln2""\n"
-- 
2.45.1