Received-SPF: pass (google.com: domain of linux-kernel+bounces-197384-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
From: John Hubbard <jhubbard@nvidia.com>
To: Shuah Khan <shuah@kernel.org>
Cc: angquan yu <angquan21@gmail.com>,
	"Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
	Ingo Molnar <mingo@kernel.org>,
	Binbin Wu <binbin.wu@linux.intel.com>,
	Alexey Dobriyan <adobriyan@gmail.com>,
	Rick Edgecombe <rick.p.edgecombe@intel.com>,
	Sohil Mehta <sohil.mehta@intel.com>,
	Yu-cheng Yu <yu-cheng.yu@intel.com>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	Muhammad Usama Anjum <usama.anjum@collabora.com>,
	Valentin Obst <kernel@valentinobst.de>,
	linux-kselftest@vger.kernel.org,
	LKML <linux-kernel@vger.kernel.org>,
	llvm@lists.linux.dev,
	x86@kernel.org,
	John Hubbard <jhubbard@nvidia.com>
Subject: [PATCH v3 6/7] selftests/x86: remove (or use) unused variables and functions
Date: Fri, 31 May 2024 12:38:37 -0700
Message-ID: <20240531193838.108454-7-jhubbard@nvidia.com>
In-Reply-To: <20240531193838.108454-1-jhubbard@nvidia.com>
References: <20240531193838.108454-1-jhubbard@nvidia.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?sX+CmANIn6QrDXWwE5IJ5m8xwQ4Zyy0ss+GI/q9qwCKJZf8Ux+hdP6CqwjzM?=
 =?us-ascii?Q?/kdyDQk8Kn5flE2FcFKaTFZkGA8wFDdNaJwja9tO9+c7myLxnd7QI8jSF0pW?=
 =?us-ascii?Q?WGtyX2s7+1Z7pIkXAP+NJ4LYxhocWD5RoMY8itNNybGuQYGiMNQfOwMkl8Wb?=
 =?us-ascii?Q?FH8vv8eYL3Zr4nfEZbEItKKtAhf6SDC4cddAFj0UCR4UssE/JtlJJKSnFU9z?=
 =?us-ascii?Q?+is7+GoBLXefLyvN9Vdogor/2g/Ug0nFNuK1B6RoI1CXq6hKnaJuraT+CLbq?=
 =?us-ascii?Q?A5mFZEWplffeZghZW4wKqBxYq9Jr3GyaehekjjC6voCsg3twfB4AxpYzjTEV?=
 =?us-ascii?Q?r6t7yJz0ps0tNuMAStNxPNT7DZ9F+0LJhrDL5M9iKnhcEwyE9FF7+VIqb72e?=
 =?us-ascii?Q?ScyouxNjozfSx5CS8rdvfv47q6R/4g8FmgNhwfSFHYdsvvayw/uYCB/Byfaa?=
 =?us-ascii?Q?V6FDpQKedHbq9rFh99UIxfVhD6bQ5L/VkaJda4nxjR3aqlZGbtX0pLQTMS7v?=
 =?us-ascii?Q?23nOglkG556RkZDNBtAlYN1ZU0grASsgjc10CUljHetKet1LVRmBgFuVqjC1?=
 =?us-ascii?Q?0k56HxCT4Yc7eyywma5hg0Xqhp8SMAfodQVnfIBzLrBPrp7BYulVH75bgqtO?=
 =?us-ascii?Q?pe1v2yDFhY+6GkamkvPjFEyvD0pgG9uGbW7YO6wTx2dm2BA3NZVm4oEMDMgN?=
 =?us-ascii?Q?yLUI5ZLjLL3ofnSbilQU1xk8bmWO64uGLfbte03lsAKqjCFrEiDxphatslQ5?=
 =?us-ascii?Q?n7LwkvMNK06LlzvgHMFMApswkr8m0MA+smZnM2dkcw95WABd0aT1Pev7lVpj?=
 =?us-ascii?Q?qNP4UKTz+IdvS/0AW5V3nMgwdiFYpePx2E13l4ZnXiDezPneX7/W6oKFYVF8?=
 =?us-ascii?Q?wkVkGsfWZTBNMESfbXMwuc/K4npjOUB+VN8GmHYUFBaADZJIVq0JhmiNqM6V?=
 =?us-ascii?Q?Q7uxFQqj4WPP29XPFYhQFXl+w/tz6LaKOhIfrCbHOn2HNbHGyrqPLHKAf1ek?=
 =?us-ascii?Q?u7yY2n0iPG9/DzQhxJuq9XA5ywR6EM/7OBmVV/wlYS+7lukgWoIn39Btp5qQ?=
 =?us-ascii?Q?4YjLW36XlsccB6rRhkc+5QIVdp0xL1AVLbQDzBamZB7Ew7auepiJ6Z/WprpF?=
 =?us-ascii?Q?cazegdFuZmCVaYJC5GX+sl2MvOgqizyZWixkluT8npOcmPoyBOD5GES+M0Yx?=
 =?us-ascii?Q?9POY1nwCxStGQ8MJeuU22hAf2orvdqFVzsWgYzFdvgvFcj66Gui8a0pRrnNa?=
 =?us-ascii?Q?wVFtIv6rkDeOwu0QZXKueiuoIjO334uDBWKpNJblYnHkm+oiXcI1r7GToOq4?=
 =?us-ascii?Q?Rxzzksphuh5iFkHXKw92LLWjxTR2Fe/FbVk7S2KC30e5v9mQ6+rFIwkYDnS9?=
 =?us-ascii?Q?0QU1e7WJWSFTLcvKSJfwG4dlBLffgn53eX15BK1KBzjUTwJTXykEPv6YzylC?=
 =?us-ascii?Q?Z+8CH4qzw1FP+zq2tIVxMhfQGDLOIlW3i81XDDnbUBS3Cu+i7Eg+/gl6z8zL?=
 =?us-ascii?Q?M5GCgGs1gHvcCANdE3i0oBsnPiY2rzd3evQXlSPQBB/D+pXaIMVKvSU370hu?=
 =?us-ascii?Q?lP4kNOb2Kso00vm/l4KZpJtxYI75FBnUA6j5YvLX?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b4dadd16-7edd-4ddb-4c71-08dc81a9483d
X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB4130.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 May 2024 19:38:44.1955
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: CNEGRjnTAv/B4JHp5CB50V8Q/JUmmORUfIgqK/uEFjDon1wGedPoa2mSDZMFrKYsDDCCVqJT+DStueY5s6/nAw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB9008

When building with clang, via:

    make LLVM=1 -C tools/testing/selftests

...quite a few functions are variables are generating "unused" warnings.
Fix the warnings by deleting the unused items.

One item, the "nerrs" variable in vsdo_restorer.c's main(), is unused
but probably wants to be returned from main(), as a non-zero result.
That result is also unused right now, so another option would be to
delete it entirely, but this way, main() also gets fixed. It was missing
a return value.

Signed-off-by: John Hubbard <jhubbard@nvidia.com>
---
 tools/testing/selftests/x86/amx.c               | 16 ----------------
 tools/testing/selftests/x86/fsgsbase.c          |  6 ------
 tools/testing/selftests/x86/syscall_arg_fault.c |  1 -
 tools/testing/selftests/x86/test_vsyscall.c     |  5 -----
 tools/testing/selftests/x86/vdso_restorer.c     |  2 ++
 5 files changed, 2 insertions(+), 28 deletions(-)

diff --git a/tools/testing/selftests/x86/amx.c b/tools/testing/selftests/x86/amx.c
index 95aad6d8849b..1fdf35a4d7f6 100644
--- a/tools/testing/selftests/x86/amx.c
+++ b/tools/testing/selftests/x86/amx.c
@@ -39,16 +39,6 @@ struct xsave_buffer {
 	};
 };
 
-static inline uint64_t xgetbv(uint32_t index)
-{
-	uint32_t eax, edx;
-
-	asm volatile("xgetbv;"
-		     : "=a" (eax), "=d" (edx)
-		     : "c" (index));
-	return eax + ((uint64_t)edx << 32);
-}
-
 static inline void xsave(struct xsave_buffer *xbuf, uint64_t rfbm)
 {
 	uint32_t rfbm_lo = rfbm;
@@ -164,12 +154,6 @@ static inline void clear_xstate_header(struct xsave_buffer *buffer)
 	memset(&buffer->header, 0, sizeof(buffer->header));
 }
 
-static inline uint64_t get_xstatebv(struct xsave_buffer *buffer)
-{
-	/* XSTATE_BV is at the beginning of the header: */
-	return *(uint64_t *)&buffer->header;
-}
-
 static inline void set_xstatebv(struct xsave_buffer *buffer, uint64_t bv)
 {
 	/* XSTATE_BV is at the beginning of the header: */
diff --git a/tools/testing/selftests/x86/fsgsbase.c b/tools/testing/selftests/x86/fsgsbase.c
index 8c780cce941d..50cf32de6313 100644
--- a/tools/testing/selftests/x86/fsgsbase.c
+++ b/tools/testing/selftests/x86/fsgsbase.c
@@ -109,11 +109,6 @@ static inline void wrgsbase(unsigned long gsbase)
 	asm volatile("wrgsbase %0" :: "r" (gsbase) : "memory");
 }
 
-static inline void wrfsbase(unsigned long fsbase)
-{
-	asm volatile("wrfsbase %0" :: "r" (fsbase) : "memory");
-}
-
 enum which_base { FS, GS };
 
 static unsigned long read_base(enum which_base which)
@@ -212,7 +207,6 @@ static void mov_0_gs(unsigned long initial_base, bool schedule)
 }
 
 static volatile unsigned long remote_base;
-static volatile bool remote_hard_zero;
 static volatile unsigned int ftx;
 
 /*
diff --git a/tools/testing/selftests/x86/syscall_arg_fault.c b/tools/testing/selftests/x86/syscall_arg_fault.c
index 461fa41a4d02..48ab065a76f9 100644
--- a/tools/testing/selftests/x86/syscall_arg_fault.c
+++ b/tools/testing/selftests/x86/syscall_arg_fault.c
@@ -29,7 +29,6 @@ static void sethandler(int sig, void (*handler)(int, siginfo_t *, void *),
 		err(1, "sigaction");
 }
 
-static volatile sig_atomic_t sig_traps;
 static sigjmp_buf jmpbuf;
 
 static volatile sig_atomic_t n_errs;
diff --git a/tools/testing/selftests/x86/test_vsyscall.c b/tools/testing/selftests/x86/test_vsyscall.c
index d4c8e8d79d38..1c9895cfc660 100644
--- a/tools/testing/selftests/x86/test_vsyscall.c
+++ b/tools/testing/selftests/x86/test_vsyscall.c
@@ -97,11 +97,6 @@ static inline long sys_gtod(struct timeval *tv, struct timezone *tz)
 	return syscall(SYS_gettimeofday, tv, tz);
 }
 
-static inline int sys_clock_gettime(clockid_t id, struct timespec *ts)
-{
-	return syscall(SYS_clock_gettime, id, ts);
-}
-
 static inline long sys_time(time_t *t)
 {
 	return syscall(SYS_time, t);
diff --git a/tools/testing/selftests/x86/vdso_restorer.c b/tools/testing/selftests/x86/vdso_restorer.c
index fe99f2434155..ac8d8e1e9805 100644
--- a/tools/testing/selftests/x86/vdso_restorer.c
+++ b/tools/testing/selftests/x86/vdso_restorer.c
@@ -92,4 +92,6 @@ int main()
 		printf("[FAIL]\t!SA_SIGINFO handler was not called\n");
 		nerrs++;
 	}
+
+	return nerrs;
 }
-- 
2.45.1