Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754825AbYBDOxf (ORCPT ); Mon, 4 Feb 2008 09:53:35 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751058AbYBDOx1 (ORCPT ); Mon, 4 Feb 2008 09:53:27 -0500 Received: from mx3.mail.elte.hu ([157.181.1.138]:52626 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750925AbYBDOx0 (ORCPT ); Mon, 4 Feb 2008 09:53:26 -0500 Date: Mon, 4 Feb 2008 15:53:11 +0100 From: Ingo Molnar To: Jeff Chua Cc: Jan Engelhardt , Thomas Gleixner , Linux Kernel Mailing List , petr@vandrovec.name, Glauber de Oliveira Costa Subject: Re: Commit f06e4ec breaks vmware Message-ID: <20080204145311.GB13154@elte.hu> References: <20080204115144.GA17850@elte.hu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2040 Lines: 59 * Jeff Chua wrote: > On Feb 4, 2008 7:51 PM, Ingo Molnar wrote: > > > > sad to say, but f06e4ec... breaks booting the kernel in vmware > > > commit f06e4ec1c15691b0cfd2397ae32214fa36c90d71 > > I had the same problem. But I bisect down to a earlier commit. > Reverting this patch, and I can boot up using vmware. > > commit 8d947344c47a40626730bb80d136d8daac9f2060 > Author: Glauber de Oliveira Costa > Date: Wed Jan 30 13:31:12 2008 +0100 > > x86: change write_idt_entry signature does the patch below ontop of x86.git#mm fix this? Ingo --- arch/x86/kernel/vmi_32.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) Index: linux-x86.q/arch/x86/kernel/vmi_32.c =================================================================== --- linux-x86.q.orig/arch/x86/kernel/vmi_32.c +++ linux-x86.q/arch/x86/kernel/vmi_32.c @@ -220,21 +220,21 @@ static void vmi_set_tr(void) static void vmi_write_idt_entry(gate_desc *dt, int entry, const gate_desc *g) { u32 *idt_entry = (u32 *)g; - vmi_ops.write_idt_entry(dt, entry, idt_entry[0], idt_entry[2]); + vmi_ops.write_idt_entry(dt, entry, idt_entry[0], idt_entry[1]); } static void vmi_write_gdt_entry(struct desc_struct *dt, int entry, const void *desc, int type) { u32 *gdt_entry = (u32 *)desc; - vmi_ops.write_gdt_entry(dt, entry, gdt_entry[0], gdt_entry[2]); + vmi_ops.write_gdt_entry(dt, entry, gdt_entry[0], gdt_entry[1]); } static void vmi_write_ldt_entry(struct desc_struct *dt, int entry, const void *desc) { u32 *ldt_entry = (u32 *)desc; - vmi_ops.write_idt_entry(dt, entry, ldt_entry[0], ldt_entry[2]); + vmi_ops.write_idt_entry(dt, entry, ldt_entry[0], ldt_entry[1]); } static void vmi_load_sp0(struct tss_struct *tss, -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/