Received-SPF: pass (google.com: domain of linux-kernel+bounces-197429-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: John Hubbard <jhubbard@nvidia.com>
To: Shuah Khan <shuah@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Darren Hart <dvhart@infradead.org>,
	Davidlohr Bueso <dave@stgolabs.net>,
	Edward Liaw <edliaw@google.com>,
	=?UTF-8?q?Andr=C3=A9=20Almeida?= <andrealmeid@igalia.com>,
	"Nysal Jan K . A" <nysal@linux.ibm.com>,
	Mark Brown <broonie@kernel.org>,
	Valentin Obst <kernel@valentinobst.de>,
	linux-kselftest@vger.kernel.org,
	LKML <linux-kernel@vger.kernel.org>,
	llvm@lists.linux.dev,
	John Hubbard <jhubbard@nvidia.com>
Subject: [PATCH v3 2/3] selftests/futex: don't pass a const char* to asprintf(3)
Date: Fri, 31 May 2024 13:07:54 -0700
Message-ID: <20240531200755.128749-3-jhubbard@nvidia.com>
In-Reply-To: <20240531200755.128749-1-jhubbard@nvidia.com>
References: <20240531200755.128749-1-jhubbard@nvidia.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?oLSKu0ryYG0Aa7MgQwB2f0U+/V3Fop1Rsr3SSz22Vjew1LzzLF2A3SL6Y+9u?=
 =?us-ascii?Q?hkFx80m4e7vw7zAkTlHtmjPo74ocfp6OWYyF9FWuJwkRmuwVhUy6YbaLE31a?=
 =?us-ascii?Q?XXoTLmEcZGEZx5v0ALKOANqsN82+YlukeqGprnV+DaSXCTC2zPT6peWRCa5g?=
 =?us-ascii?Q?3Jc2q7RFGAwNlFD/RxXNjdw32T2jmubFIuJdQeEID8nNmN8huY4WlYgTbPbK?=
 =?us-ascii?Q?4H2rZwzf4/o+Sec2vTjeX08RXpS7VLmmhg0EcUOPuJJbaQXvZ0G40tBgQxRf?=
 =?us-ascii?Q?0EwMpBpzvaPsQ4lBpSb5i10cTQKS5bSopmivDRXsIKBkmyt+rsXVlub3aUBE?=
 =?us-ascii?Q?dVcsgUIXnd2iu5fs37DE53gUXMKqshldMQ8oVdeZVuRdbNd+SDiWG1fp7KQ8?=
 =?us-ascii?Q?HqV2xywvPXhjkXnhycX43bv88scxj53Gtbqk1EWAqCkctJj86Gkn013AeZW5?=
 =?us-ascii?Q?Q9X264VpIEln11hIvrmxZAtiPFuZ8FzJpADCx9jhKhuUU80/EomYsYFndAOp?=
 =?us-ascii?Q?vHD/gBPfDKcpe+0rysfSFu+GdECerthn63AeEfB5R3ApxoAYCVLS08lAxJvc?=
 =?us-ascii?Q?UertAhLxSD1KLkY098R4fnDIsGPS369tNV1iqQJWd5X7n/RJWbcLQLdQfQV5?=
 =?us-ascii?Q?yQCkagdOMOjev0+d8Fcu3C3SkcmtHG206lafeQ4xd5rj77sI4Ah9EI+2yqdI?=
 =?us-ascii?Q?2bTmKmetP5WTFZ4+qsdfAwFHmK6Q3MJlkwk1Fl4lXwBxcHYL+ktzjlFXcsPt?=
 =?us-ascii?Q?4btZbA9vmO3IVM49Efm59feko6AUr5OJpmEivBblWOzJ4Vlb+HubAfyNu8Wm?=
 =?us-ascii?Q?fPm4GyOJPWstBxjTUkmddgdnxZ/6Z9pnbwX/+d6618JYBhH4lZIrdVcMjOoR?=
 =?us-ascii?Q?UX415IJJrK3jymX04Yhrl9o9hpSuE/COuSYTqBHRSVwyJ6kfMNP6LNhccyJZ?=
 =?us-ascii?Q?qMWiq7gg4NnzV1tIxur4jB/eYiQNf6ppM1bxEAtYq+8xXZw/p+jxXTsbfeKT?=
 =?us-ascii?Q?Gd2wrx3waVR5HlAzDA7+sw8j1DdC0rF0j+5FkGwr0ncvbiPsoErUsl+M7LRZ?=
 =?us-ascii?Q?FNibAT6c073hcYkXxsE7b1i3feopi75KqAGP/OtoYzj959wBMD/BqGvsc96+?=
 =?us-ascii?Q?Tuy84SHG506Q9pukMphld0L4Zuu3mJADpIVWWwKuud6ahJpliY44GmQyIoN/?=
 =?us-ascii?Q?P4efS5vowjLPMk98StJlKfKWk666J2y9irdWKZLwqix9RUuN/arOvtZcXIZk?=
 =?us-ascii?Q?HQzNWprx1FvwFH5fk/cnQN161y6tS2F6i9EjW2NZ5T76MgC+7qAUZyqWJp0I?=
 =?us-ascii?Q?CsBOIz3tcSOvFrYx7KZiO8pZbWCfE0paBDN0F1WrXBykSpmrI/MPjYAFaR7U?=
 =?us-ascii?Q?6ved11aBe/2Bns6gmkfU7qk2Urkj86C5cFxzBHE1loSKGuqkTrH3lqu2DeK6?=
 =?us-ascii?Q?rYCm54Hx/6//jYpuMtBIBVSpPGGEyCI6T76N7EHj0Jsbncq1LAa4OaQfEeoO?=
 =?us-ascii?Q?nyU5VnYRQdHFgjTg3VHiw8iI3PsQcCaq7kOhMfSmqEwssr3zboeUYSrJHa+w?=
 =?us-ascii?Q?8FImdlxbTyYPIFnJ8YZPkPYt/85zbXWWbGQ1Iv0q?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 25abace0-c4fa-47f9-f76f-08dc81ad5f4f
X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB4130.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 May 2024 20:08:00.8825
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: LyGXHVkiLc0Y2OEzE5pYKh5cIJNV0BBknrupVB/3HPsJb8qgaIGfmnzWP8bZ4EXmjMqBfHTptkLlhG9jT7eg6g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB8880

When building with clang, via:

    make LLVM=1 -C tools/testing/selftests

...clang issues this warning:

futex_requeue_pi.c:403:17: warning: passing 'const char **' to parameter
of type 'char **' discards qualifiers in nested pointer types
[-Wincompatible-pointer-types-discards-qualifiers]

This warning fires because test_name is passed into asprintf(3), which
then changes it.

Fix this by simply removing the const qualifier. This is a local
automatic variable in a very short function, so there is not much need
to use the compiler to enforce const-ness at this scope.

[1] https://lore.kernel.org/all/20240329-selftests-libmk-llvm-rfc-v1-1-2f9ed7d1c49f@valentinobst.de/

Fixes: f17d8a87ecb5 ("selftests: fuxex: Report a unique test name per run of futex_requeue_pi")
Reviewed-by: Davidlohr Bueso <dave@stgolabs.net>
Signed-off-by: John Hubbard <jhubbard@nvidia.com>
---
 tools/testing/selftests/futex/functional/futex_requeue_pi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/futex/functional/futex_requeue_pi.c b/tools/testing/selftests/futex/functional/futex_requeue_pi.c
index 7f3ca5c78df1..215c6cb539b4 100644
--- a/tools/testing/selftests/futex/functional/futex_requeue_pi.c
+++ b/tools/testing/selftests/futex/functional/futex_requeue_pi.c
@@ -360,7 +360,7 @@ int unit_test(int broadcast, long lock, int third_party_owner, long timeout_ns)
 
 int main(int argc, char *argv[])
 {
-	const char *test_name;
+	char *test_name;
 	int c, ret;
 
 	while ((c = getopt(argc, argv, "bchlot:v:")) != -1) {
-- 
2.45.1