Received-SPF: pass (google.com: domain of linux-kernel+bounces-197431-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: John Hubbard <jhubbard@nvidia.com>
To: Shuah Khan <shuah@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Darren Hart <dvhart@infradead.org>,
	Davidlohr Bueso <dave@stgolabs.net>,
	Edward Liaw <edliaw@google.com>,
	=?UTF-8?q?Andr=C3=A9=20Almeida?= <andrealmeid@igalia.com>,
	"Nysal Jan K . A" <nysal@linux.ibm.com>,
	Mark Brown <broonie@kernel.org>,
	Valentin Obst <kernel@valentinobst.de>,
	linux-kselftest@vger.kernel.org,
	LKML <linux-kernel@vger.kernel.org>,
	llvm@lists.linux.dev,
	John Hubbard <jhubbard@nvidia.com>
Subject: [PATCH v3 3/3] selftests/futex: pass _GNU_SOURCE without a value to the compiler
Date: Fri, 31 May 2024 13:07:55 -0700
Message-ID: <20240531200755.128749-4-jhubbard@nvidia.com>
In-Reply-To: <20240531200755.128749-1-jhubbard@nvidia.com>
References: <20240531200755.128749-1-jhubbard@nvidia.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?Sx49zpABabw+98W7m+BDF7X1ID8xqDMQ7rELMN5e2cNAHV3uMveQEXmdPWjo?=
 =?us-ascii?Q?8QWK/QmswGOb6+CjQqyfJH9GmjR1BPYiCk+EoR+nD4s5AmiQprN7TqFKOv/O?=
 =?us-ascii?Q?j+AGa4NyW/nJynr3SWfZbssN4mp5Lq/rTYu3COKVnK1mK3bqXIN7fPNDteVh?=
 =?us-ascii?Q?wN8h5id8Wt1a+OLGpQecTQ6bIUy+c0e8QzthluJAKfJBfjPjgQ25zqv8AiIy?=
 =?us-ascii?Q?qgSNCyWRIV+F0k2EFZYVBl1MhKowOpsVO60xexYznnCLOaPsC7yEha4eo3nS?=
 =?us-ascii?Q?/AJWv6hNCeMoYSMf3Eq8vLg7tbsC9KvbNSA2CFccNXK5rwtc/puPw4z+Ed/H?=
 =?us-ascii?Q?m+yiqYRjGoGp72qjSTduZEQMMeBkHoLcHTzUa9OJGzyYPl8tn5VFG2UgG9Ge?=
 =?us-ascii?Q?bAMN8z6VKWh6oyWxStQRK8SAFhN5PBNV9U3uOiLK1eAjHF1CNemSjwaNM8Kt?=
 =?us-ascii?Q?Zup6OSpMAbB0niC09rENKka1mliNvyIrz0+exITGg5cKn/6sDg5bAlZeEGvw?=
 =?us-ascii?Q?2U+GNBRwh3h46Y/vN1FkEhaqwMsvx8KbG2WsTxCFbKaa3u3pKViHM2P5GLYw?=
 =?us-ascii?Q?OcVAXYFUccq5lrrBlkrVkwEP5gnu0aKu8/cr/ukkhLxk95s38Ab8kU0iFqjh?=
 =?us-ascii?Q?rEhetDAt/YUPkLTS0kqwjLrbNKLITczIrXviOGPvMkkXYkb06EfD3yKNwi4w?=
 =?us-ascii?Q?KtKigGzAPd/7Q/k4ixUTMmQF2XfyPV3FemUHQhzqmaFw+lPQSyWWoJBDqUqh?=
 =?us-ascii?Q?jgkBVWIJWDkfpSbJKzhA3/ABanDgF9xOYGS2e/Lpfw8u3EkEdGXGc/CChQ8/?=
 =?us-ascii?Q?jw/LaOf3ROgrKO7DSEIX765Me3vrO3gzxqCAH4gDucwTRg08YlhIJToMM3KU?=
 =?us-ascii?Q?3X3tCcoitiIo5OGku68reoFgCr4P8lypMARe8C3h5t0jRbklgNCIk7kXzOM5?=
 =?us-ascii?Q?aUAwYyZh0hVg0wFQwm2XYFPtBbJhiySmxxkYxu+w37yUDJ6VSpequo7+llwZ?=
 =?us-ascii?Q?BL0aJDSZM2An8KsyadVwmKuw7615OEP1IMfeMpfwzD3V0P7Zdq6+amvOEwKt?=
 =?us-ascii?Q?Z7BLTjNLMOcIUOB8sZPN7QAZwCUhwQA5eHcB0AUzl4Vy6r7Muaqf0i5bjDpG?=
 =?us-ascii?Q?eln0yjgcNJhJRn2IKEbA9cbyYOCn8iCpNbLyAyf+k8ASpV6p/pl9Oi2DPrVb?=
 =?us-ascii?Q?P6r+aY7ReFfNDcPQs7JatQs24QULKlW321nkcFZObKLtPw5VdRCRIVeH5r2m?=
 =?us-ascii?Q?8axGFQjzEW4k7lS5Xono4zIONSQlg6bp+4onukH/CU2yJT36ZbgKcpdvra/w?=
 =?us-ascii?Q?LnBHWoHXQpO0iw0qLH0HsqFSU5YfMLTpWQBicO3SWjk8gy7cBc+70yJxcJz+?=
 =?us-ascii?Q?Ok+tW8lEaaWIQqWsFLaP+RuaIh13DuKo+3eZR3yNo4PDcZKnjOwavWIkou+d?=
 =?us-ascii?Q?omeDfUUM6hU6qxa4eNvQCj2MMbgXLL8ZilkLRoLIHTl0nww1rQrtDb38tZQz?=
 =?us-ascii?Q?f8/r0KXkJVVRRwZaLYGzz9TseL0WlPjQNVTyPhsLlIuvoq4MTry757S9b220?=
 =?us-ascii?Q?XjqNm6IWmTrIQy6OuB9VjeyYq85N+h2nHdmOk1qg?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0c8d40b6-9056-461f-6020-08dc81ad5fbe
X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB4130.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 May 2024 20:08:01.6616
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: TSnSRU0lxLdPUunJKyR9cxI6LryTrSwuOnXA0qmF//1TdR1S4h6XcfYL4DSSSoADjlCUVMDj/Dp0jeEUcg9lkw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB8880

It's slightly better to set _GNU_SOURCE in the source code, but if one
must do it via the compiler invocation, then the best way to do so is
this:

    $(CC) -D_GNU_SOURCE=

...because otherwise, if this form is used:

    $(CC) -D_GNU_SOURCE

...then that leads the compiler to set a value, as if you had passed in:

    $(CC) -D_GNU_SOURCE=1

That, in turn, leads to warnings under both gcc and clang, like this:

    futex_requeue_pi.c:20: warning: "_GNU_SOURCE" redefined

Fix this by using the "-D_GNU_SOURCE=" form.

Reviewed-by: Edward Liaw <edliaw@google.com>
Reviewed-by: Davidlohr Bueso <dave@stgolabs.net>
Signed-off-by: John Hubbard <jhubbard@nvidia.com>
---
 tools/testing/selftests/futex/functional/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/futex/functional/Makefile b/tools/testing/selftests/futex/functional/Makefile
index a392d0917b4e..994fa3468f17 100644
--- a/tools/testing/selftests/futex/functional/Makefile
+++ b/tools/testing/selftests/futex/functional/Makefile
@@ -1,6 +1,6 @@
 # SPDX-License-Identifier: GPL-2.0
 INCLUDES := -I../include -I../../ $(KHDR_INCLUDES)
-CFLAGS := $(CFLAGS) -g -O2 -Wall -D_GNU_SOURCE -pthread $(INCLUDES) $(KHDR_INCLUDES)
+CFLAGS := $(CFLAGS) -g -O2 -Wall -D_GNU_SOURCE= -pthread $(INCLUDES) $(KHDR_INCLUDES)
 LDLIBS := -lpthread -lrt
 
 LOCAL_HDRS := \
-- 
2.45.1