Received-SPF: pass (google.com: domain of linux-kernel+bounces-197409-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Fri, 31 May 2024 21:56:28 +0200
From: Andrew Lunn <andrew@lunn.ch>
To: Christian Marangi <ansuelsmth@gmail.com>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
	Russell King <linux@armlinux.org.uk>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Robert Marko <robimarko@gmail.com>,
	Daniel Golle <daniel@makrotopia.org>,
	"Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>,
	=?utf-8?B?UGF3ZcWC?= Owoc <frut3k7@gmail.com>,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [net-next PATCH v2 2/2] net: phy: aquantia: add support for PHY
 LEDs
Message-ID: <25ce6c90-f7c0-4c88-966f-8bbfe59ebde4@lunn.ch>
References: <20240530212043.9006-1-ansuelsmth@gmail.com>
 <20240530212043.9006-2-ansuelsmth@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240530212043.9006-2-ansuelsmth@gmail.com>

> +#define AQR_MAX_LEDS				3

> +int aqr_phy_led_brightness_set(struct phy_device *phydev,
> +			       u8 index, enum led_brightness value)
> +{
> +	if (index > 2)
> +		return -EINVAL;

AQR_MAX_LEDS should be used here.

Apart from that:

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

pw-bot: cr